From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Van Haaren, Harry" <harry.van.haaren@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] e1000: mark rxq with RTE_SET_USED
Date: Wed, 28 Oct 2015 18:13:23 +0100 [thread overview]
Message-ID: <2215673.djjjMEhqQv@xps13> (raw)
In-Reply-To: <E115CCD9D858EF4F90C690B0DCB4D8973C83DE28@IRSMSX108.ger.corp.intel.com>
2015-10-28 16:18, De Lara Guarch, Pablo:
> > This patch marks rxq with RTE_SET_USED in
> > rx_desc_hlen_type_rss_to_pkt_flags(), when
> > ieee1588 is disabled. Previously a compilation
> > error occurred on unused-parameter.
> >
> > Fixes: 1ce6591e238a ("igb: fix ieee1588 frame identification in i210")
> >
> > Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
>
> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Applied, thanks
To avoid such break, we must check carefully the compilation with
different combinations of options.
Hope the automated tests will help us more in the near future.
prev parent reply other threads:[~2015-10-28 17:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-28 16:08 Harry van Haaren
2015-10-28 16:18 ` De Lara Guarch, Pablo
2015-10-28 17:13 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2215673.djjjMEhqQv@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=harry.van.haaren@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).