From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f178.google.com (mail-wi0-f178.google.com [209.85.212.178]) by dpdk.org (Postfix) with ESMTP id 689BF8DA1 for ; Wed, 28 Oct 2015 18:14:35 +0100 (CET) Received: by wijp11 with SMTP id p11so263764318wij.0 for ; Wed, 28 Oct 2015 10:14:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind_com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=c1i73OsjWxy8syDrG04LtBK4SNZO4XSVvDJ9zpZ/ucM=; b=kId5olh+x7fSWBZdX3TDpEnHtDGFr29tihG3pWWcGWA7VxyFcT3416ZxH2gLaEck4w Hhnb0h2ttmc4sFo5bbmFDs5016Wi40AevaL1a5O6ITFBioBsqpeJCESA6AfZITebeEVY CYQFinSvgsRjVw2KmCX0qajk+CIE3vU4HIthrtZIZ6gwE+DEAolQhLHU/bWNZoDCmB7K okXzRdJGJFU11zfUwFSSAyrMfm6tcqWgSuIflTjXXuL86dpPUhrXlZ0zf2TSUtVB8SIn DrxyE+yA+1re6WVS+jnkHPZeznrSE4r944d+tBQ9AmLkAoydIQ4kcfv0eDLFPvPHymrY wUBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=c1i73OsjWxy8syDrG04LtBK4SNZO4XSVvDJ9zpZ/ucM=; b=Ik0osjG+64c6wL326qm4JXf0qznr2xhwTdIdJwpi/ieYzPPmSUHKvALH/cM9fVdNsX OXqNwQQREyvNCo4+w1VhDBbh5nSG5h88hoNRvVtk0YlLg82y00XnHWZVzZyYCioH2tdR X6eUN0PzaWF8JZCCXAIkYFMto6YDpK5Jdme7KmsKAeW9a0aGM4CIhMW9ZpQefWpeurFB lTDLFB+BgzSlN94gL0NC6GoDUFWUCqWbhupbjnnsMIIWO1r1udrIzRsdU1rgAzZhT1zo RKQg5z0+t7rRJcZRCMvme8jScmPGcNxgGcHL8Xu4+nck+VpgnxoKF0zfwB61aBpLIPeA A7fQ== X-Gm-Message-State: ALoCoQlBupRSqkcO5XGxK4n77+OXJ5njHd3yTfq70+YiX6wmRKa/r6WQwbCrgefdo49vIZHehLRb X-Received: by 10.194.85.75 with SMTP id f11mr34714116wjz.9.1446052475247; Wed, 28 Oct 2015 10:14:35 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id h198sm5035183wmd.9.2015.10.28.10.14.34 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 28 Oct 2015 10:14:34 -0700 (PDT) From: Thomas Monjalon To: "Van Haaren, Harry" Date: Wed, 28 Oct 2015 18:13:23 +0100 Message-ID: <2215673.djjjMEhqQv@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: References: <1446048480-9139-1-git-send-email-harry.van.haaren@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2] e1000: mark rxq with RTE_SET_USED X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Oct 2015 17:14:35 -0000 2015-10-28 16:18, De Lara Guarch, Pablo: > > This patch marks rxq with RTE_SET_USED in > > rx_desc_hlen_type_rss_to_pkt_flags(), when > > ieee1588 is disabled. Previously a compilation > > error occurred on unused-parameter. > > > > Fixes: 1ce6591e238a ("igb: fix ieee1588 frame identification in i210") > > > > Signed-off-by: Harry van Haaren > > Acked-by: Pablo de Lara Applied, thanks To avoid such break, we must check carefully the compilation with different combinations of options. Hope the automated tests will help us more in the near future.