From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <thomas.monjalon@6wind.com> Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54]) by dpdk.org (Postfix) with ESMTP id A181295AC for <dev@dpdk.org>; Mon, 7 Dec 2015 12:44:34 +0100 (CET) Received: by wmww144 with SMTP id w144so146442960wmw.0 for <dev@dpdk.org>; Mon, 07 Dec 2015 03:44:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=01kfEDmwKflJC3jytjXe1VPf1e22qj4OInTOxmym6Dc=; b=G2jubqYjImxjUj/UmyZR3eX0A7+3IhB/eRmf9wYg3WRzTlG16Vqbjdym4GJ0Y6AcMb q+zb0klg74LyMKvBCY3qLjNGhg079W9PhNA//MIVKkLLL//qFi5YLVwjvOY9+moNIV6T LXnj0yiqb9vhpm2/ffWy6ZlEol1PjXcyiaAVa+edyOpg3nJEVNkpGSfeemMMG2Miz+Xb q99/2DD4H/gJDkUmKi070jENUj436ZDAWFxKx9qfFb+91N6bBnuSPGERRRa3svV50zsK lEbiGa1DiiZRc0DcvabuQBn41afETbcL5g3txv7FGg1tc1x+xmc9GTV+pt1duEcnljSn BEtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=01kfEDmwKflJC3jytjXe1VPf1e22qj4OInTOxmym6Dc=; b=llt9B5b/6MIK6RjjWxyfwmuKjUdBdli3vIOWMOgmwhrvkCdFsMUfiu1IkGecXM6ESZ 2leLhcCLLDqWaj7NL2fowSRKqicaVLC+L4VsQZ6BzT9mWOOfVUxHtPkKU5vNIliZnEfP jkZp/TS4RrNnMtYI5KxjH7n0C+4cwLW5Ze8EMJLFICWz4SWuzbEJ9xV8gM7Y7UZO2xxl M0rd8FsO1kJNb3Ld/8zHdXulFmTSF4WRrgWcCjvoHim/0aP+BS9U/eIXsSMCKyn53iay z1iw/uqJwgxTxPKnuW7c3Vw4sUiGkSu/atXK82gN1pOz+nGVr57mwI8VQvzZn1hU95jr skqw== X-Gm-Message-State: ALoCoQnsoHKMgJCM4NKiPaqFlbQTYecObTplO287VQlMe2D/GzBjKrB9IO04pdl0TMKr1xGtAOBw X-Received: by 10.194.205.137 with SMTP id lg9mr31394051wjc.156.1449488674530; Mon, 07 Dec 2015 03:44:34 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id a63sm16222558wmc.5.2015.12.07.03.44.33 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 07 Dec 2015 03:44:34 -0800 (PST) From: Thomas Monjalon <thomas.monjalon@6wind.com> To: "Liu, Jijiang" <jijiang.liu@intel.com> Date: Mon, 07 Dec 2015 12:43:21 +0100 Message-ID: <2216574.eY6M99sh3G@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1ED644BD7E0A5F4091CF203DAFB8E4CC22BE51F5@SHSMSX101.ccr.corp.intel.com> References: <1449457307-15206-1-git-send-email-jijiang.liu@intel.com> <3679869.2UDrnTTX50@xps13> <1ED644BD7E0A5F4091CF203DAFB8E4CC22BE51F5@SHSMSX101.ccr.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] doc: announce ABI change for struct rte_eth_conf X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Mon, 07 Dec 2015 11:44:34 -0000 2015-12-07 07:47, Liu, Jijiang: > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > 2015-12-07 03:30, Liu, Jijiang: > > > Hi Thomas, > > > > > > > -----Original Message----- > > > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > > > Sent: Monday, December 07, 2015 11:17 AM > > > > To: Liu, Jijiang > > > > Cc: dev@dpdk.org > > > > Subject: Re: [dpdk-dev] [PATCH] doc: announce ABI change for struct > > > > rte_eth_conf > > > > > > > > 2015-12-07 11:01, Jijiang Liu: > > > > > +* ABI changes are planned for struct rte_eth_conf in order to > > > > > +support > > > > > + tunneling packet configuration in unified tunneling API. The > > > > > +release 2.2 > > > > does not contain these ABI > > > > > + changes, but release 2.3 will, and no backwards compatibility is > > planned. > > > > > > > > Please, more details would be appreciated. > > > > We need to decide whether an ABI deprecation is the right choice. > > > > > > * ABI changes are planned for struct rte_eth_conf in order to support > > > tunneling packet configuration in unified tunneling APIs, which is the > > rte_eth_dev_tunnel_configure > > > (uint8_t port_id, uint16_t rx_q, uint16_t tx_q, rte_eth_tunnel_conf * > > tunnel_conf) API is planned to add. > > > and the 'tunnel_conf' shloud be stored in global 'rte_eth_conf'. > > > The release 2.2 does not contain these ABI change, but release 2.3 will, > > and no backwards compatibility is planned. > > > > > > Is it enough clear? > > > > No, I think we need an explanation in the commit message of what is the > > purpose of rte_eth_dev_tunnel_configure() and tunnel_conf. > Ok, will do. > > Ideally, an RFC patch would help. > I'm working on RFC patch, but it probably will miss merge timeslot of this release. A RFC patch may be incomplete. The API changes are enough.