* [dpdk-dev] [PATCH] doc: announce ABI change for struct rte_eth_conf @ 2015-12-07 3:01 Jijiang Liu 2015-12-07 3:16 ` Thomas Monjalon 2015-12-07 10:42 ` Chilikin, Andrey 0 siblings, 2 replies; 7+ messages in thread From: Jijiang Liu @ 2015-12-07 3:01 UTC (permalink / raw) To: dev Announce ABI change for struct rte_eth_conf. Signed-off-by: Jijiang Liu <jijiang.liu@intel.com> --- doc/guides/rel_notes/deprecation.rst | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index 1c7ab01..f50f0c7 100644 --- a/doc/guides/rel_notes/deprecation.rst +++ b/doc/guides/rel_notes/deprecation.rst @@ -19,3 +19,7 @@ Deprecation Notices and table action handlers will be updated: the pipeline parameter will be added, the packets mask parameter will be either removed (for input port action handler) or made input-only. + +* ABI changes are planned for struct rte_eth_conf in order to support + tunneling packet configuration in unified tunneling API. The release 2.2 does not contain these ABI + changes, but release 2.3 will, and no backwards compatibility is planned. -- 1.7.7.6 ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: announce ABI change for struct rte_eth_conf 2015-12-07 3:01 [dpdk-dev] [PATCH] doc: announce ABI change for struct rte_eth_conf Jijiang Liu @ 2015-12-07 3:16 ` Thomas Monjalon 2015-12-07 3:30 ` Liu, Jijiang 2015-12-07 10:42 ` Chilikin, Andrey 1 sibling, 1 reply; 7+ messages in thread From: Thomas Monjalon @ 2015-12-07 3:16 UTC (permalink / raw) To: Jijiang Liu; +Cc: dev 2015-12-07 11:01, Jijiang Liu: > +* ABI changes are planned for struct rte_eth_conf in order to support > + tunneling packet configuration in unified tunneling API. The release 2.2 does not contain these ABI > + changes, but release 2.3 will, and no backwards compatibility is planned. Please, more details would be appreciated. We need to decide whether an ABI deprecation is the right choice. ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: announce ABI change for struct rte_eth_conf 2015-12-07 3:16 ` Thomas Monjalon @ 2015-12-07 3:30 ` Liu, Jijiang 2015-12-07 3:40 ` Thomas Monjalon 0 siblings, 1 reply; 7+ messages in thread From: Liu, Jijiang @ 2015-12-07 3:30 UTC (permalink / raw) To: Thomas Monjalon; +Cc: dev Hi Thomas, > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Monday, December 07, 2015 11:17 AM > To: Liu, Jijiang > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] doc: announce ABI change for struct > rte_eth_conf > > 2015-12-07 11:01, Jijiang Liu: > > +* ABI changes are planned for struct rte_eth_conf in order to support > > + tunneling packet configuration in unified tunneling API. The release 2.2 > does not contain these ABI > > + changes, but release 2.3 will, and no backwards compatibility is planned. > > Please, more details would be appreciated. > We need to decide whether an ABI deprecation is the right choice. * ABI changes are planned for struct rte_eth_conf in order to support tunneling packet configuration in unified tunneling APIs, which is the rte_eth_dev_tunnel_configure (uint8_t port_id, uint16_t rx_q, uint16_t tx_q, rte_eth_tunnel_conf * tunnel_conf) API is planned to add. and the 'tunnel_conf' shloud be stored in global 'rte_eth_conf'. The release 2.2 does not contain these ABI change, but release 2.3 will, and no backwards compatibility is planned. Is it enough clear? ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: announce ABI change for struct rte_eth_conf 2015-12-07 3:30 ` Liu, Jijiang @ 2015-12-07 3:40 ` Thomas Monjalon 2015-12-07 7:47 ` Liu, Jijiang 0 siblings, 1 reply; 7+ messages in thread From: Thomas Monjalon @ 2015-12-07 3:40 UTC (permalink / raw) To: Liu, Jijiang; +Cc: dev 2015-12-07 03:30, Liu, Jijiang: > Hi Thomas, > > > -----Original Message----- > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > Sent: Monday, December 07, 2015 11:17 AM > > To: Liu, Jijiang > > Cc: dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH] doc: announce ABI change for struct > > rte_eth_conf > > > > 2015-12-07 11:01, Jijiang Liu: > > > +* ABI changes are planned for struct rte_eth_conf in order to support > > > + tunneling packet configuration in unified tunneling API. The release 2.2 > > does not contain these ABI > > > + changes, but release 2.3 will, and no backwards compatibility is planned. > > > > Please, more details would be appreciated. > > We need to decide whether an ABI deprecation is the right choice. > > * ABI changes are planned for struct rte_eth_conf in order to support > tunneling packet configuration in unified tunneling APIs, which is the rte_eth_dev_tunnel_configure > (uint8_t port_id, uint16_t rx_q, uint16_t tx_q, rte_eth_tunnel_conf * tunnel_conf) API is planned to add. > and the 'tunnel_conf' shloud be stored in global 'rte_eth_conf'. > The release 2.2 does not contain these ABI change, but release 2.3 will, and no backwards compatibility is planned. > > Is it enough clear? No, I think we need an explanation in the commit message of what is the purpose of rte_eth_dev_tunnel_configure() and tunnel_conf. Ideally, an RFC patch would help. ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: announce ABI change for struct rte_eth_conf 2015-12-07 3:40 ` Thomas Monjalon @ 2015-12-07 7:47 ` Liu, Jijiang 2015-12-07 11:43 ` Thomas Monjalon 0 siblings, 1 reply; 7+ messages in thread From: Liu, Jijiang @ 2015-12-07 7:47 UTC (permalink / raw) To: Thomas Monjalon; +Cc: dev > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Monday, December 07, 2015 11:40 AM > To: Liu, Jijiang > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] doc: announce ABI change for struct > rte_eth_conf > > 2015-12-07 03:30, Liu, Jijiang: > > Hi Thomas, > > > > > -----Original Message----- > > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > > Sent: Monday, December 07, 2015 11:17 AM > > > To: Liu, Jijiang > > > Cc: dev@dpdk.org > > > Subject: Re: [dpdk-dev] [PATCH] doc: announce ABI change for struct > > > rte_eth_conf > > > > > > 2015-12-07 11:01, Jijiang Liu: > > > > +* ABI changes are planned for struct rte_eth_conf in order to > > > > +support > > > > + tunneling packet configuration in unified tunneling API. The > > > > +release 2.2 > > > does not contain these ABI > > > > + changes, but release 2.3 will, and no backwards compatibility is > planned. > > > > > > Please, more details would be appreciated. > > > We need to decide whether an ABI deprecation is the right choice. > > > > * ABI changes are planned for struct rte_eth_conf in order to support > > tunneling packet configuration in unified tunneling APIs, which is the > rte_eth_dev_tunnel_configure > > (uint8_t port_id, uint16_t rx_q, uint16_t tx_q, rte_eth_tunnel_conf * > tunnel_conf) API is planned to add. > > and the 'tunnel_conf' shloud be stored in global 'rte_eth_conf'. > > The release 2.2 does not contain these ABI change, but release 2.3 will, > and no backwards compatibility is planned. > > > > Is it enough clear? > > No, I think we need an explanation in the commit message of what is the > purpose of rte_eth_dev_tunnel_configure() and tunnel_conf. Ok, will do. > Ideally, an RFC patch would help. I'm working on RFC patch, but it probably will miss merge timeslot of this release. ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: announce ABI change for struct rte_eth_conf 2015-12-07 7:47 ` Liu, Jijiang @ 2015-12-07 11:43 ` Thomas Monjalon 0 siblings, 0 replies; 7+ messages in thread From: Thomas Monjalon @ 2015-12-07 11:43 UTC (permalink / raw) To: Liu, Jijiang; +Cc: dev 2015-12-07 07:47, Liu, Jijiang: > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > 2015-12-07 03:30, Liu, Jijiang: > > > Hi Thomas, > > > > > > > -----Original Message----- > > > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > > > Sent: Monday, December 07, 2015 11:17 AM > > > > To: Liu, Jijiang > > > > Cc: dev@dpdk.org > > > > Subject: Re: [dpdk-dev] [PATCH] doc: announce ABI change for struct > > > > rte_eth_conf > > > > > > > > 2015-12-07 11:01, Jijiang Liu: > > > > > +* ABI changes are planned for struct rte_eth_conf in order to > > > > > +support > > > > > + tunneling packet configuration in unified tunneling API. The > > > > > +release 2.2 > > > > does not contain these ABI > > > > > + changes, but release 2.3 will, and no backwards compatibility is > > planned. > > > > > > > > Please, more details would be appreciated. > > > > We need to decide whether an ABI deprecation is the right choice. > > > > > > * ABI changes are planned for struct rte_eth_conf in order to support > > > tunneling packet configuration in unified tunneling APIs, which is the > > rte_eth_dev_tunnel_configure > > > (uint8_t port_id, uint16_t rx_q, uint16_t tx_q, rte_eth_tunnel_conf * > > tunnel_conf) API is planned to add. > > > and the 'tunnel_conf' shloud be stored in global 'rte_eth_conf'. > > > The release 2.2 does not contain these ABI change, but release 2.3 will, > > and no backwards compatibility is planned. > > > > > > Is it enough clear? > > > > No, I think we need an explanation in the commit message of what is the > > purpose of rte_eth_dev_tunnel_configure() and tunnel_conf. > Ok, will do. > > Ideally, an RFC patch would help. > I'm working on RFC patch, but it probably will miss merge timeslot of this release. A RFC patch may be incomplete. The API changes are enough. ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: announce ABI change for struct rte_eth_conf 2015-12-07 3:01 [dpdk-dev] [PATCH] doc: announce ABI change for struct rte_eth_conf Jijiang Liu 2015-12-07 3:16 ` Thomas Monjalon @ 2015-12-07 10:42 ` Chilikin, Andrey 1 sibling, 0 replies; 7+ messages in thread From: Chilikin, Andrey @ 2015-12-07 10:42 UTC (permalink / raw) To: Liu, Jijiang, dev > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jijiang Liu > Sent: Monday, December 7, 2015 3:02 AM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH] doc: announce ABI change for struct rte_eth_conf > > Announce ABI change for struct rte_eth_conf. > > Signed-off-by: Jijiang Liu <jijiang.liu@intel.com> Acked-by: Andrey Chilikin <andrey.chilikin@intel.com> ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2015-12-07 11:44 UTC | newest] Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2015-12-07 3:01 [dpdk-dev] [PATCH] doc: announce ABI change for struct rte_eth_conf Jijiang Liu 2015-12-07 3:16 ` Thomas Monjalon 2015-12-07 3:30 ` Liu, Jijiang 2015-12-07 3:40 ` Thomas Monjalon 2015-12-07 7:47 ` Liu, Jijiang 2015-12-07 11:43 ` Thomas Monjalon 2015-12-07 10:42 ` Chilikin, Andrey
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).