From: Thomas Monjalon <thomas@monjalon.net>
To: Yuanhan Liu <yliu@fridaylinux.org>
Cc: Olivier MATZ <olivier.matz@6wind.com>,
maxime.coquelin@redhat.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [git pull] virtio changes for 17.11-rc1
Date: Sun, 08 Oct 2017 22:16:29 +0200 [thread overview]
Message-ID: <2218306.fYRWOIo4Bx@xps> (raw)
In-Reply-To: <20171008201006.7gqmyeofcw3m4ech@neon>
08/10/2017 22:10, Olivier MATZ:
> Hi Thomas,
>
> On Sat, Oct 07, 2017 at 04:37:53PM +0200, Thomas Monjalon wrote:
> > 06/10/2017 08:45, Yuanhan Liu:
> > > Hi Thomas,
> > >
> > > Please consider pulling following virtio changes for 17.11-rc1 at
> > > git://dpdk.org/next/dpdk-next-virtio master
> >
> > There is a compilation error on ARM with
> > "net/virtio: rationalize setting of Rx/Tx handlers"
> > An include of rte_cpuflags.h is missing.
>
> I confirm that this include is missing in virtio_ethdev.c, breaking
> compilation on arm (thanks for spotting it):
>
> virtio_ethdev.c: In function 'virtio_dev_configure':
> virtio_ethdev.c:1748:7: error: implicit declaration of function
> 'rte_cpu_get_flag_enabled' [-Werror=implicit-function-declaration]
> if (!rte_cpu_get_flag_enabled(RTE_CPUFLAG_NEON)) {
> ^
>
> Thomas, about this issue, what do you expect? I can send another patch
> if required.
It can be fixed by Yuanhan in next-virtio tree.
next prev parent reply other threads:[~2017-10-08 20:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-06 6:45 Yuanhan Liu
2017-10-06 9:47 ` Thomas Monjalon
2017-10-06 10:50 ` Bruce Richardson
2017-10-06 12:04 ` Thomas Monjalon
2017-10-06 11:05 ` Yuanhan Liu
2017-10-07 14:37 ` Thomas Monjalon
2017-10-07 14:57 ` Thomas Monjalon
2017-10-09 8:20 ` Maxime Coquelin
2017-10-08 20:10 ` Olivier MATZ
2017-10-08 20:16 ` Thomas Monjalon [this message]
2017-10-09 2:43 ` Yuanhan Liu
2017-10-09 7:13 ` Maxime Coquelin
2017-10-09 2:55 ` Yuanhan Liu
2017-10-09 7:13 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2218306.fYRWOIo4Bx@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=olivier.matz@6wind.com \
--cc=yliu@fridaylinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).