From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 7088B37A2 for ; Sun, 8 Oct 2017 22:16:32 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 0BFAB20A28; Sun, 8 Oct 2017 16:16:32 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Sun, 08 Oct 2017 16:16:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=/9tFlnosSSXpaJn niNosYcn+CBLaKoX8m9BXZ+E6TK8=; b=lOZVj1MpDWRuXIK6yscEzvgMkLWvlR2 Mq4sVAQhV3LAokGJOBtDtPjPytWinntZtz8VQ0ZFI3SAyDD0dolWv80hRaun547w PtgvT/O2uZl5eMQZohlTU/u84UDWNXU4DsclUqbmSWflm/qAYdx8H/UR4xan8ucV dwItkVe/o0TM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=/9tFlnosSSXpaJnniNosYcn+CBLaKoX8m9BXZ+E6TK8=; b=TMW9GLJz btrbaWVJ5tntd35wSCd9HaCywQZynRcoT1ryu6zXKpHQxOqNNMVXNKPUFnM3EYtN n0E/itjaZyiFw5jHXW0un01AK8Nk9JP8zjaDMmvRUOUn/eStyip2Ch8eQ565cKFE CUrGKNzeyOyJXBdAgCyvQoOXa86LGRJ3Or4hCVDnCW30t35h3/NxYppUBkswz2l1 O20TVAAN8b9MIT3tBXHytctd01WNc5yGJV5Qyr7p+ubKFtqQUATGNDsxhfqKUVj2 VVqXImyQ0y6jUk0HyW/zB9kugm0pULu65aI/ZwD+XZnBqZ0WBKpJebQoWH48uvi2 eRZ7lsWqAFAo5g== X-ME-Sender: X-Sasl-enc: uK/5hOEvcWzZoid/aL8A2WnLjxuErWMZXCj0HlxiTf5Z 1507493791 Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id A16C87E3E1; Sun, 8 Oct 2017 16:16:31 -0400 (EDT) From: Thomas Monjalon To: Yuanhan Liu Cc: Olivier MATZ , maxime.coquelin@redhat.com, dev@dpdk.org Date: Sun, 08 Oct 2017 22:16:29 +0200 Message-ID: <2218306.fYRWOIo4Bx@xps> In-Reply-To: <20171008201006.7gqmyeofcw3m4ech@neon> References: <20171006064558.GE1545@yliu-home> <1963011.gX7c8kfyiN@xps> <20171008201006.7gqmyeofcw3m4ech@neon> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [git pull] virtio changes for 17.11-rc1 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Oct 2017 20:16:32 -0000 08/10/2017 22:10, Olivier MATZ: > Hi Thomas, > > On Sat, Oct 07, 2017 at 04:37:53PM +0200, Thomas Monjalon wrote: > > 06/10/2017 08:45, Yuanhan Liu: > > > Hi Thomas, > > > > > > Please consider pulling following virtio changes for 17.11-rc1 at > > > git://dpdk.org/next/dpdk-next-virtio master > > > > There is a compilation error on ARM with > > "net/virtio: rationalize setting of Rx/Tx handlers" > > An include of rte_cpuflags.h is missing. > > I confirm that this include is missing in virtio_ethdev.c, breaking > compilation on arm (thanks for spotting it): > > virtio_ethdev.c: In function 'virtio_dev_configure': > virtio_ethdev.c:1748:7: error: implicit declaration of function > 'rte_cpu_get_flag_enabled' [-Werror=implicit-function-declaration] > if (!rte_cpu_get_flag_enabled(RTE_CPUFLAG_NEON)) { > ^ > > Thomas, about this issue, what do you expect? I can send another patch > if required. It can be fixed by Yuanhan in next-virtio tree.