* [dpdk-dev] [PATCH] net/ena: fix icc compile error
@ 2016-07-19 9:33 Ferruh Yigit
2016-07-19 10:48 ` Ferruh Yigit
0 siblings, 1 reply; 4+ messages in thread
From: Ferruh Yigit @ 2016-07-19 9:33 UTC (permalink / raw)
To: dev; +Cc: Jan Medala, Jakub Palider, Netanel Belgazal, Evgeny Schemeilin
compile error:
CC ena_com.o
.../drivers/net/ena/base/ena_com.c(346):
error #3656: variable "dev_node" may be used before its value is set
ENA_MEM_ALLOC_COHERENT_NODE(ena_dev->dmadev,
^
.../drivers/net/ena/base/ena_com.c(399):
error #3656: variable "prev_node" may be used before its value is set
ENA_MEM_ALLOC_COHERENT_NODE(ena_dev->dmadev,
^
Fixes: 3d3edc265fc8 ("net/ena: make coherent memory allocation NUMA-aware")
Reported-by: Eoin Breen <eoin.breen@intel.com>
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
drivers/net/ena/base/ena_com.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ena/base/ena_com.c b/drivers/net/ena/base/ena_com.c
index a3649d8..88053e3 100644
--- a/drivers/net/ena/base/ena_com.c
+++ b/drivers/net/ena/base/ena_com.c
@@ -329,7 +329,7 @@ static int ena_com_init_io_sq(struct ena_com_dev *ena_dev,
struct ena_com_io_sq *io_sq)
{
size_t size;
- int dev_node;
+ int dev_node = 0;
ENA_TOUCH(ctx);
@@ -383,7 +383,7 @@ static int ena_com_init_io_cq(struct ena_com_dev *ena_dev,
struct ena_com_io_cq *io_cq)
{
size_t size;
- int prev_node;
+ int prev_node = 0;
ENA_TOUCH(ctx);
memset(&io_cq->cdesc_addr, 0x0, sizeof(struct ena_com_io_desc_addr));
--
2.7.4
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] net/ena: fix icc compile error
2016-07-19 9:33 [dpdk-dev] [PATCH] net/ena: fix icc compile error Ferruh Yigit
@ 2016-07-19 10:48 ` Ferruh Yigit
2016-07-19 11:34 ` Jan Mędala
0 siblings, 1 reply; 4+ messages in thread
From: Ferruh Yigit @ 2016-07-19 10:48 UTC (permalink / raw)
To: dev; +Cc: Jan Medala, Jakub Palider, Netanel Belgazal, Evgeny Schemeilin
On 7/19/2016 10:33 AM, Ferruh Yigit wrote:
> compile error:
> CC ena_com.o
> .../drivers/net/ena/base/ena_com.c(346):
> error #3656: variable "dev_node" may be used before its value is set
> ENA_MEM_ALLOC_COHERENT_NODE(ena_dev->dmadev,
> ^
>
> .../drivers/net/ena/base/ena_com.c(399):
> error #3656: variable "prev_node" may be used before its value is set
> ENA_MEM_ALLOC_COHERENT_NODE(ena_dev->dmadev,
> ^
>
> Fixes: 3d3edc265fc8 ("net/ena: make coherent memory allocation NUMA-aware")
>
> Reported-by: Eoin Breen <eoin.breen@intel.com>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
Self-Nack
I wasn't aware Jan is already working on this and has a patch. We can
drop this one.
Thanks,
ferruh
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] net/ena: fix icc compile error
2016-07-19 10:48 ` Ferruh Yigit
@ 2016-07-19 11:34 ` Jan Mędala
2016-07-21 22:39 ` Thomas Monjalon
0 siblings, 1 reply; 4+ messages in thread
From: Jan Mędala @ 2016-07-19 11:34 UTC (permalink / raw)
To: Ferruh Yigit; +Cc: dev, Jakub Palider, Netanel Belgazal, Evgeny Schemeilin
Ferruh,
Actually we can stay with this patch. It's ok.
Acked-by: Jan Medala <jan@semihalf.com>
Jan
2016-07-19 12:48 GMT+02:00 Ferruh Yigit <ferruh.yigit@intel.com>:
> On 7/19/2016 10:33 AM, Ferruh Yigit wrote:
> > compile error:
> > CC ena_com.o
> > .../drivers/net/ena/base/ena_com.c(346):
> > error #3656: variable "dev_node" may be used before its value is set
> > ENA_MEM_ALLOC_COHERENT_NODE(ena_dev->dmadev,
> > ^
> >
> > .../drivers/net/ena/base/ena_com.c(399):
> > error #3656: variable "prev_node" may be used before its value is set
> > ENA_MEM_ALLOC_COHERENT_NODE(ena_dev->dmadev,
> > ^
> >
> > Fixes: 3d3edc265fc8 ("net/ena: make coherent memory allocation
> NUMA-aware")
> >
> > Reported-by: Eoin Breen <eoin.breen@intel.com>
> > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
> Self-Nack
> I wasn't aware Jan is already working on this and has a patch. We can
> drop this one.
>
> Thanks,
> ferruh
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] net/ena: fix icc compile error
2016-07-19 11:34 ` Jan Mędala
@ 2016-07-21 22:39 ` Thomas Monjalon
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2016-07-21 22:39 UTC (permalink / raw)
To: Ferruh Yigit
Cc: dev, Jan Mędala, Jakub Palider, Netanel Belgazal, Evgeny Schemeilin
> > > compile error:
> > > CC ena_com.o
> > > .../drivers/net/ena/base/ena_com.c(346):
> > > error #3656: variable "dev_node" may be used before its value is set
> > > ENA_MEM_ALLOC_COHERENT_NODE(ena_dev->dmadev,
> > > ^
> > >
> > > .../drivers/net/ena/base/ena_com.c(399):
> > > error #3656: variable "prev_node" may be used before its value is set
> > > ENA_MEM_ALLOC_COHERENT_NODE(ena_dev->dmadev,
> > > ^
> > >
> > > Fixes: 3d3edc265fc8 ("net/ena: make coherent memory allocation
> > NUMA-aware")
> > >
> > > Reported-by: Eoin Breen <eoin.breen@intel.com>
> > > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> >
> > Self-Nack
> > I wasn't aware Jan is already working on this and has a patch. We can
> > drop this one.
>
> Actually we can stay with this patch. It's ok.
>
> Acked-by: Jan Medala <jan@semihalf.com>
Applied, thanks
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-07-21 22:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-19 9:33 [dpdk-dev] [PATCH] net/ena: fix icc compile error Ferruh Yigit
2016-07-19 10:48 ` Ferruh Yigit
2016-07-19 11:34 ` Jan Mędala
2016-07-21 22:39 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).