From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wm0-f50.google.com (mail-wm0-f50.google.com [74.125.82.50])
by dpdk.org (Postfix) with ESMTP id A40AB5A5C
for <dev@dpdk.org>; Fri, 22 Jul 2016 00:39:30 +0200 (CEST)
Received: by mail-wm0-f50.google.com with SMTP id o80so42748532wme.1
for <dev@dpdk.org>; Thu, 21 Jul 2016 15:39:30 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=6wind-com.20150623.gappssmtp.com; s=20150623;
h=from:to:cc:subject:date:message-id:user-agent:in-reply-to
:references:mime-version:content-transfer-encoding;
bh=ve3NgHNmYqb8+JHN4bnmOn5e/MF4mU1JI4sIutpsNvg=;
b=nqzSpxKwPxi+LnzpXK58z22/RhzVslR7f7knvn5odQRMgnbZ3kgn701ehFkILCHFmr
/TQBZzOVPQ7ExrpHG9YFC3bFMiH5UacsitnhD5uMA7GFQ3Xf7opQE7gbt0XTOrfnKoqy
/QuLtBGWSpQzF7cCQ+tViNUnWOgcWvaRAWXmu1oFYsDGbyQzI1SCF96mwOJ3ppcb+23q
48lKoXyNYI5Vt0SuGBVoE8YjCm+3p30IkN2lBLpuzCYiDzX/jvuycQM41ak4XVTGl2dS
cxjr1tSy+0PW3juz/LHkU4PbgNAHQ6QqvDp4knka7PyZEDqwj9nm/uk7nQWEDa1V3f3n
9TTQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20130820;
h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent
:in-reply-to:references:mime-version:content-transfer-encoding;
bh=ve3NgHNmYqb8+JHN4bnmOn5e/MF4mU1JI4sIutpsNvg=;
b=CiG7kANokPAOLwKTDmcqpIffHK59iQmnBcBPjDOihLeZ/5iPsXMbMlnPKzEnpV7Ep0
22C9RljRRVqDzBjMkP2noosOXmY8s7poN68wR/UMx69f39Na3NOS4+Yoy/+xmKwIgLfR
ozMFGFSRt2GbytvLY/Xt7X88p0t+Z/uy51STvqobRY2RC86TlDSJqXI2U4UjPLkWpBIO
vEGDK7MKLsHk51hNMffh3MJfHujhDm33UIbuvrhpn5AFKBsNGZJWELWQ5+urSguCXRj2
UTDUtAM42H303LICTY+OMavd7U4sD0AG6uHbRWSn4czW9fCnLhJKAT2JW5c5NO3NJsYM
SvpA==
X-Gm-Message-State: AEkoouuz5s2Ymv8wpXRHswiRyikmDY08ZUF4oJTy9uAN16/PKRTyY4xKio20vXQ+t2mCLnpx
X-Received: by 10.28.64.86 with SMTP id n83mr1034963wma.52.1469140770390;
Thu, 21 Jul 2016 15:39:30 -0700 (PDT)
Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184])
by smtp.gmail.com with ESMTPSA id w129sm7813772wmd.9.2016.07.21.15.39.29
(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
Thu, 21 Jul 2016 15:39:29 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org, Jan =?utf-8?B?TcSZZGFsYQ==?= <jan@semihalf.com>,
Jakub Palider <jpa@semihalf.com>, Netanel Belgazal <netanel@amazon.com>,
Evgeny Schemeilin <evgenys@amazon.com>
Date: Fri, 22 Jul 2016 00:39:28 +0200
Message-ID: <2221801.baJjd9z2QQ@xps13>
User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; )
In-Reply-To: <CANw_3ZdR77Jfv9xNS4EcR9hDsax67jF5YcOoqZbfqHjd_j73ww@mail.gmail.com>
References: <1468920783-27136-1-git-send-email-ferruh.yigit@intel.com>
<578E056B.6060006@intel.com>
<CANw_3ZdR77Jfv9xNS4EcR9hDsax67jF5YcOoqZbfqHjd_j73ww@mail.gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH] net/ena: fix icc compile error
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 21 Jul 2016 22:39:30 -0000
> > > compile error:
> > > CC ena_com.o
> > > .../drivers/net/ena/base/ena_com.c(346):
> > > error #3656: variable "dev_node" may be used before its value is set
> > > ENA_MEM_ALLOC_COHERENT_NODE(ena_dev->dmadev,
> > > ^
> > >
> > > .../drivers/net/ena/base/ena_com.c(399):
> > > error #3656: variable "prev_node" may be used before its value is set
> > > ENA_MEM_ALLOC_COHERENT_NODE(ena_dev->dmadev,
> > > ^
> > >
> > > Fixes: 3d3edc265fc8 ("net/ena: make coherent memory allocation
> > NUMA-aware")
> > >
> > > Reported-by: Eoin Breen <eoin.breen@intel.com>
> > > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> >
> > Self-Nack
> > I wasn't aware Jan is already working on this and has a patch. We can
> > drop this one.
>
> Actually we can stay with this patch. It's ok.
>
> Acked-by: Jan Medala <jan@semihalf.com>
Applied, thanks