From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f175.google.com (mail-wi0-f175.google.com [209.85.212.175]) by dpdk.org (Postfix) with ESMTP id 368CF8D9F for ; Mon, 2 Nov 2015 17:33:17 +0100 (CET) Received: by wicll6 with SMTP id ll6so53613740wic.1 for ; Mon, 02 Nov 2015 08:33:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind_com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=owXPOVG/80fjpki3n1wTCTTg2w8aMEiXlpQdsGSpS+Y=; b=QYFn4bYyvVH6qiF8F4QtKMSxw7Fe4kBT78cIvJNsvNHdlwjunL9L3zMEtrH2zljp6c A/ve7Q0y+pV1pLIBFJilSVnzZji96Hl82OHBKdbWxtSMZSyesABw4lh3nvnpwLr1CHoc 0maFNqvipVWr4A+npnsU+tWzweE/xqb4rSyNVpTV+KzxLCXDvbF8vNZp65Ebkh48pilJ n9pZYPxKmm2CfwtlCSrboqpdKQTppewv1G7KzeTb+FkLw6FB+98+K/l4VnbxRBEENzdm KIOFjhEtfZwAk8hk4zxZuQTUTIMBaO6vKCEozbICH7B1UWgwmbv7578VCA+v4OcetMdq hBQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=owXPOVG/80fjpki3n1wTCTTg2w8aMEiXlpQdsGSpS+Y=; b=M7I6J06rnGfetNK9S35fmh2OCamttHmEQgTTmC7LU2lkqbKKareakKa0saqdi8O+dc 8ZUl5sN1nTKZiv2AgNCbDK4iMM2i2ZqsFgxAhHRf1BrYKHgZjHCeyUdCQc5pWeNiAjnH 0lvXOUZvKVQ6YT++xBy042qJKxPpDGfMMDVn1+QJAeRyq6SYaa0PwKCa0z19q/4v7r2c KInQNVVutai6pegHNWxaf93GkfxbYFMN7yKwc1j56rb5gqoTHxa5hXL1A0vSFWtmFBgz yhdcX1GxGq4mfnBjii/q3wB08jl50pHRkJEoiRK0pmSgyyIPB6UE3P+8BspK3r9nRHX9 00Vg== X-Gm-Message-State: ALoCoQnePB2ozUKWGdUfgIpm/l/PfHWnm8MCNAtCiEdRQktdk4kqxNtNHQPirGtR7tvDF46PN6i9 X-Received: by 10.194.57.142 with SMTP id i14mr27544176wjq.24.1446481997074; Mon, 02 Nov 2015 08:33:17 -0800 (PST) Received: from xps13.localnet (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by smtp.gmail.com with ESMTPSA id j4sm18955222wmg.18.2015.11.02.08.33.16 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 02 Nov 2015 08:33:16 -0800 (PST) From: Thomas Monjalon To: "Iremonger, Bernard" Date: Mon, 02 Nov 2015 17:32:06 +0100 Message-ID: <22264893.CRHp7yC71q@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <8CEF83825BEC744B83065625E567D7C219F76F86@IRSMSX108.ger.corp.intel.com> References: <1446217733-9887-3-git-send-email-bernard.iremonger@intel.com> <1583512.Ss2AELHNGg@xps13> <8CEF83825BEC744B83065625E567D7C219F76F86@IRSMSX108.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v7 02/28] librte_ether: add fields from rte_pci_driver to rte_eth_dev_data X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Nov 2015 16:33:17 -0000 2015-11-02 10:36, Iremonger, Bernard: > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > 2015-10-30 15:08, Bernard Iremonger: > > > add dev_flags to rte_eth_dev_data, add macros for dev_flags. > > > add kdrv to rte_eth_dev_data. > > > add numa_node to rte_eth_dev_data. > > > add drv_name to rte_eth_dev_data. > > > > A commit message should explain why things are done. > > > > > + uint32_t dev_flags; /**< Flags controlling handling of device. */ > > > > Where are defined this flags? What is the scope? > > These flags are defined in the following file: > > lib/librte_ether/rte_ethdev.h > > These flags are visible to all the vdevs and pdevs. I mean it should be more explicit. Having an enum name will help. Note: I understand your patch. I'm just asking the questions an user will ask when trying to use your new API. Thanks