From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44]) by dpdk.org (Postfix) with ESMTP id 4F006CE7 for ; Fri, 1 Jul 2016 12:39:06 +0200 (CEST) Received: by mail-wm0-f44.google.com with SMTP id v199so21089498wmv.0 for ; Fri, 01 Jul 2016 03:39:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=WFnYnf0QPFZR7axEpwpcx17Tz7KioT8mGUSh7op1BeU=; b=HvVI7CvgnVeMwv7fYQxBUejBDMGqlI0oiEZ1cT/EgIhiTjib5cUG7m7itwQ6KIZ+R0 fkV6vqWwpVHg0TFeVO/owT7fKbOxrnURv15VKnV29+vLf+1fTdIhKoe46sgCzCUEg+GN UZoGWIx59wkCKnBBmj4bLMezLZ0014lxezYAeXEJD/eqweWRfdLafGJ32Sw70nlGFAoN BeukwPGpdGOLcBfk73gdYcT/GaOPnArgt2mDHPsfvZy8ydthkm0JEzUxZntCZk5u0Go3 hXxT5prdipgkhpvZ+vprY0Ut+1F8KguFl+FSZDGCkq4DeM555+q26qxs/yPEu+CjnUvt niuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=WFnYnf0QPFZR7axEpwpcx17Tz7KioT8mGUSh7op1BeU=; b=XxtFJfKvU5313CAPkQTooxgn+XYrVqExNYzukCTE/9c/DVO3CM4NFuC2ybjV2m0DlM xQl9cySOOENVIIAswPkkUmtaQuTLyrxlmjnxW2Vq1078EySgS6L5EGEQDuKjdLhJkkdm 0rjpaX4j0lvmUsTK8GyuX4i81KvrFR7Zkk3SzostXwe6LUtxMhEhkOPSYBg+vWCTyFsL VeUvCGEWANes2DzieBfEbI84bke9zavOIOFdvl7S8+XJYNbhFprbOUJOSEY9mYNGjjZW ktAinB7R3urtyNCrss3miZzkI56V+rz9iGqCexsqEPoDLcgzQygApx9zSubZiyqm4j06 88NA== X-Gm-Message-State: ALyK8tLvydKSLMxXlKDtG63vNevQkSiZ6iRuXri3MWbBO/o0JFrr6koVOmuHiW+GdVUabm4E X-Received: by 10.28.191.90 with SMTP id p87mr18404264wmf.69.1467369546060; Fri, 01 Jul 2016 03:39:06 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id r130sm3039925wmf.20.2016.07.01.03.39.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 01 Jul 2016 03:39:04 -0700 (PDT) From: Thomas Monjalon To: Sergio Gonzalez Monroy Cc: dev@dpdk.org, konstantin.ananyev@intel.com Date: Fri, 01 Jul 2016 12:39:03 +0200 Message-ID: <2227698.XiBfFNT51L@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <0efaddba-b8cc-aef8-9f36-dcd792ccddcd@intel.com> References: <1467285021-103920-1-git-send-email-sergio.gonzalez.monroy@intel.com> <2311852.Z0M9311phZ@xps13> <0efaddba-b8cc-aef8-9f36-dcd792ccddcd@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] mk: fix acl library static linking X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Jul 2016 10:39:08 -0000 2016-07-01 11:27, Sergio Gonzalez Monroy: > On 01/07/2016 11:05, Thomas Monjalon wrote: > > 2016-07-01 09:05, Sergio Gonzalez Monroy: > >> On 30/06/2016 17:22, Thomas Monjalon wrote: > >>> 2016-06-30 17:14, Sergio Gonzalez Monroy: > >>>> On 30/06/2016 17:10, Thomas Monjalon wrote: > >>>>> 2016-06-30 17:01, Sergio Gonzalez Monroy: > >>>>>> --- a/mk/rte.app.mk > >>>>>> +++ b/mk/rte.app.mk > >>>>>> @@ -76,12 +76,13 @@ _LDLIBS-$(CONFIG_RTE_LIBRTE_IP_FRAG) += -lrte_ip_frag > >>>>>> _LDLIBS-$(CONFIG_RTE_LIBRTE_METER) += -lrte_meter > >>>>>> _LDLIBS-$(CONFIG_RTE_LIBRTE_SCHED) += -lrte_sched > >>>>>> _LDLIBS-$(CONFIG_RTE_LIBRTE_LPM) += -lrte_lpm > >>>>>> -_LDLIBS-$(CONFIG_RTE_LIBRTE_ACL) += -lrte_acl > >>>>>> _LDLIBS-$(CONFIG_RTE_LIBRTE_JOBSTATS) += -lrte_jobstats > >>>>>> _LDLIBS-$(CONFIG_RTE_LIBRTE_POWER) += -lrte_power > >>>>>> > >>>>>> _LDLIBS-y += --whole-archive > >>>>>> > >>>>>> +# librte_acl needs --whole-archive because of weak functions > >>>>>> +_LDLIBS-$(CONFIG_RTE_LIBRTE_ACL) += -lrte_acl > >>>>>> _LDLIBS-$(CONFIG_RTE_LIBRTE_TIMER) += -lrte_timer > >>>>>> _LDLIBS-$(CONFIG_RTE_LIBRTE_HASH) += -lrte_hash > >>>>>> _LDLIBS-$(CONFIG_RTE_LIBRTE_VHOST) += -lrte_vhost > >>>>> I was suggesting to keep -lrte_acl at the same place in the group of > >>>>> algorithms libraries, in order to keep an order satisfying this comment: > >>>>> # Order is important: from higher level to lower level > >>>>> > >>>>> But I have not tested if --whole-archive -lrte_acl --no-whole-archive works. > >>>>> > >>>> Sorry, I missed that. > >>>> > >>>> Why is important being before jobstats and power? > >>> It is not. > >>> But I think we need to have some groups. > >>> And ACL is probably at the same layer level as lpm, sched, etc. > >> I guess I just don't see the groups you are mentioning :) > > I define groups as separated by blank line :) > > > >> How are timer, hash and vhost in the same group? > > It is far from perfect and subject to improvements :) > > > >> Wouldn't hash be in the same group as acl and lpm? > > It makes sense to use hash in drivers (example: enic). > > You have not convinced me, but I'm not going to argue more over this. But you have convinced me (I was already convinced) that more cleanups and explanations are needed in this area :) > You would just prefer to do the following, right? > > +_LDLIBS-$(CONFIG_RTE_LIBRTE_ACL) += --whole-archive > _LDLIBS-$(CONFIG_RTE_LIBRTE_ACL) += -lrte_acl > +_LDLIBS-$(CONFIG_RTE_LIBRTE_ACL) += --no-whole-archive Yes for this fix. Later we can improve few things, thanks.