DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: hemant.agrawal@nxp.com, Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org, stable@dpdk.org, stephen@networkplumber.org,
	longli@microsoft.com, Rosen Xu <rosen.xu@intel.com>
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] ethdev: add missing buses in dev iterator
Date: Tue, 04 May 2021 17:50:22 +0200	[thread overview]
Message-ID: <2232862.pp3s5jRlb4@thomas> (raw)
In-Reply-To: <c367ac84-a65b-e5a5-895d-d4e20849f6e5@intel.com>

04/05/2021 14:49, Ferruh Yigit:
> On 4/29/2021 9:01 AM, Hemant Agrawal wrote:
> > 
> > On 4/29/2021 1:26 PM, Thomas Monjalon wrote:
> >> 29/04/2021 07:55, Hemant Agrawal:
> >>> This patch fixes issue with OVS 2.15 not working on
> >>> DPAA/FSLMC based platform due to missing support for
> >>> these busses in dev_iterate.
> >>> This patch adds dpaa_bus and fslmc to dev iterator
> >>> for bus arguments.
> >> I think we should add VMBus as well.
> > They are 2 buses remaining vmbus and ifpga. However I don't know, if they use
> > args as vdev or as pci?
> 
> cc Rosen for the 'ifpga' bus, 'vmbus' maintainer seems already cc'ed.
> 
> This variable ('bus_param_key') is used to construct 'bus_str', and 'bus_str'
> seems used only for the '.dev_iterate' bus operation.
> 
> Since 'ifpga' & 'vmbus' are not implementing the '.dev_iterate', so is it really
> required to add them?

Good point Ferruh.

The only bus implementing dev_iterate are dpaa, fslmc, pci and vdev.
So this patch makes sense.

Acked-by: Thomas Monjalon <thomas@monjalon.net>



  reply	other threads:[~2021-05-04 15:50 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-29  5:55 [dpdk-dev] " Hemant Agrawal
2021-04-29  7:56 ` Thomas Monjalon
2021-04-29  8:01   ` Hemant Agrawal
2021-05-04 12:49     ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2021-05-04 15:50       ` Thomas Monjalon [this message]
2021-05-04 16:34         ` Ferruh Yigit
2021-05-05 14:39         ` Xu, Rosen
2021-04-29 13:53 ` [dpdk-dev] " Morten Brørup
2021-04-29 13:57   ` Hemant Agrawal
2021-04-29 14:01     ` Morten Brørup

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2232862.pp3s5jRlb4@thomas \
    --to=thomas@monjalon.net \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=hemant.agrawal@nxp.com \
    --cc=longli@microsoft.com \
    --cc=rosen.xu@intel.com \
    --cc=stable@dpdk.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).