From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f172.google.com (mail-wi0-f172.google.com [209.85.212.172]) by dpdk.org (Postfix) with ESMTP id D244D5A41 for ; Wed, 8 Apr 2015 18:16:54 +0200 (CEST) Received: by wiaa2 with SMTP id a2so65089626wia.0 for ; Wed, 08 Apr 2015 09:16:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=n+p/RQt0ZD6m3gkwITPzCjaNkCgnqeQjxMv9K+1pwss=; b=c6/QEqAwk1/bRA+VkSB5SCkD6m1szWM6z7zMOMmGhqyy29df6677Ic+wqQj9+vvUXm Rb8oxy+PjloG1xWMYGmz6EJLszcBIkxhY55w3dEWMjOhUnRp5gxPE85hs6b/V3TY/S5x rzBnePJstwSJIvWwEI+59wmKb9R8WtIyLvVb7hrvhdq7gQ2+KWJGZRvo1ow75yXTfspi gZBHjQue0whrveQ8uZYysNhRV8A2tQpFWcMTkp+YECCUr7hppMYoJM/OTVLe7vNI5yd+ Wt6nFdhixEZjnwo2u7T5xDzSGglj97m02I8oDJ5DkP2MIn9L6BvC0IZH3md2MyGHtfpO L5jA== X-Gm-Message-State: ALoCoQk4VBWkBCEbAdgQg0W8vgQOzyo9ouWNBkpTKcs9K+scJODo7NptwJlEj+3f34TPJx1Yr9+Z X-Received: by 10.180.214.99 with SMTP id nz3mr16035222wic.82.1428509814747; Wed, 08 Apr 2015 09:16:54 -0700 (PDT) Received: from xps13.localnet (6wind.net2.nerim.net. [213.41.180.237]) by mx.google.com with ESMTPSA id bx3sm16266191wjc.21.2015.04.08.09.16.53 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 08 Apr 2015 09:16:53 -0700 (PDT) From: Thomas Monjalon To: "Wiles, Keith" , "Butler, Siobhan A" Date: Wed, 08 Apr 2015 18:16:12 +0200 Message-ID: <2232884.6IKBPajdgE@xps13> Organization: 6WIND User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; ) In-Reply-To: References: <3571725.20GtF5MAnU@xps13> <0C5AFCA4B3408848ADF2A3073F7D8CC86D58F9C2@IRSMSX109.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] tools brainstorming X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Apr 2015 16:16:55 -0000 2015-04-08 15:53, Wiles, Keith: > One of the biggest problems with any style is helping the developer > maintain the style. Using some tool does help and I have used astyle > before, not bad code formatter. Here is a few that seem to be reasonable. > > http://astyle.sourceforge.net/ > > http://uncrustify.sourceforge.net/ > > http://sourceforge.net/projects/gcgreatcode/ I'm not sure it's a good idea to convert the codebase automatically. The coding style must be a reference for new patches and they must be automatically checked with a dedicated checkpatch tool. By forbidding patches which don't comply, the codebase will be naturally converted over time. I didn't review this proposal yet. My first comment is that it's too long to read :) When a consensus is done, it must be added with a patch with custom checkpatch addition.