Re: [dpdk-dev] [PATCH v2] net/bnxt: convert to SPDX license tag

[Ferruh Yigit <ferruh.yigit@intel.com>]

On 3/30/2018 7:10 PM, Scott Branden wrote:
> Hi Ferruh,
> 
> 
> On 18-03-30 03:35 AM, Ferruh Yigit wrote:
>> On 3/29/2018 5:40 PM, Ajit Khaparde wrote:
>>> From: Scott Branden <scott.branden@broadcom.com>
>>>
>>> Update the license header on bnxt files to be the standard
>>> BSD-3-Clause license used for the rest of DPDK,
>>> bring the files in compliance with the DPDK licensing policy.
>>>
>>> Signed-off-by: Scott Branden <scott.branden@broadcom.com>
>>> Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
>>> Cc:hemant.agrawal@nxp.com
>>> ----
>>> v1->v2: modify first line of SPDX identifer as per review comment.
>>> ---
>>>   doc/guides/nics/bnxt.rst               | 30 ++----------------------------
>>>   drivers/net/bnxt/bnxt.h                | 32 ++------------------------------
>>>   drivers/net/bnxt/bnxt_cpr.c            | 32 ++------------------------------
>>>   drivers/net/bnxt/bnxt_cpr.h            | 32 ++------------------------------
>>>   drivers/net/bnxt/bnxt_ethdev.c         | 32 ++------------------------------
>>>   drivers/net/bnxt/bnxt_filter.c         | 32 ++------------------------------
>>>   drivers/net/bnxt/bnxt_filter.h         | 32 ++------------------------------
>>>   drivers/net/bnxt/bnxt_hwrm.c           | 32 ++------------------------------
>>>   drivers/net/bnxt/bnxt_hwrm.h           | 32 ++------------------------------
>>>   drivers/net/bnxt/bnxt_irq.c            | 32 ++------------------------------
>>>   drivers/net/bnxt/bnxt_irq.h            | 32 ++------------------------------
>>>   drivers/net/bnxt/bnxt_nvm_defs.h       | 11 +++--------
>>>   drivers/net/bnxt/bnxt_ring.c           | 32 ++------------------------------
>>>   drivers/net/bnxt/bnxt_ring.h           | 32 ++------------------------------
>>>   drivers/net/bnxt/bnxt_rxq.c            | 32 ++------------------------------
>>>   drivers/net/bnxt/bnxt_rxq.h            | 32 ++------------------------------
>>>   drivers/net/bnxt/bnxt_rxr.c            | 32 ++------------------------------
>>>   drivers/net/bnxt/bnxt_rxr.h            | 32 ++------------------------------
>>>   drivers/net/bnxt/bnxt_stats.c          | 32 ++------------------------------
>>>   drivers/net/bnxt/bnxt_stats.h          | 32 ++------------------------------
>>>   drivers/net/bnxt/bnxt_txq.c            | 32 ++------------------------------
>>>   drivers/net/bnxt/bnxt_txq.h            | 32 ++------------------------------
>>>   drivers/net/bnxt/bnxt_txr.c            | 32 ++------------------------------
>>>   drivers/net/bnxt/bnxt_txr.h            | 32 ++------------------------------
>>>   drivers/net/bnxt/bnxt_vnic.c           | 32 ++------------------------------
>>>   drivers/net/bnxt/bnxt_vnic.h           | 32 ++------------------------------
>>>   drivers/net/bnxt/hsi_struct_def_dpdk.h | 32 ++------------------------------
>>>   drivers/net/bnxt/rte_pmd_bnxt.c        | 32 ++------------------------------
>>>   drivers/net/bnxt/rte_pmd_bnxt.h        | 32 ++------------------------------
>>>   29 files changed, 59 insertions(+), 846 deletions(-)
>> Can you please update Makefile too, but I can see it has multiple coypright, it
>> can be better to send it as a separate patch to not block this one.
> Yes, Makefile change should be in another patch.
> I don't know how to change the header on that one though.
> Intel and 6WIND shouldn't really have any copyright on the Makefile, though?
> It looks like somebody just cut and paste the license header from 
> another Makefile.
> Please suggest what should be done with this file.

Most probably it is because of copy-paste as you stated, and I don't know what
does it mean to hold the copyright in the makefile indeed J. cc'ed Hemant and
Olivier.

But removing an existing copyright may mean involving legal and may take time,
unfortunately.

It may be easier to just do the SPDX updates with existing coypright, but if you
have motivation I suggest try to fix this.

>>
>> <...>
>>
>>> @@ -1,34 +1,6 @@
>>> -/*-
>>> - *   BSD LICENSE
>>> - *
>>> - *   Copyright(c) Broadcom Limited.
>>> +/* SPDX-License-Identifier: BSD-3-Clause
>>> + *   Copyright(c) 2014-2018 Broadcom
>>>    *   All rights reserved.
>> It might be nit-picking but we don't have leading spaces [1] in format, are they
>> intentional?
>> If not it is easy to fix when introduced otherwise will stay as it is forever J
> Yes, it was intentional.

Why? What is the practical reason of intentionally diverging from defined syntax?

>>
>> [1]
>>   /* SPDX-License-Identifier: BSD-3-Clause
>>    * Copyright(c) 2014-2018 Broadcom
>>    * All rights reserved.
>>    */
>>
>> <...>
> Thanks,
>   Scott
>