From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 86CF420F for ; Sat, 31 Mar 2018 23:08:51 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Mar 2018 14:08:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,388,1517904000"; d="scan'208";a="216421479" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.252.7.140]) ([10.252.7.140]) by fmsmga006.fm.intel.com with ESMTP; 31 Mar 2018 14:08:43 -0700 To: Scott Branden , Ajit Khaparde , dev@dpdk.org, Hemant Agrawal , Olivier MATZ References: <20180329164021.51728-1-ajit.khaparde@broadcom.com> <7c992ec1-3cef-7a08-2a45-1142798b6af4@intel.com> From: Ferruh Yigit Openpgp: preference=signencrypt Autocrypt: addr=ferruh.yigit@intel.com; keydata= xsFNBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABzSVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+wsF+BBMBAgAoAhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgAUCWZR1xgUJB33UawAKCRD5M+tD3xNhH3TID/wNjq1doFXg49WaM7ZXez/1 qwj7U6FQ2eUhlEPX8dXc52cu+iQk8/mssXQtANEx+jndxfvlkikBNgI+mr3m/ho54uQWFZd7 Bv0DVVkLHNkLWK6tT6iISdCgXrQuOv8y5rucEGkJ8dDPsp8Mqr4sBjavRBpczphoa3miKusA HzUEo0SYuHUPmBlbmvKv4PkA5quWtXpkgV2HZ1bW9X0dQkAqEVioAPm5Q6pXJODfV8kaZUtJ z4swEtBnK9XAWm2HccF7KmFh0vv+Zh9lEMnEFt7UPXngY6+xCTo6xV1IVc8EZfDjOip8I4h2 ALMaLgrZwA9VVmHCVOrnO3UZqfGehrwz4O3sUrcmIzxjk3gfBmVRCBfuWGchSpWtZ99U6V1a OEuG+ymyjBDtyymW+KSvmCBl2gIxZHvZFvSRRdDObkkUIskSJ95f/6HBOESRZBOiV9GEAhC5 gI9OAKKF8HQaN/r5KJrkzscjQcjIdV1jXhTkfQ4wH3GJiVM5JxsKsEjjRw7yfSJo2GBEGqMe KMwMLWg4f1DgVtjOuGf10isu+29MvapW2IxKYaHcVc2vHfWbDi2AvBj/VAzKILWbTEgI1VL5 zKpo5p6X2O55oEyeflDiAzrUfvLqB4vmTyqXtW6PdLyZC7kXIzmNu6EBVx9oSgy3CADw5saN 0La9OoCAc7Tn+s7BTQRX1ky+ARAApzQNvXvE2q1LAS+Z+ni2R13Bb1cDS1ZYq1jgpR13+OKN ipzd8MPngRJilXxBaPTErhgzR0vGcNTYhjGMSyFIHVOoBq1VbP1a0Fi/NqWzJOowo/fDfgVy K4vuitc/gCJs+2se4hdZA4EQJxVlNM51lgYDNpjPGIA43MX15OLAip73+ho6NPBMuc5qse3X pAClNhBKfENRCWN428pi3WVkT+ABRTE0taxjJNP7bb+9TQYNRqGwnGzX5/XISv44asWIQCaq vOkXSUJLd//cdVNTqtL1wreCVVR5pMXj7VIrlk07fmmJVALCmGbFr53BMb8O+8dgK2A5mitM n44d+8KdJWOwziRxcaMk/LclmZS3Iv1TERtiWt98Y9AjeAtcgYPkA3ld0BcUKONogP8pHVz1 Ed3s5rDQ91yr1S0wuAzW91fxGUO4wY+uPmxCtFVuBgd9VT9NAKTUL0qHM7CDgCnZPe0TW6Zj 8OqtdCCyAfvU9cW5xWM7Icxhde6AtPxhDSBwE8fL2ZmrDmaA4jmUKXp3i4JxRPSX84S08b+s DWXHPxy10UFU5A7EK/BEbZAKBwn9ROfm+WK+6X5xOGLoRE++OqNuUudxC1GDyLOPaqCbBCS9 +P6HsTHzxsjyJa27n4jcrcuY3P9TEcFJYSZSeSDh8mVGvugi0exnSJrrBZDyVCcAEQEAAcLB ZQQYAQIADwIbDAUCWZR1ZwUJA59cIQAKCRD5M+tD3xNhH5b+D/9XG44Ci6STdcA5RO/ur05J EE3Ux1DCHZ5V7vNAtX/8Wg4l4GZfweauXwuJ1w7Sp7fklwcNC6wsceI+EmNjGMqfIaukGetG +jBGqsQ7moOZodfXUoCK98gblKgt/BPYMVidzlGC8Q/+lZg1+o29sPnwImW+MXt/Z5az/Z17 Qc265g+p5cqJHzq6bpQdnF7Fu6btKU/kv6wJghENvgMXBuyThqsyFReJWFh2wfaKyuix3Zyj ccq7/blkhzIKmtFWgDcgaSc2UAuJU+x9nuYjihW6WobpKP/nlUDu3BIsbIq09UEke+uE/QK+ FJ8PTJkAsXOf1Bc2C0XbW4Y2hf103+YY6L8weUCBsWC5VH5VtVmeuh26ENURclwfeXhWQ9Og 77yzpTXWr5g1Z0oLpYpWPv745J4bE7pv+dzxOrFdM1xNkzY2pvXph/A8OjxZNQklDkHQ7PIB Lki5L2F4XkEOddUUQchJwzMqTPsggPDmGjgLZrqgO+s4ECZK5+nLD3HEpAbPa3JLDaScy+90 Nu1lAqPUHSnP3vYZVw85ZYm6UCxHE4VLMnnJsN09ZhsOSVR+GyP5Nyw9rT1V3lcsuH7M5Naa 2Xobn9m7l9bRCD/Ji8kG15eV1WTxx1HXVQGjdUYDI7UwegBNbwMLh17XDy+3sn/6SgcqtECA Q6pZKA2mTQxEKA== Message-ID: <22338bee-e88c-13d0-9cd4-333f8e1c59f3@intel.com> Date: Sat, 31 Mar 2018 22:08:42 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2] net/bnxt: convert to SPDX license tag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 31 Mar 2018 21:08:52 -0000 On 3/30/2018 7:10 PM, Scott Branden wrote: > Hi Ferruh, > > > On 18-03-30 03:35 AM, Ferruh Yigit wrote: >> On 3/29/2018 5:40 PM, Ajit Khaparde wrote: >>> From: Scott Branden >>> >>> Update the license header on bnxt files to be the standard >>> BSD-3-Clause license used for the rest of DPDK, >>> bring the files in compliance with the DPDK licensing policy. >>> >>> Signed-off-by: Scott Branden >>> Signed-off-by: Ajit Khaparde >>> Cc:hemant.agrawal@nxp.com >>> ---- >>> v1->v2: modify first line of SPDX identifer as per review comment. >>> --- >>> doc/guides/nics/bnxt.rst | 30 ++---------------------------- >>> drivers/net/bnxt/bnxt.h | 32 ++------------------------------ >>> drivers/net/bnxt/bnxt_cpr.c | 32 ++------------------------------ >>> drivers/net/bnxt/bnxt_cpr.h | 32 ++------------------------------ >>> drivers/net/bnxt/bnxt_ethdev.c | 32 ++------------------------------ >>> drivers/net/bnxt/bnxt_filter.c | 32 ++------------------------------ >>> drivers/net/bnxt/bnxt_filter.h | 32 ++------------------------------ >>> drivers/net/bnxt/bnxt_hwrm.c | 32 ++------------------------------ >>> drivers/net/bnxt/bnxt_hwrm.h | 32 ++------------------------------ >>> drivers/net/bnxt/bnxt_irq.c | 32 ++------------------------------ >>> drivers/net/bnxt/bnxt_irq.h | 32 ++------------------------------ >>> drivers/net/bnxt/bnxt_nvm_defs.h | 11 +++-------- >>> drivers/net/bnxt/bnxt_ring.c | 32 ++------------------------------ >>> drivers/net/bnxt/bnxt_ring.h | 32 ++------------------------------ >>> drivers/net/bnxt/bnxt_rxq.c | 32 ++------------------------------ >>> drivers/net/bnxt/bnxt_rxq.h | 32 ++------------------------------ >>> drivers/net/bnxt/bnxt_rxr.c | 32 ++------------------------------ >>> drivers/net/bnxt/bnxt_rxr.h | 32 ++------------------------------ >>> drivers/net/bnxt/bnxt_stats.c | 32 ++------------------------------ >>> drivers/net/bnxt/bnxt_stats.h | 32 ++------------------------------ >>> drivers/net/bnxt/bnxt_txq.c | 32 ++------------------------------ >>> drivers/net/bnxt/bnxt_txq.h | 32 ++------------------------------ >>> drivers/net/bnxt/bnxt_txr.c | 32 ++------------------------------ >>> drivers/net/bnxt/bnxt_txr.h | 32 ++------------------------------ >>> drivers/net/bnxt/bnxt_vnic.c | 32 ++------------------------------ >>> drivers/net/bnxt/bnxt_vnic.h | 32 ++------------------------------ >>> drivers/net/bnxt/hsi_struct_def_dpdk.h | 32 ++------------------------------ >>> drivers/net/bnxt/rte_pmd_bnxt.c | 32 ++------------------------------ >>> drivers/net/bnxt/rte_pmd_bnxt.h | 32 ++------------------------------ >>> 29 files changed, 59 insertions(+), 846 deletions(-) >> Can you please update Makefile too, but I can see it has multiple coypright, it >> can be better to send it as a separate patch to not block this one. > Yes, Makefile change should be in another patch. > I don't know how to change the header on that one though. > Intel and 6WIND shouldn't really have any copyright on the Makefile, though? > It looks like somebody just cut and paste the license header from > another Makefile. > Please suggest what should be done with this file. Most probably it is because of copy-paste as you stated, and I don't know what does it mean to hold the copyright in the makefile indeed J. cc'ed Hemant and Olivier. But removing an existing copyright may mean involving legal and may take time, unfortunately. It may be easier to just do the SPDX updates with existing coypright, but if you have motivation I suggest try to fix this. >> >> <...> >> >>> @@ -1,34 +1,6 @@ >>> -/*- >>> - * BSD LICENSE >>> - * >>> - * Copyright(c) Broadcom Limited. >>> +/* SPDX-License-Identifier: BSD-3-Clause >>> + * Copyright(c) 2014-2018 Broadcom >>> * All rights reserved. >> It might be nit-picking but we don't have leading spaces [1] in format, are they >> intentional? >> If not it is easy to fix when introduced otherwise will stay as it is forever J > Yes, it was intentional. Why? What is the practical reason of intentionally diverging from defined syntax? >> >> [1] >> /* SPDX-License-Identifier: BSD-3-Clause >> * Copyright(c) 2014-2018 Broadcom >> * All rights reserved. >> */ >> >> <...> > Thanks, >  Scott >