From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f53.google.com (mail-wg0-f53.google.com [74.125.82.53]) by dpdk.org (Postfix) with ESMTP id 4BF207E7C for ; Wed, 10 Dec 2014 10:35:51 +0100 (CET) Received: by mail-wg0-f53.google.com with SMTP id l18so3073939wgh.12 for ; Wed, 10 Dec 2014 01:35:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=J5g5Ru25WappMVHf9OF63+Inr+HC8h1Kbn8kWlwPVDs=; b=lB8o4r3RzKetU53/bRwG+iijXYQzEXi0h/fiRSodJeagZ0GThQhO4PXFChY0GzeOBg OAe74RG7QHTcoaDI3pPpQnvjmnO7PmtZbQZisilwMsDBvcu0fdaycmcbCz/fziRSabBt lyuVTQ9nNhGJYldauvDqndvlcZ2vGS4XlZjnVHkjQAn9S/Rs6dwXlmyFdq/84CF4Pcgu fAlXwjBYasgFKFPnJj5Pcse3Ud0YF03NEMH7u++4QVdzZA8C+2fHb8hjVCroFNFYm7tH 6aJPAsSNwK+MeagiH9boIqDbNNoOxf7ZlQ0UHqrKVTQhCE+HrJpPZF7WjfCyTDYP3uqY nu/Q== X-Gm-Message-State: ALoCoQkJaR4US58pkYAARLkpLOHNMxqxngGaJrme3AWdmH1EFOfvgncFjt6zdVPI5tGKulnrMMn3 X-Received: by 10.194.85.83 with SMTP id f19mr5220852wjz.20.1418204151132; Wed, 10 Dec 2014 01:35:51 -0800 (PST) Received: from xps13.localnet ([78.188.139.117]) by mx.google.com with ESMTPSA id j2sm5088512wjs.28.2014.12.10.01.35.49 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 10 Dec 2014 01:35:50 -0800 (PST) From: Thomas Monjalon To: Helin Zhang Date: Wed, 10 Dec 2014 10:35:21 +0100 Message-ID: <2233989.0bm00NiAWz@xps13> Organization: 6WIND User-Agent: KMail/4.14.3 (Linux/3.17.4-1-ARCH; KDE/4.14.3; x86_64; ; ) In-Reply-To: <1418201706-32162-1-git-send-email-helin.zhang@intel.com> References: <1417829617-7185-1-git-send-email-helin.zhang@intel.com> <1418201706-32162-1-git-send-email-helin.zhang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v4] mbuf: fix of enabling all newly added RX error flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Dec 2014 09:35:51 -0000 2014-12-10 16:55, Helin Zhang: > Before redefining mbuf structure, there was lack of free bits in 'ol_flags' > (32 bits in total) for new RX or TX flags. So it tried to reuse existant > bits as most as possible, or even assigning 0 to some of bit flags. After > new mbuf structure defined, there are quite a lot of free bits. So those > newly added bit flags should be assigned with correct and valid bit values, > and getting their names should be enabled as well. Note that 'RECIP' should > be removed, as nowhere uses it. 'PKT_RX_ERR' is defined to replace all other > error bit flags, e.g. MAC error, Oversize error, header buffer overflow error. > > Signed-off-by: Helin Zhang > --- > lib/librte_mbuf/rte_mbuf.c | 7 ++----- > lib/librte_mbuf/rte_mbuf.h | 9 +++------ > lib/librte_pmd_i40e/i40e_rxtx.c | 37 ++++++++++++++++++++----------------- > 3 files changed, 25 insertions(+), 28 deletions(-) > > v2 changes: > * Removed error flag of 'ECIPE' processing only in both i40e PMD and mbuf. All > other error flags were added back. > * Assigned error flags with correct and valid values, as their previous values > were invalid. > * Enabled getting all error flag names. > > v3 changes: > * 'PKT_RX_ERR' is defined to replace error bit flags of MAC error, Oversize > error, header buffer overflow error. > * Removed assigning values to PKT_TX_* bit flags, as it has already been done > in another packet set. > > v4 changes: > * Renamed 'PKT_RX_EIP_CKSUM_BAD' to 'PKT_RX_OUTER_IP_CKSUM_BAD'. > * Fixed the bug of checking error bits of 'Descriptor oversize' and > 'Header buffer oversize'. > * Added debug logs for each RX error. [...] > --- a/lib/librte_mbuf/rte_mbuf.h > +++ b/lib/librte_mbuf/rte_mbuf.h > @@ -83,12 +83,7 @@ extern "C" { > #define PKT_RX_RSS_HASH (1ULL << 1) /**< RX packet with RSS hash result. */ > #define PKT_RX_FDIR (1ULL << 2) /**< RX packet with FDIR match indicate. */ > #define PKT_RX_L4_CKSUM_BAD (1ULL << 3) /**< L4 cksum of RX pkt. is not OK. */ > -#define PKT_RX_IP_CKSUM_BAD (1ULL << 4) /**< IP cksum of RX pkt. is not OK. */ > -#define PKT_RX_EIP_CKSUM_BAD (0ULL << 0) /**< External IP header checksum error. */ > -#define PKT_RX_OVERSIZE (0ULL << 0) /**< Num of desc of an RX pkt oversize. */ > -#define PKT_RX_HBUF_OVERFLOW (0ULL << 0) /**< Header buffer overflow. */ > -#define PKT_RX_RECIP_ERR (0ULL << 0) /**< Hardware processing error. */ > -#define PKT_RX_MAC_ERR (0ULL << 0) /**< MAC error. */ > +#define PKT_RX_IP_CKSUM_BAD (1ULL << 4) /**< IP (or inner IP) header checksum error. */ It can be also an outer IP header in case the device don't support tunneling or is not configured to detect it. -- Thomas > #define PKT_RX_IPV4_HDR (1ULL << 5) /**< RX packet with IPv4 header. */ > #define PKT_RX_IPV4_HDR_EXT (1ULL << 6) /**< RX packet with extended IPv4 header. */ > #define PKT_RX_IPV6_HDR (1ULL << 7) /**< RX packet with IPv6 header. */ > @@ -99,6 +94,8 @@ extern "C" { > #define PKT_RX_TUNNEL_IPV6_HDR (1ULL << 12) /**< RX tunnel packet with IPv6 header. */ > #define PKT_RX_FDIR_ID (1ULL << 13) /**< FD id reported if FDIR match. */ > #define PKT_RX_FDIR_FLX (1ULL << 14) /**< Flexible bytes reported if FDIR match. */ > +#define PKT_RX_OUTER_IP_CKSUM_BAD (1ULL << 15) /**< Outer IP header checksum error. */ > +#define PKT_RX_ERR (1ULL << 16) /**< Other errors, e.g. MAC error. */ > /* add new RX flags here */ > > /* add new TX flags here */