DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] doc/contributing: add line continuation note to meson guide
@ 2021-09-15  9:50 Bruce Richardson
  2021-09-15 15:04 ` David Marchand
  2021-09-16  7:57 ` Thomas Monjalon
  0 siblings, 2 replies; 6+ messages in thread
From: Bruce Richardson @ 2021-09-15  9:50 UTC (permalink / raw)
  To: dev; +Cc: david.marchand, Bruce Richardson

Add a note for the preference of using "()" rather than "\" for line
continuations in meson.

Suggested-by: David Marchand <david.marchand@redhat.com>
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 doc/guides/contributing/coding_style.rst | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/doc/guides/contributing/coding_style.rst b/doc/guides/contributing/coding_style.rst
index d648689f10..b27b5fcfdb 100644
--- a/doc/guides/contributing/coding_style.rst
+++ b/doc/guides/contributing/coding_style.rst
@@ -1024,6 +1024,16 @@ The following guidelines apply to the build system code in meson.build files in
 * Line continuations should be doubly-indented to ensure visible difference from normal indentation.
   Any line continuations beyond the first may be singly indented to avoid large amounts of indentation.
 
+* Where a line is split in the middle of a statement, e.g. a multiline `if` statement,
+  brackets should be used in preference to escaping the line break.
+
+Example::
+
+    if (condition1 and condition2            # line breaks inside () need no escaping
+            and condition3 and condition4)
+        x = y
+    endif
+
 * Lists of files or components must be alphabetical unless doing so would cause errors.
 
 * Two formats are supported for lists of files or list of components:
-- 
2.30.2


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-09-23 11:48 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-15  9:50 [dpdk-dev] [PATCH] doc/contributing: add line continuation note to meson guide Bruce Richardson
2021-09-15 15:04 ` David Marchand
2021-09-23 11:48   ` Thomas Monjalon
2021-09-16  7:57 ` Thomas Monjalon
2021-09-16  8:31   ` Bruce Richardson
2021-09-16  8:44     ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).