From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 32C66A0562;
	Wed, 14 Apr 2021 14:53:49 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 198F4161A74;
	Wed, 14 Apr 2021 14:53:49 +0200 (CEST)
Received: from new2-smtp.messagingengine.com (new2-smtp.messagingengine.com
 [66.111.4.224]) by mails.dpdk.org (Postfix) with ESMTP id D98174013F
 for <dev@dpdk.org>; Wed, 14 Apr 2021 14:53:47 +0200 (CEST)
Received: from compute2.internal (compute2.nyi.internal [10.202.2.42])
 by mailnew.nyi.internal (Postfix) with ESMTP id 371DD58058A;
 Wed, 14 Apr 2021 08:53:47 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute2.internal (MEProxy); Wed, 14 Apr 2021 08:53:47 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding:content-type; s=fm3; bh=
 mfy3M/THYJGVKj1upNsxgasLffBGW/YJ+Olb+ESVvrw=; b=JYXHv0LtB5hiKhzA
 V4chDubRxLJZiPJHpfG1WFkHLgsxqtYqJx8Xa5fksOiuMBzytLgf5hKhqoJER7r1
 xlv7ncALD+mo9FbuRx2R0H7qfeyf8AD41qG3VYmAnG4LV+iq+59KtJ25IEnsAwW9
 nvL/ZreuoSQHedeArWv/r8jHA0aGpjLXHBM0yqUSAvvb1RBJVDrwkCTxv2f1jrGB
 4/O/CxJ4cmqrtZNVlWMOrplz/9vH7hG3r5S+2qGoZGg5knM26W8wWdVkM0x1RCQ1
 UPruHDKlRuar6vof4v/pwmjI/5whbY7MduuHxq6pxE8D12QH+rzmMGU5znjtkdVl
 b91Mxg==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
 :x-sasl-enc; s=fm2; bh=mfy3M/THYJGVKj1upNsxgasLffBGW/YJ+Olb+ESVv
 rw=; b=iX1pP+B1xWoTwL1XC3UAEHfsls/Ffc88HaZ2tWPOTjzid/4yg9l1g3KVc
 YCsxZIBqBe8GGSxyWda2GSnEURikzuEezgc5+hENOIzDFwCETrCcMEl9KN3Crq/P
 nSRxofJJP/JFLnmNNEmNXz6FxOPpMOgNretRU2HmatZ15qTLVZc5zXLTdS0ywxWt
 CWUMe97jlP2UbnYQej8u/tALCUzXWWI7QBB6CnhbfVtthGlUbBkqY9GtH64Zsiv0
 swpl2BP4o07yhi/HPaxNGz2Mplvhu0F8e0R9h4gNLXLqGxwcYIG0/CZiuHvalSbF
 JMzOMiEUfvr1PwGN0/iiTs1bJbXcQ==
X-ME-Sender: <xms:2uV2YGTSs9sKI7klvuol9xRTln7ZXtpPFp_gQMyzq0JKNHn2pWGyFQ>
 <xme:2uV2YLyIvA51ZUuowS19oFI6S_vczXL9zRmU21-OhM4oH7v64ORC1zqNsMN8i9WYi
 wt-KGg_KO83CFhtaA>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudeluddgheejucetufdoteggodetrfdotf
 fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
 uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
 cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr
 shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg
 ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu
 ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf
 hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl
 ohhnrdhnvght
X-ME-Proxy: <xmx:2uV2YD14z7WupNgC6bl562u5_m9gDM4fgNwH3Kd1IdhR8tyJFGLZyQ>
 <xmx:2uV2YCBsfNJI_WW1GoMMrrziUSQpNQZQw2Uc3gZ2nW1C36-gzNYsyw>
 <xmx:2uV2YPiN4hEAirIHs8c70hv3wJ5QD7-2a2uglz0DV7BhbU4vA4I4aw>
 <xmx:2-V2YPwM-OqRKK7h5DgIEvK6GfFbCAYhA3TYJUjQ5FN8C8JMLhtn_w>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 682EF1080064;
 Wed, 14 Apr 2021 08:53:44 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Akhil Goyal <gakhil@marvell.com>
Cc: jerinj@marvell.com, dev@dpdk.org, mdr@ashroe.eu, david.marchand@redhat.com,
 abhinandan.gujjar@intel.com, hemant.agrawal@nxp.com, nipun.gupta@nxp.com,
 sachin.saxena@oss.nxp.com, anoobj@marvell.com, matan@nvidia.com,
 roy.fan.zhang@intel.com, g.singh@nxp.com, erik.g.carrillo@intel.com,
 jay.jayatheerthan@intel.com, pbhagavatula@marvell.com,
 harry.van.haaren@intel.com, sthotton@marvell.com
Date: Wed, 14 Apr 2021 14:53:41 +0200
Message-ID: <2242749.yNUvgHzJfl@thomas>
In-Reply-To: <20210414122036.1262579-5-gakhil@marvell.com>
References: <561328fb16b18404a30a2401c6bfb3a7f373a0f4.1618309291.git.sthotton@marvell.com>
 <20210414122036.1262579-1-gakhil@marvell.com>
 <20210414122036.1262579-5-gakhil@marvell.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v9 4/4] devtools: add exception for reserved
 fields
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

14/04/2021 14:20, gakhil@marvell.com:
> From: Akhil Goyal <gakhil@marvell.com>
> 
> Certain structures are added with reserved fields
> to address any future enhancements to retain ABI
> compatibility.
> However, ABI script will still report error as it
> is not aware of reserved fields. Hence, adding a
> generic exception for reserved fields.
> 
> Signed-off-by: Akhil Goyal <gakhil@marvell.com>
> ---
>  devtools/libabigail.abignore | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/devtools/libabigail.abignore b/devtools/libabigail.abignore
> index 46a5a6af5..a9d284f76 100644
> --- a/devtools/libabigail.abignore
> +++ b/devtools/libabigail.abignore
> @@ -25,3 +25,7 @@
>  [suppress_type]
>  	name = rte_eventdev
>  	has_data_member_inserted_between = {offset_after(attached), end}
> +
> +; Ignore changes in reserved fields
> +[suppress_variable]
> +	name_regexp = reserved

If we do that as first patch of this series,
we don't need the exception on rte_eventdev, right?