From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 52911A0548; Sun, 9 May 2021 10:56:08 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CD08E406FF; Sun, 9 May 2021 10:56:07 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id 634B840140 for ; Sun, 9 May 2021 10:56:06 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 690885C0069; Sun, 9 May 2021 04:56:05 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Sun, 09 May 2021 04:56:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= 0AMzAVoscXNNma7sp5P/RWyWla0eK0WPh8gllhqaCYU=; b=lfLPIBEPpeyDwV0/ 9x0TKHTLaxV3rfjXybUAp0URx5pb0TjPXN9h1v8NwB6dYzk/nmhBP5T/A1NvFVz8 TTSiEvmJ7AIudThtXpiFzyaCLGG1ihCz0Ued82zETMsfB1kUgI7edR0YX2lApkv1 UcDpRr0351la/YyS+be9suaPjxwic5HMDRCbMwKl5BqzDzB7osK1uQX5tgpI5FUA zjo0EqiooJQ4Vi+6hrljXuzH/9Ycy1vMy5CJkuW+Fu4JOWuwvu1KgrjyFdQRDOlZ v2wi4NVn6biZc5tcupL6wX+75x9Swl7CEqI11XyhJKQ3pgtFu77pVungRV/PhDzF 5LUMLw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=0AMzAVoscXNNma7sp5P/RWyWla0eK0WPh8gllhqaC YU=; b=nV61qwdm2ANxWhfnnEuM54xQupj7jhHI41M3v3bo1CaCJ3faxp13Inhnh GeR3PpOOQeWS3fGmqUgD4sVvr98r2Aj++mT2nf76cjf73WRv9Rqkhc1x+JuKuGSU cNJurOQNqfSGPaBMc6lOzd2slcWJiOlrIRT4S2tCPggmlhrCPBWD5nbvzPLJQjUM lM/59ojSzRnr2sGLDHUQZ2rN0Lh0h0i2So+0sNfYZrr3T/SORuM8bFt2V9aBTQPZ DNJO9/0qLCZ9PFAt3ObIYYKObZfGa1foqIxCq4pU/BdkLAmTLrCiT1lhN8P3eq9v UUuGgT84B0w/lwClpaPGgJbgdIrEw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdegiedgudduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 9 May 2021 04:56:04 -0400 (EDT) From: Thomas Monjalon To: Akhil Goyal , "dev@dpdk.org" , Matan Azrad Cc: Suanming Mou Date: Sun, 09 May 2021 10:56:00 +0200 Message-ID: <2243665.ILJxVsgWGn@thomas> In-Reply-To: References: <20210429154712.2820159-1-matan@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [EXT] [PATCH v3 10/15] crypto/mlx5: add keytag device argument X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 09/05/2021 10:31, Matan Azrad: > > From: Akhil Goyal > > > From: Suanming Mou > > > > > > A keytag is a piece of data encrypted together with a DEK. > > > > > > When a DEK is referenced by an MKEY.bsf through its index, the keytag > > > is also supplied in the BSF as plaintext. The HW will decrypt the DEK > > > (and the attached keytag) and will fail the operation if the keytags > > > don't match. > > > > > > This commit adds the configuration of the keytag with devargs. > > > > > > Signed-off-by: Suanming Mou > > > Signed-off-by: Matan Azrad > > > --- > > Documentation for devargs should be part of this patch. > > Please split the last patch accordingly. > > > > Title can be shortened to > > Crypto/mlx5: add keytag devarg > > > > Fix other patches of devargs accordingly. > > As I said before, no devargs is really active before adding datapath patches. > The option to add all the supported features \ documentations in the patch which actually adds the support is correct. > > The last patch adds the capabilities and docs when all of them are really supported. I think it is better for git history (blame, etc) to have doc added at the same time of the code, even if the datapath is not active. I agree with Akhil.