From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id B7F6034F3 for ; Tue, 13 Nov 2018 16:57:54 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 5DFD3202F2; Tue, 13 Nov 2018 10:57:54 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 13 Nov 2018 10:57:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=+B3NLHo3rPI1wFMcxI/HNXUz4HC9lNAcpYr633mSlV4=; b=RIKlNIWXBHgP hyafFDEITC4eqrodouWKQAvv8jX1nIGwpwHklcUqp6vkAlKtxBXbBRpBcUD2hKPK vc2FW1UOhWe/h19wV1sdJ1Sn9+oa4lHKDN/AUgeIkNl1K+te2HZ7jom0Bmz+FIRx cdZCz/qvlrJ38eMoOKF8+59XU5XCg5M= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=+B3NLHo3rPI1wFMcxI/HNXUz4HC9lNAcpYr633mSl V4=; b=qRJnbwp8NhMrJLoZg67o6YzEdNUqoGdYs157G/cLeA5jp+48uLVcpF/iv LRqtJCKYVlxuOjC3jKdJZvTXElyCpa3PXfQN40fCFxX9l9jpAD+CeMvlWqVoB4lt 061WlxAhEPC23j2n9Z/dBLiUyCfqcE1hQgtH+pHQvndzQ6dDjLc2RYg1BAvL+D08 x4zBH3DobtwIR+cvy+II7fMQBSVlyfolBN93Rc+axX7jGkVrkbwuNeoPFj38sFL0 ABuDF3jErzVMWHlY43N1DVA6z+Mr76VujA3e9/rE1tq/w7IrJFWwzIn9oRLAuHE8 6mkX4O4pepslLr4fFpcOCBObQB/NQ== X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id AECFF1037A; Tue, 13 Nov 2018 10:57:51 -0500 (EST) From: Thomas Monjalon To: Gavin Hu Cc: dev@dpdk.org, stephen@networkplumber.org, olivier.matz@6wind.com, chaozhu@linux.vnet.ibm.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, jerin.jacob@caviumnetworks.com, Honnappa.Nagarahalli@arm.com Date: Tue, 13 Nov 2018 16:57:49 +0100 Message-ID: <2246047.F6nQ2GSFza@xps> In-Reply-To: <1541763767-7399-1-git-send-email-gavin.hu@arm.com> References: <1541763767-7399-1-git-send-email-gavin.hu@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v1 0/2] ring C11 library fix and optimization X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Nov 2018 15:57:54 -0000 09/11/2018 12:42, Gavin Hu: > V1: > Update the ring C11 library including the following changes: > 1) On relaxed ordering platforms(like Arm64,PPPC), in ring C11 implementation, > loading head and tail might be reodered, this makes CAS(compare and retry > the flow if the head is outdated) not working as expected, the fix is to > ensure the head is read before the tail, leaving no chances of the combination > of outdated head and new tail. > 2) With the above memory fence introduced, some loading can be relaxed. > > Gavin Hu (2): > ring: keep the deterministic order allowing retry to work > ring: relaxed ordering for load and store the head No comment, so I guess it can enter in 18.11-rc3. Applied, thanks