From: Thomas Monjalon <thomas@monjalon.net> To: Ed Czeck <ed.czeck@atomicrules.com> Cc: dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>, david.marchand@redhat.com, "Richardson, Bruce" <bruce.richardson@intel.com>, Olivier MATZ <olivier.matz@6wind.com>, andrew.rybchenko@oktetlabs.ru, akhil.goyal@nxp.com, Shepard Siegel <shepard.siegel@atomicrules.com>, John Miller <john.miller@atomicrules.com> Subject: Re: [dpdk-dev] [PATCH v2 07/15] net/ark: ignore user data Date: Tue, 27 Oct 2020 16:55:58 +0100 Message-ID: <2247372.p4sHLASWvk@thomas> (raw) In-Reply-To: <CALZ3GujA4QA2mN-PkEjEZbJtndd-ZzcM=zNs8xArvZWc3MSE3A@mail.gmail.com> 27/10/2020 16:32, Ed Czeck: > HI Thomas, > Atomic Rules will be submitting a patch to connect user_data into the > mbuf stuct using > the dynfield interface restoring lost functionality from this patch. I don't understand what you are looking for. The user data has no meaning, and is removed. Please explain your use case and what you need. Does it mean you ack this patch? > You can expect a patch in the next few days. Are you targeting this > patch series for the 20.11 release? Yes 20.11-rc2 (this week) is the target. > On Mon, Oct 26, 2020 at 6:20 PM Thomas Monjalon <thomas@monjalon.net> wrote: > > > > The second field of metadata is reserved for user data > > which is a deprecated mbuf field. > > The usage of mbuf udata64 is removed > > and the corresponding ark metadata field is annotated as ignored. > > > > Signed-off-by: Thomas Monjalon <thomas@monjalon.net> > > --- > > drivers/net/ark/ark_ddm.h | 2 +- > > drivers/net/ark/ark_ethdev_rx.c | 1 - > > drivers/net/ark/ark_ethdev_tx.c | 1 - > > drivers/net/ark/ark_udm.h | 2 +- > > 4 files changed, 2 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/net/ark/ark_ddm.h b/drivers/net/ark/ark_ddm.h > > index 5456b4b5cc..99eded8524 100644 > > --- a/drivers/net/ark/ark_ddm.h > > +++ b/drivers/net/ark/ark_ddm.h > > @@ -19,7 +19,7 @@ > > /* struct defining Tx meta data -- fixed in FPGA -- 16 bytes */ > > struct ark_tx_meta { > > uint64_t physaddr; > > - uint32_t user1; > > + uint32_t user1; /* ignored */ > > uint16_t data_len; /* of this MBUF */ > > #define ARK_DDM_EOP 0x01 > > #define ARK_DDM_SOP 0x02 > > diff --git a/drivers/net/ark/ark_ethdev_rx.c b/drivers/net/ark/ark_ethdev_rx.c > > index 2f8d05099c..5ead67e6b8 100644 > > --- a/drivers/net/ark/ark_ethdev_rx.c > > +++ b/drivers/net/ark/ark_ethdev_rx.c > > @@ -272,7 +272,6 @@ eth_ark_recv_pkts(void *rx_queue, > > mbuf->pkt_len = meta->pkt_len; > > mbuf->data_len = meta->pkt_len; > > mbuf->timestamp = meta->timestamp; > > - mbuf->udata64 = meta->user_data; > > > > if (ARK_DEBUG_CORE) { /* debug sanity checks */ > > if ((meta->pkt_len > (1024 * 16)) || > > diff --git a/drivers/net/ark/ark_ethdev_tx.c b/drivers/net/ark/ark_ethdev_tx.c > > index a0e35af880..8a0a9381f7 100644 > > --- a/drivers/net/ark/ark_ethdev_tx.c > > +++ b/drivers/net/ark/ark_ethdev_tx.c > > @@ -70,7 +70,6 @@ eth_ark_tx_meta_from_mbuf(struct ark_tx_meta *meta, > > uint8_t flags) > > { > > meta->physaddr = rte_mbuf_data_iova(mbuf); > > - meta->user1 = (uint32_t)mbuf->udata64; > > meta->data_len = rte_pktmbuf_data_len(mbuf); > > meta->flags = flags; > > } > > diff --git a/drivers/net/ark/ark_udm.h b/drivers/net/ark/ark_udm.h > > index 5846c825b8..ba436ee25b 100644 > > --- a/drivers/net/ark/ark_udm.h > > +++ b/drivers/net/ark/ark_udm.h > > @@ -18,7 +18,7 @@ > > /* Meta data structure apssed from FPGA, must match layout in FPGA */ > > struct ark_rx_meta { > > uint64_t timestamp; > > - uint64_t user_data; > > + uint64_t user_data; /* ignored */ > > uint8_t port; > > uint8_t dst_queue; > > uint16_t pkt_len; > > -- > > 2.28.0
next prev parent reply other threads:[~2020-10-27 15:56 UTC|newest] Thread overview: 178+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-10-26 5:20 [dpdk-dev] [PATCH 00/15] remove mbuf userdata Thomas Monjalon 2020-10-26 5:20 ` [dpdk-dev] [PATCH 01/15] examples: enclose DPDK includes with angle brackets Thomas Monjalon 2020-10-26 14:23 ` Andrew Rybchenko 2020-10-27 11:32 ` Bruce Richardson 2020-10-26 5:20 ` [dpdk-dev] [PATCH 02/15] kni: move header file from EAL Thomas Monjalon 2020-10-26 14:25 ` Andrew Rybchenko 2020-10-27 11:33 ` Bruce Richardson 2020-10-26 5:20 ` [dpdk-dev] [PATCH 03/15] mbuf: fix typo in dynamic field convention note Thomas Monjalon 2020-10-26 14:26 ` Andrew Rybchenko 2020-10-26 5:20 ` [dpdk-dev] [PATCH 04/15] node: switch IPv4 metadata to dynamic mbuf field Thomas Monjalon 2020-10-26 10:40 ` David Marchand 2020-10-26 14:29 ` Thomas Monjalon 2020-10-26 14:34 ` Andrew Rybchenko 2020-10-26 14:39 ` Thomas Monjalon 2020-10-26 5:20 ` [dpdk-dev] [PATCH 05/15] security: switch " Thomas Monjalon 2020-10-26 10:41 ` David Marchand 2020-10-26 14:30 ` Thomas Monjalon 2020-10-26 17:58 ` Akhil Goyal 2020-10-26 15:06 ` Andrew Rybchenko 2020-10-26 16:49 ` Thomas Monjalon 2020-10-26 19:03 ` Thomas Monjalon 2020-10-26 5:20 ` [dpdk-dev] [PATCH 06/15] event/sw: switch test counter " Thomas Monjalon 2020-10-26 15:09 ` Andrew Rybchenko 2020-10-26 5:20 ` [dpdk-dev] [PATCH 07/15] net/ark: ignore user data Thomas Monjalon 2020-10-26 5:20 ` [dpdk-dev] [PATCH 08/15] net/bnxt: switch CFA code to dynamic mbuf field Thomas Monjalon 2020-10-26 10:42 ` David Marchand 2020-10-26 14:32 ` Thomas Monjalon 2020-10-26 5:20 ` [dpdk-dev] [PATCH 09/15] net/vmxnet3: switch MSS hint " Thomas Monjalon 2020-10-26 15:14 ` Andrew Rybchenko 2020-10-26 15:21 ` Andrew Rybchenko 2020-10-26 16:50 ` Thomas Monjalon 2020-10-26 18:13 ` Thomas Monjalon 2020-10-26 5:21 ` [dpdk-dev] [PATCH 10/15] test/distributor: switch sequence " Thomas Monjalon 2020-10-26 9:39 ` Lukasz Wojciechowski 2020-10-26 5:21 ` [dpdk-dev] [PATCH 11/15] test/graph: switch user data " Thomas Monjalon 2020-10-26 5:21 ` [dpdk-dev] [PATCH 12/15] app/eventdev: switch flow ID " Thomas Monjalon 2020-10-26 5:21 ` [dpdk-dev] [PATCH 13/15] examples/bbdev: switch " Thomas Monjalon 2020-10-26 5:21 ` [dpdk-dev] [PATCH 14/15] examples/rxtx_callbacks: " Thomas Monjalon 2020-10-26 10:43 ` David Marchand 2020-10-26 14:33 ` Thomas Monjalon 2020-10-26 14:53 ` Stephen Hemminger 2020-10-26 16:32 ` Thomas Monjalon 2020-10-26 5:21 ` [dpdk-dev] [PATCH 15/15] mbuf: remove userdata field Thomas Monjalon 2020-10-26 22:19 ` [dpdk-dev] [PATCH v2 00/15] remove mbuf userdata Thomas Monjalon 2020-10-26 22:19 ` [dpdk-dev] [PATCH v2 01/15] examples: enclose DPDK includes with angle brackets Thomas Monjalon 2020-10-26 22:20 ` [dpdk-dev] [PATCH v2 02/15] kni: move header file from EAL Thomas Monjalon 2020-10-26 22:20 ` [dpdk-dev] [PATCH v2 03/15] mbuf: fix typo in dynamic field convention note Thomas Monjalon 2020-10-26 22:20 ` [dpdk-dev] [PATCH v2 04/15] node: switch IPv4 metadata to dynamic mbuf field Thomas Monjalon 2020-10-27 9:32 ` Olivier Matz 2020-10-27 9:34 ` Thomas Monjalon 2020-10-27 14:23 ` Nithin Dabilpuram 2020-10-27 14:33 ` Thomas Monjalon 2020-10-27 15:33 ` Nithin Dabilpuram 2020-10-27 15:57 ` Thomas Monjalon 2020-10-27 16:16 ` Nithin Dabilpuram 2020-10-27 16:26 ` Thomas Monjalon 2020-10-28 9:30 ` [dpdk-dev] [PATCH v4] " Nithin Dabilpuram 2020-10-28 10:08 ` Thomas Monjalon 2020-10-28 10:24 ` Van Haaren, Harry 2020-10-28 10:42 ` Nithin Dabilpuram 2020-10-28 10:43 ` Thomas Monjalon 2020-10-28 18:07 ` Thomas Monjalon 2020-10-29 10:17 ` Van Haaren, Harry 2020-10-28 10:33 ` Nithin Dabilpuram 2020-10-26 22:20 ` [dpdk-dev] [PATCH v2 05/15] security: switch " Thomas Monjalon 2020-10-27 2:01 ` Wang, Haiyue 2020-10-27 8:52 ` Thomas Monjalon 2020-10-27 13:12 ` Wang, Haiyue 2020-10-27 10:05 ` Olivier Matz 2020-10-27 16:10 ` Thomas Monjalon 2020-10-26 22:20 ` [dpdk-dev] [PATCH v2 06/15] event/sw: switch test counter " Thomas Monjalon 2020-10-27 10:15 ` Olivier Matz 2020-10-27 16:14 ` Thomas Monjalon 2020-10-26 22:20 ` [dpdk-dev] [PATCH v2 07/15] net/ark: ignore user data Thomas Monjalon 2020-10-27 15:32 ` Ed Czeck 2020-10-27 15:55 ` Thomas Monjalon [this message] 2020-10-27 16:05 ` Thomas Monjalon 2020-10-26 22:20 ` [dpdk-dev] [PATCH v2 08/15] net/bnxt: switch CFA code to dynamic mbuf field Thomas Monjalon 2020-10-27 4:44 ` Ajit Khaparde 2020-10-27 10:31 ` Olivier Matz 2020-10-27 16:22 ` Thomas Monjalon 2020-10-26 22:20 ` [dpdk-dev] [PATCH v2 09/15] net/vmxnet3: switch MSS hint " Thomas Monjalon 2020-10-27 10:45 ` Olivier Matz 2020-10-27 16:25 ` Thomas Monjalon 2020-10-26 22:20 ` [dpdk-dev] [PATCH v2 10/15] test/distributor: switch sequence " Thomas Monjalon 2020-10-26 22:20 ` [dpdk-dev] [PATCH v2 11/15] test/graph: switch user data " Thomas Monjalon 2020-10-26 22:20 ` [dpdk-dev] [PATCH v2 12/15] app/eventdev: switch flow ID " Thomas Monjalon 2020-10-26 22:20 ` [dpdk-dev] [PATCH v2 13/15] examples/bbdev: switch " Thomas Monjalon 2020-10-26 22:20 ` [dpdk-dev] [PATCH v2 14/15] examples/rxtx_callbacks: " Thomas Monjalon 2020-10-26 22:20 ` [dpdk-dev] [PATCH v2 15/15] mbuf: remove userdata field Thomas Monjalon 2020-10-27 10:53 ` Olivier Matz 2020-10-27 21:01 ` [dpdk-dev] [PATCH v3 00/15] remove mbuf userdata Thomas Monjalon 2020-10-27 21:01 ` [dpdk-dev] [PATCH v3 01/15] examples: enclose DPDK includes with angle brackets Thomas Monjalon 2020-10-27 21:01 ` [dpdk-dev] [PATCH v3 02/15] kni: move header file from EAL Thomas Monjalon 2020-10-27 21:01 ` [dpdk-dev] [PATCH v3 03/15] mbuf: fix typo in dynamic field convention note Thomas Monjalon 2020-10-27 21:01 ` [dpdk-dev] [PATCH v3 04/15] node: switch IPv4 metadata to dynamic mbuf field Thomas Monjalon 2020-10-27 21:01 ` [dpdk-dev] [PATCH v3 05/15] security: switch " Thomas Monjalon 2020-10-27 21:01 ` [dpdk-dev] [PATCH v3 06/15] event/sw: switch test counter " Thomas Monjalon 2020-10-27 21:01 ` [dpdk-dev] [PATCH v3 07/15] net/ark: switch user data " Thomas Monjalon 2020-10-27 22:30 ` Thomas Monjalon 2020-10-27 21:01 ` [dpdk-dev] [PATCH v3 08/15] net/bnxt: switch CFA code " Thomas Monjalon 2020-10-27 21:01 ` [dpdk-dev] [PATCH v3 09/15] net/vmxnet3: switch MSS hint " Thomas Monjalon 2020-10-27 21:01 ` [dpdk-dev] [PATCH v3 10/15] test/distributor: switch sequence " Thomas Monjalon 2020-10-27 21:01 ` [dpdk-dev] [PATCH v3 11/15] test/graph: switch user data " Thomas Monjalon 2020-10-27 21:01 ` [dpdk-dev] [PATCH v3 12/15] app/eventdev: switch flow ID " Thomas Monjalon 2020-10-28 4:54 ` Jerin Jacob 2020-10-28 7:43 ` Thomas Monjalon 2020-10-28 8:06 ` Jerin Jacob 2020-10-27 21:01 ` [dpdk-dev] [PATCH v3 13/15] examples/bbdev: switch " Thomas Monjalon 2020-10-27 21:01 ` [dpdk-dev] [PATCH v3 14/15] examples/rxtx_callbacks: " Thomas Monjalon 2020-10-27 21:01 ` [dpdk-dev] [PATCH v3 15/15] mbuf: remove userdata field Thomas Monjalon 2020-10-28 10:26 ` [dpdk-dev] [PATCH v4 00/15] remove mbuf userdata Thomas Monjalon 2020-10-28 10:26 ` [dpdk-dev] [PATCH v4 01/15] examples: enclose DPDK includes with angle brackets Thomas Monjalon 2020-10-28 10:26 ` [dpdk-dev] [PATCH v4 02/15] kni: move header file from EAL Thomas Monjalon 2020-10-28 10:26 ` [dpdk-dev] [PATCH v4 03/15] mbuf: fix typo in dynamic field convention note Thomas Monjalon 2020-10-28 10:26 ` [dpdk-dev] [PATCH v4 04/15] node: switch IPv4 metadata to dynamic mbuf field Thomas Monjalon 2020-10-28 10:26 ` [dpdk-dev] [PATCH v4 05/15] security: switch " Thomas Monjalon 2020-10-28 10:26 ` [dpdk-dev] [PATCH v4 06/15] event/sw: switch test counter " Thomas Monjalon 2020-10-28 10:26 ` [dpdk-dev] [PATCH v4 07/15] net/ark: switch user data to dynamic mbuf fields Thomas Monjalon 2020-10-28 10:26 ` [dpdk-dev] [PATCH v4 08/15] net/bnxt: switch CFA code to dynamic mbuf field Thomas Monjalon 2020-10-28 10:26 ` [dpdk-dev] [PATCH v4 09/15] net/vmxnet3: switch MSS hint " Thomas Monjalon 2020-10-28 10:26 ` [dpdk-dev] [PATCH v4 10/15] test/distributor: switch sequence " Thomas Monjalon 2020-10-28 10:26 ` [dpdk-dev] [PATCH v4 11/15] test/graph: switch user data " Thomas Monjalon 2020-10-28 10:26 ` [dpdk-dev] [PATCH v4 12/15] app/eventdev: switch flow ID " Thomas Monjalon 2020-10-28 10:26 ` [dpdk-dev] [PATCH v4 13/15] examples/bbdev: switch " Thomas Monjalon 2020-10-28 11:51 ` Andrew Rybchenko 2020-10-28 12:21 ` Thomas Monjalon 2020-10-28 12:55 ` Andrew Rybchenko 2020-10-28 10:26 ` [dpdk-dev] [PATCH v4 14/15] examples/rxtx_callbacks: " Thomas Monjalon 2020-10-28 10:26 ` [dpdk-dev] [PATCH v4 15/15] mbuf: remove userdata field Thomas Monjalon 2020-10-30 17:29 ` [dpdk-dev] [PATCH v5 00/15] remove mbuf userdata Thomas Monjalon 2020-10-30 17:29 ` [dpdk-dev] [PATCH v5 01/15] eventdev: remove software Rx timestamp Thomas Monjalon 2020-10-30 17:29 ` [dpdk-dev] [PATCH v5 02/15] mbuf: add Rx timestamp dynamic flag Thomas Monjalon 2020-11-01 20:03 ` Andrew Rybchenko 2020-10-30 17:29 ` [dpdk-dev] [PATCH v5 03/15] ethdev: register mbuf field and flags for timestamp Thomas Monjalon 2020-11-01 20:10 ` Andrew Rybchenko 2020-11-01 22:54 ` Thomas Monjalon 2020-10-30 17:29 ` [dpdk-dev] [PATCH v5 04/15] latency: switch timestamp to dynamic mbuf field Thomas Monjalon 2020-10-30 17:29 ` [dpdk-dev] [PATCH v5 05/15] net/ark: " Thomas Monjalon 2020-10-30 17:29 ` [dpdk-dev] [PATCH v5 06/15] net/dpaa2: " Thomas Monjalon 2020-10-30 17:29 ` [dpdk-dev] [PATCH v5 07/15] net/mlx5: fix dynamic mbuf offset lookup check Thomas Monjalon 2020-10-30 17:29 ` [dpdk-dev] [PATCH v5 08/15] net/mlx5: switch timestamp to dynamic mbuf field Thomas Monjalon 2020-10-30 17:29 ` [dpdk-dev] [PATCH v5 09/15] net/nfb: " Thomas Monjalon 2020-10-30 17:29 ` [dpdk-dev] [PATCH v5 10/15] net/octeontx2: " Thomas Monjalon 2020-10-30 17:29 ` [dpdk-dev] [PATCH v5 11/15] net/pcap: " Thomas Monjalon 2020-10-30 17:29 ` [dpdk-dev] [PATCH v5 12/15] app/testpmd: " Thomas Monjalon 2020-10-30 17:29 ` [dpdk-dev] [PATCH v5 13/15] examples/rxtx_callbacks: switch timestamp to dynamic field Thomas Monjalon 2020-10-30 17:29 ` [dpdk-dev] [PATCH v5 14/15] mbuf: remove deprecated timestamp field Thomas Monjalon 2020-11-01 20:13 ` Andrew Rybchenko 2020-10-30 17:29 ` [dpdk-dev] [PATCH v5 15/15] mbuf: move pool pointer in hotter first half Thomas Monjalon 2020-11-01 20:23 ` Andrew Rybchenko 2020-10-30 17:44 ` [dpdk-dev] [PATCH v6 00/15] remove mbuf userdata Thomas Monjalon 2020-10-30 17:44 ` [dpdk-dev] [PATCH v6 01/15] examples: enclose DPDK includes with angle brackets Thomas Monjalon 2020-10-30 17:44 ` [dpdk-dev] [PATCH v6 02/15] kni: move header file from EAL Thomas Monjalon 2020-10-30 17:44 ` [dpdk-dev] [PATCH v6 03/15] mbuf: fix typo in dynamic field convention note Thomas Monjalon 2020-10-30 17:44 ` [dpdk-dev] [PATCH v6 04/15] node: switch IPv4 metadata to dynamic mbuf field Thomas Monjalon 2020-10-30 17:44 ` [dpdk-dev] [PATCH v6 05/15] security: switch " Thomas Monjalon 2020-10-31 8:56 ` David Marchand 2020-10-31 9:26 ` David Marchand 2020-10-31 14:38 ` Thomas Monjalon 2020-10-30 17:44 ` [dpdk-dev] [PATCH v6 06/15] event/sw: switch test counter " Thomas Monjalon 2020-10-30 18:53 ` Van Haaren, Harry 2020-10-30 17:44 ` [dpdk-dev] [PATCH v6 07/15] net/ark: switch user data to dynamic mbuf fields Thomas Monjalon 2020-10-30 17:44 ` [dpdk-dev] [PATCH v6 08/15] net/bnxt: switch CFA code to dynamic mbuf field Thomas Monjalon 2020-10-30 17:44 ` [dpdk-dev] [PATCH v6 09/15] net/vmxnet3: switch MSS hint " Thomas Monjalon 2020-10-30 17:44 ` [dpdk-dev] [PATCH v6 10/15] test/distributor: switch sequence " Thomas Monjalon 2020-10-30 17:44 ` [dpdk-dev] [PATCH v6 11/15] test/graph: switch user data " Thomas Monjalon 2020-10-30 17:44 ` [dpdk-dev] [PATCH v6 12/15] app/eventdev: switch flow ID " Thomas Monjalon 2020-10-30 17:44 ` [dpdk-dev] [PATCH v6 13/15] examples/bbdev: switch " Thomas Monjalon 2020-10-30 17:44 ` [dpdk-dev] [PATCH v6 14/15] examples/rxtx_callbacks: switch TSC to dynamic field Thomas Monjalon 2020-10-30 17:44 ` [dpdk-dev] [PATCH v6 15/15] mbuf: remove userdata field Thomas Monjalon 2020-10-31 15:07 ` [dpdk-dev] [PATCH v6 00/15] remove mbuf userdata Thomas Monjalon 2020-10-31 23:36 ` Ferruh Yigit 2020-11-01 9:15 ` Thomas Monjalon 2020-11-01 10:26 ` David Marchand 2020-11-02 9:11 ` Jiawen Wu 2020-11-02 11:08 ` Ferruh Yigit 2020-11-02 11:58 ` Ferruh Yigit
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=2247372.p4sHLASWvk@thomas \ --to=thomas@monjalon.net \ --cc=akhil.goyal@nxp.com \ --cc=andrew.rybchenko@oktetlabs.ru \ --cc=bruce.richardson@intel.com \ --cc=david.marchand@redhat.com \ --cc=dev@dpdk.org \ --cc=ed.czeck@atomicrules.com \ --cc=ferruh.yigit@intel.com \ --cc=john.miller@atomicrules.com \ --cc=olivier.matz@6wind.com \ --cc=shepard.siegel@atomicrules.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git