From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Xie, Huawei" <huawei.xie@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v4 0/5] lib/librte_vhost: user space vhost cuse driver library
Date: Wed, 24 Sep 2014 18:21:58 +0200 [thread overview]
Message-ID: <2248333.HL0PhLEb6K@xps13> (raw)
In-Reply-To: <F52918179C57134FAEC9EA62FA2F96251185A96E@shsmsx102.ccr.corp.intel.com>
Hi,
2014-09-24 14:32, Ouyang, Changchun:
> This v4 patch remove the jumbo frame related codes
> and Huawei will add it back in a separate patch,
I'd prefer a v5 which includes these changes.
I know this patchset is pending and reworked many times,
so I'll try to integrate v5 with top priority.
Other comments:
- examples/vhost/Makefile should not be copied (and removed just after)
- coding style fixes are aligning things but antislashes are not well aligned
- fuse-devel and kernel-modules-extra packages are not available in
this form in all distributions, it's better to describe what is behind
these package names (especially for kernel-modules-extra)
I won't have time to properly review the big refactoring. But I'm sure
we'll better check it when using it once integrated.
The essential is to be able to view the changes in the git history.
Thanks for this effort.
--
Thomas
next prev parent reply other threads:[~2014-09-24 16:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-12 10:54 Huawei Xie
2014-09-12 10:55 ` [dpdk-dev] [PATCH v4 1/5] lib/librte_vhost: mv vhost example to vhost lib directory for further code re-factoring Huawei Xie
2014-09-12 10:55 ` [dpdk-dev] [PATCH v4 2/5] lib/librte_vhost: re-factor vhost lib for subsequent transform Huawei Xie
2014-09-12 10:55 ` [dpdk-dev] [PATCH v4 3/5] lib/librte_vhost: vhost lib refactor Huawei Xie
2014-09-12 10:55 ` [dpdk-dev] [PATCH v4 4/5] coding style issue fix Huawei Xie
2014-09-12 10:55 ` [dpdk-dev] [PATCH v4 5/5] lib/librte_vhost: add vhost lib support in makefile Huawei Xie
2014-09-13 4:57 ` Linhaifeng
2014-09-12 11:07 ` [dpdk-dev] [PATCH v4 0/5] lib/librte_vhost: user space vhost cuse driver library Xie, Huawei
2014-09-23 16:07 ` Xie, Huawei
2014-09-24 14:32 ` Ouyang, Changchun
2014-09-24 16:21 ` Thomas Monjalon [this message]
2014-09-25 3:09 ` Xie, Huawei
2014-09-25 14:27 ` Xie, Huawei
2014-09-25 18:00 ` Xie, Huawei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2248333.HL0PhLEb6K@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=huawei.xie@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).