From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f50.google.com (mail-wg0-f50.google.com [74.125.82.50]) by dpdk.org (Postfix) with ESMTP id 381D96896 for ; Wed, 24 Sep 2014 18:15:53 +0200 (CEST) Received: by mail-wg0-f50.google.com with SMTP id l18so5670284wgh.9 for ; Wed, 24 Sep 2014 09:22:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=ERAXsq8jUAqfsY8kR4tfsdR+DpT3YpzCWJLcG3HoOBM=; b=iJS9Pn7srBt6DRnkmIOivbQr4BbZ5pLV3mF/1P5YBXeFBzgj2FW9JrVD158m2/KSmw quPSGEI/S3x6xSHP+diN6ZQ5W5DEE1c/RqiNxqbL5MQaeL0aEdGLkVocMByBCnwmuT+q ros5hkcVC6LdCY4PtXOmAPXcuv/PzZYtCQLs0NoIn5bgWagEvWZHRpbBMa5BoHbnhyWN Sskz5J6/7KxDSf22OZ3mU9TYsdSpJGSYOgdQOhrLlfYcz0hVcC/A3x1wn/zKWLCr6ZBE 8A4ez74tjPlbDHLbd9B9AHn+sAI6J0tT+lJYo0Zxy/hZpcjM7Usii2hpI8zgQbWSNocG gmdA== X-Gm-Message-State: ALoCoQnpINJ7ejtRhRWXYMnKlGrNUO3TT5QQSAPZ2VcveEBQLKf7Wb0AqwYRO09424OIdICaz18f X-Received: by 10.194.134.100 with SMTP id pj4mr9536416wjb.72.1411575726751; Wed, 24 Sep 2014 09:22:06 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id ba3sm207006wib.10.2014.09.24.09.22.05 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 24 Sep 2014 09:22:05 -0700 (PDT) From: Thomas Monjalon To: "Xie, Huawei" Date: Wed, 24 Sep 2014 18:21:58 +0200 Message-ID: <2248333.HL0PhLEb6K@xps13> Organization: 6WIND User-Agent: KMail/4.13.3 (Linux/3.15.8-1-ARCH; KDE/4.13.3; x86_64; ; ) In-Reply-To: References: <1410519304-14521-1-git-send-email-huawei.xie@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v4 0/5] lib/librte_vhost: user space vhost cuse driver library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Sep 2014 16:15:53 -0000 Hi, 2014-09-24 14:32, Ouyang, Changchun: > This v4 patch remove the jumbo frame related codes > and Huawei will add it back in a separate patch, I'd prefer a v5 which includes these changes. I know this patchset is pending and reworked many times, so I'll try to integrate v5 with top priority. Other comments: - examples/vhost/Makefile should not be copied (and removed just after) - coding style fixes are aligning things but antislashes are not well aligned - fuse-devel and kernel-modules-extra packages are not available in this form in all distributions, it's better to describe what is behind these package names (especially for kernel-modules-extra) I won't have time to properly review the big refactoring. But I'm sure we'll better check it when using it once integrated. The essential is to be able to view the changes in the git history. Thanks for this effort. -- Thomas