Re: [dpdk-dev] [PATCH v4 1/2] version: 20.11-rc0

[Thomas Monjalon <thomas@monjalon.net>]

11/08/2020 15:47, Kinsella, Ray:
> On 11/08/2020 12:27, Thomas Monjalon wrote:
> > --- a/devtools/libabigail.abignore
> > +++ b/devtools/libabigail.abignore
> > @@ -8,12 +8,6 @@
> >  [suppress_variable]
> >          symbol_version = INTERNAL
> >  
> > -; Ignore ABI 20.0.1 replaced with ABI 21
> > -[suppress_function]
> > -        symbol_version = DPDK_20.0.1
> > -[suppress_variable]
> > -        symbol_version = DPDK_20.0.1
> > -
> >  ; Explicit ignore for driver-only ABI
> >  [suppress_type]
> >          name = rte_cryptodev_ops
> 
> I think we might be safer doing a complete reset of libabigail.ignore.
> We should leave only the suppressions for internal and experimental. 
> 
> My concern is that if we have suppressions that live in there forever,
> it will becomes stale, and eventually we will end up suppressing things we don't intend.
> 
> So yes, if we strip out some of these - especially the enumeration suppressions,
> We will end up having to suppress them again as we extend/modify the enumerations etc,
> but for me that preferable to the risk of unintended supressions. 
> 
> What do others think?

I removed all exceptions in v5.

I would like to apply this patch tomorrow morning.
All, please ack or nack quickly.