From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5E448A04D7; Tue, 11 Aug 2020 16:05:51 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 45DD11C032; Tue, 11 Aug 2020 16:05:51 +0200 (CEST) Received: from new1-smtp.messagingengine.com (new1-smtp.messagingengine.com [66.111.4.221]) by dpdk.org (Postfix) with ESMTP id 307FA1C031 for ; Tue, 11 Aug 2020 16:05:49 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id 82AED58039F; Tue, 11 Aug 2020 10:05:48 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Tue, 11 Aug 2020 10:05:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= 3Nj3dwWJ3EzS+mcc/x9lqe8fLZWh0ifPyk60VuYM03Y=; b=rBVzdtyx3KjbtJzO MbRdXnc3nnCNBUnAMFRo6RfusXO2+ndhJMeitZ9Plgn9fAn3TtU7c7ZiktzOsCpK FJECcxjwJEURoFWZit5Zv38cNaiGcNpMH2EhSzIfMGDqQdkDgq2wCG5HAoGbiXFd KHhFfnjkxeV/v8S5AJCoXVjHpMG4Ui+c34W1nW169m6aBP/ALM2MfsZTJFGorGiy s+EhUiWwpnMWcklvHjB258oRNJWPE8irwmb7+X/WHmNh1L013uS3m4Fu6BisJeLZ gI5/jQLUEipb/pNt0Yw0wG6lqS720Q2RlkYStS/5PcHeYpksNIL3y6ko/sYY2vPY ZRAhdQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=3Nj3dwWJ3EzS+mcc/x9lqe8fLZWh0ifPyk60VuYM0 3Y=; b=kBmOzVg4GT20FRqF0xFdyRq8WXuk0pSQPtPAhpoUtW0SibWZzvPNvgmbC lUPqCcaegMmdUiPzMt+LfCzheJ2y5+g6aRolsaRcmuCyoeU8ta9zWjEHgmaGpD6z dsU9u1saugQ/kg4EHWXUK7HooqQriKuQsHJEkKkIS/aaWZWQnRLoQLbv9gha+5zF ilWYanewghrYkSh5N/MaMIAdZDDQ1WxhIYj3KKdyBEQ5QUdmI65JhFej3JZ3Xw2Q SwjH9q6KtDSIMygiC06SuDfBcvg/5s7na1sAwozM3M5U54fFNHZXCRlQBV1c8ZDy 0ZQ398mYfv/CTiWAtrgC9JLgQZBnw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrledtgdejgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepleefrdeirddugeelrdduudegnecuvehluhhsthgvrhfuihiivg eptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdr nhgvth X-ME-Proxy: Received: from xps.localnet (114.149.6.93.rev.sfr.net [93.6.149.114]) by mail.messagingengine.com (Postfix) with ESMTPA id 93ADE30600A3; Tue, 11 Aug 2020 10:05:46 -0400 (EDT) From: Thomas Monjalon To: dev@dpdk.org Cc: david.marchand@redhat.com, nhorman@tuxdriver.com, kevin.laatz@intel.com, bruce.richardson@intel.com, Hemant Agrawal , Honnappa Nagarahalli , Luca Boccassi , Dodji Seketeli , Stephen Hemminger , "Richardson, Bruce" , "Yigit, Ferruh" , David Marchand , "Kinsella, Ray" Date: Tue, 11 Aug 2020 16:05:44 +0200 Message-ID: <22497299.0Dkr4sR0H9@thomas> In-Reply-To: <44dcd28c-73ac-4252-1993-3fdd85942532@ashroe.eu> References: <20200810151531.1297831-1-thomas@monjalon.net> <20200811112720.2103052-1-thomas@monjalon.net> <44dcd28c-73ac-4252-1993-3fdd85942532@ashroe.eu> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4 1/2] version: 20.11-rc0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 11/08/2020 15:47, Kinsella, Ray: > On 11/08/2020 12:27, Thomas Monjalon wrote: > > --- a/devtools/libabigail.abignore > > +++ b/devtools/libabigail.abignore > > @@ -8,12 +8,6 @@ > > [suppress_variable] > > symbol_version = INTERNAL > > > > -; Ignore ABI 20.0.1 replaced with ABI 21 > > -[suppress_function] > > - symbol_version = DPDK_20.0.1 > > -[suppress_variable] > > - symbol_version = DPDK_20.0.1 > > - > > ; Explicit ignore for driver-only ABI > > [suppress_type] > > name = rte_cryptodev_ops > > I think we might be safer doing a complete reset of libabigail.ignore. > We should leave only the suppressions for internal and experimental. > > My concern is that if we have suppressions that live in there forever, > it will becomes stale, and eventually we will end up suppressing things we don't intend. > > So yes, if we strip out some of these - especially the enumeration suppressions, > We will end up having to suppress them again as we extend/modify the enumerations etc, > but for me that preferable to the risk of unintended supressions. > > What do others think? I removed all exceptions in v5. I would like to apply this patch tomorrow morning. All, please ack or nack quickly.