From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CEF88A04B1; Thu, 5 Nov 2020 13:56:16 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 30CCDBE69; Thu, 5 Nov 2020 13:56:15 +0100 (CET) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id C0D38BE47 for ; Thu, 5 Nov 2020 13:56:12 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 247785C003D; Thu, 5 Nov 2020 07:56:11 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Thu, 05 Nov 2020 07:56:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= 7v/02NHYkDyM4Pq07VBm3gfm944r0oSZg40LbDY1fG0=; b=kSY5TGz0VL0SUiD3 meRAzKccC3xcwRLByKHUjV+m21gIpnoUDoNuaObSGCX+nSncJPjteUiNksJCTcIc oJGkP1jhNr4OyMflOyibI+F0gI9Z9hXCTZGNAbrxPrBYYueymkOFK4PiaPfftOz9 /Ek2s8CmkkXZvAgrLyHV+xzOuE2d7AdhR9FR03ve7plaC29NTgr8zsNkDmVZeExn KmGz3U3ZwZ/0x1Gd7bXxm1vErIfWbl3rpdL+H4i3D/T/MNLKk0YkNFmwJE629J+q hELI4IifQsL3lBa+Y3/OzlfmUsPHxKjidnjGXV5/DeSHcxmujVXXMt83k0Tb7Hxf jZ8RTQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=7v/02NHYkDyM4Pq07VBm3gfm944r0oSZg40LbDY1f G0=; b=D55qcEb2MuVL0uZ3FXU0cD90lPK6Dpxpt5+oBSfLCehQMkzj+NXA5Lv4J FCfosXAUtPXqJIWFi5qckEnE004AAGGhmO6ps26BtODPTZ0x+I+8Qf7zcBx6ddtb 5p0ciK1vSCwCpKga28iJg11t0qsFbhK7oq1rCJMHe6kwPyQupZzx8SUOYE0G8nXZ mKXoHcT/VeCyquiP/v63B7GWr3KZyQ5FKPa3mCFcROKzYUIMTK3L4gkAq4lTDqd/ kinQ2i9STtwkkn+hL9jWcTkvpqRbi022YMu3Ql+S4AR+qjo/NUGHd4S6EwacZAnF h4JHQR6Z7FrThUKdhJz357AhXmawA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedruddtjedggeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 41870306005C; Thu, 5 Nov 2020 07:56:10 -0500 (EST) From: Thomas Monjalon To: Bruce Richardson Cc: dev@dpdk.org, david.marchand@redhat.com Date: Thu, 05 Nov 2020 13:56:08 +0100 Message-ID: <2251598.qTyx3z01hf@thomas> In-Reply-To: <20201105112118.GA776@bricha3-MOBL.ger.corp.intel.com> References: <20201105110728.220957-1-bruce.richardson@intel.com> <2267482.6AlIP691sX@thomas> <20201105112118.GA776@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] test-meson-builds: add a 32-bit build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 05/11/2020 12:21, Bruce Richardson: > On Thu, Nov 05, 2020 at 12:13:37PM +0100, Thomas Monjalon wrote: > > 05/11/2020 12:07, Bruce Richardson: > > > It's reasonably common for patches to have issues when built on 32-bits, so > > > to prevent this, we can add a 32-bit build (if supported) to the > > > "test-meson-builds.sh" script. The tricky bit is using a valid > > > PKG_CONFIG_LIBDIR, so for now we use two common possibilities for where that > > > should point to in order to get a successful build. > > > > > > Signed-off-by: Bruce Richardson > > > > Thanks we really need such test. > > > > > +if echo "int main(void) { return 0; }" | cc -m32 -x c - -o /dev/null 2> /dev/null ; then > > > > I think a function would be cleaner, with -m32 passed as parameter. > > > > > + if [ -d "/usr/lib/i386-linux-gnu" ] ; then > > > + # 32-bit pkgconfig on debian/ubuntu > > > + export PKG_CONFIG_LIBDIR="/usr/lib/i386-linux-gnu/pkgconfig" > > > + else > > > + # 32-bit pkgconfig on RHEL/fedora (lib vs lib64) > > > + export PKG_CONFIG_LIBDIR="/usr/lib/pkgconfig" > > > > It is /usr/lib32 on my Arch Linux. > > > > I would prefer avoiding export, > > by assigning a local variable and use it below: > > > > PKG_CONFIG_LIBDIR=libdir32 build build-32-bit ... > > > > > + fi > > > + build build-32-bit cc -Dc_args='-m32' -Dc_link_args='-m32' > > > > Or just "build-32" as directory name. > > > > > + unset PKG_CONFIG_LIBDIR > > > > No need of unset if not using export above. > > > > > +fi > > Thanks for the quick review, I'll put together a v2 based on this feedback. One more thing, the variable DPDK_TARGET should be set accordingly so the right configuration can be loaded. By default, I believe it will be x86_64-pc-linux-gnu. We need something with "32" or i686 on x86 so we can adjust the paths to the dependencies built for 32-bit.