From: Thomas Monjalon <thomas@monjalon.net>
To: Michael Barker <mikeb01@gmail.com>
Cc: dev@dpdk.org, Ray Kinsella <mdr@ashroe.eu>
Subject: Re: [PATCH v5] Add pragma to ignore gcc-compat warnings in clang when used with diagnose_if.
Date: Sat, 12 Feb 2022 15:00:48 +0100 [thread overview]
Message-ID: <2251948.ECZNHGQPT7@thomas> (raw)
In-Reply-To: <20220131000516.76727-1-mikeb01@gmail.com>
31/01/2022 01:05, Michael Barker:
> When compiling with clang using -Wpedantic (or -Wgcc-compat) the use of
> diagnose_if kicks up a warning:
>
> .../include/rte_interrupts.h:623:1: error: 'diagnose_if' is a clang
> extension [-Werror,-Wgcc-compat]
> __rte_internal
> ^
> .../include/rte_compat.h:36:16: note: expanded from macro '__rte_internal'
> __attribute__((diagnose_if(1, "Symbol is not public ABI", "error"), \
>
> This change ignores the '-Wgcc-compat' warning in the specific location
> where the warning occurs. It is safe to do in this circumstance as the
> specific macro is only defined when using the clang compiler.
>
> Signed-off-by: Michael Barker <mikeb01@gmail.com>
Applied with following title, thanks:
eal: ignore gcc-compat warning in clang-only macro
prev parent reply other threads:[~2022-02-12 14:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-17 23:14 [PATCH] " Michael Barker
2022-01-17 23:23 ` [PATCH v2] " Michael Barker
2022-01-20 14:16 ` Thomas Monjalon
2022-01-23 21:17 ` Michael Barker
2022-01-23 23:53 ` Stephen Hemminger
2022-01-23 21:07 ` [PATCH v3] " Michael Barker
2022-01-23 21:20 ` [PATCH v4] " Michael Barker
2022-01-23 23:55 ` Stephen Hemminger
2022-01-31 0:08 ` Michael Barker
2022-01-25 10:33 ` Ray Kinsella
2022-01-31 0:10 ` Michael Barker
2022-01-31 0:05 ` [PATCH v5] " Michael Barker
2022-02-12 14:00 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2251948.ECZNHGQPT7@thomas \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=mdr@ashroe.eu \
--cc=mikeb01@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).