From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AB7BEA034E; Sat, 12 Feb 2022 15:00:54 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3DBC840683; Sat, 12 Feb 2022 15:00:54 +0100 (CET) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id 94D624067C for ; Sat, 12 Feb 2022 15:00:52 +0100 (CET) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 0EBC15C00A9; Sat, 12 Feb 2022 09:00:52 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Sat, 12 Feb 2022 09:00:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; bh=LtlW4Ufs7z6FfO mUVWOh0t6rrne0d+fK0GSuKToU/50=; b=JzXU5XEGl+/k1QA1i5cBC7Kc/lntQR OvevV8jRxyG/Aqb94zgVT41thnLs06ZUuGcvirnT9ezdD/pGA3KzaoBXsTKpVxUI L8ZDB7JdUcFCpZdMvoJ6aQMws4ikgVOxF6XlxXzkGiSIAsJMgJ8KtzJWXLwDRJIb cG306Zqr4dZ92ZN4/CyHtjWuvLVWJPQmjnHRcKv8iuqofiRCjuB5COEJpU2qR+r/ SeVOGlu+65ELLwiBPrYCDEd2M8x9thGWLCOvAmciHuqkp4Yebph8oXklmwDBqBuY e0/7/2O0j1A+ZT/FHA5WUXxd4L7ls292XsmYJ2txERzuGlWlyNu8I4fQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=LtlW4Ufs7z6FfOmUVWOh0t6rrne0d+fK0GSuKToU/ 50=; b=MrcBY06/aUNmD2n60X/K3t9olyAmUzcjn7estQ4zySpbze8dCwZhZ7smv JAB3o93r7WjUH8zyKnYbNNiKy0hfpTkUK/JAi2omELK2ktKDX/n+bU0M1yx07LFS usPGwv+sHqK+a5XNEHUb626fgSK+RdTTBXQjZEdc0NG/DHxwMZ9v8wPn2wMXdSRx xbRL0I7Lk3DIZBhnwqwxB4ux4gxUNFXjvXAGsYIyqFA13OMVj3cSDZTGbdaylU9U aGuHom5cfATUvz6n8f0z2pvXHXhotm8VDR6cpiSAFmgY4KJ0lhTmOS7eE067ompz 8gJvu8RGEhY7EEswpqF7RzVg6C/pQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrieehgdehkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhephffvufffkfgjfhgggfgtsehtufertd dttddvnecuhfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehm ohhnjhgrlhhonhdrnhgvtheqnecuggftrfgrthhtvghrnhepudeggfdvfeduffdtfeegle fghfeukefgfffhueejtdetuedtjeeuieeivdffgeehnecuvehluhhsthgvrhfuihiivgep tdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnh gvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 12 Feb 2022 09:00:49 -0500 (EST) From: Thomas Monjalon To: Michael Barker Cc: dev@dpdk.org, Ray Kinsella Subject: Re: [PATCH v5] Add pragma to ignore gcc-compat warnings in clang when used with diagnose_if. Date: Sat, 12 Feb 2022 15:00:48 +0100 Message-ID: <2251948.ECZNHGQPT7@thomas> In-Reply-To: <20220131000516.76727-1-mikeb01@gmail.com> References: <20220123212024.19747-1-mikeb01@gmail.com> <20220131000516.76727-1-mikeb01@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 31/01/2022 01:05, Michael Barker: > When compiling with clang using -Wpedantic (or -Wgcc-compat) the use of > diagnose_if kicks up a warning: > > .../include/rte_interrupts.h:623:1: error: 'diagnose_if' is a clang > extension [-Werror,-Wgcc-compat] > __rte_internal > ^ > .../include/rte_compat.h:36:16: note: expanded from macro '__rte_internal' > __attribute__((diagnose_if(1, "Symbol is not public ABI", "error"), \ > > This change ignores the '-Wgcc-compat' warning in the specific location > where the warning occurs. It is safe to do in this circumstance as the > specific macro is only defined when using the clang compiler. > > Signed-off-by: Michael Barker Applied with following title, thanks: eal: ignore gcc-compat warning in clang-only macro