From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Raslan Darawsheh <rasland@mellanox.com>
Cc: Slava Ovsiienko <viacheslavo@mellanox.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"kirankumark@marvell.com" <kirankumark@marvell.com>,
Olivier MATZ <olivier.matz@6wind.com>
Subject: Re: [dpdk-dev] [PATCH] ethdev: fix compilation with gcc 4.8
Date: Wed, 23 Oct 2019 16:00:50 +0100 [thread overview]
Message-ID: <22529e68-1ee6-7fa0-8fef-78cdbb66b065@intel.com> (raw)
In-Reply-To: <1571832859-12659-1-git-send-email-rasland@mellanox.com>
On 10/23/2019 1:14 PM, Raslan Darawsheh wrote:
> gcc 4.8 is considering bit filed as extention rather than
> c11 std with pedantic, which cause compilation failure.
>
> This adds extention keyword exceplicitly to the struct
> to avoid compilation issue on gcc 4.8
>
> Fixes: a7658a86 ("ethdev: add HIGIG2 key field to flow API")
>
> Signed-off-by: Raslan Darawsheh <rasland@mellanox.com>
Squashed into relevant commit in next-net, thanks.
Unfortunately lost the context that why it has been marked with '__extension__'
instead of 'RTE_STD_C11', hopefully someone won't try to "fix" it in the future.
prev parent reply other threads:[~2019-10-23 15:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-23 12:14 Raslan Darawsheh
2019-10-23 13:29 ` Ferruh Yigit
2019-10-23 15:00 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22529e68-1ee6-7fa0-8fef-78cdbb66b065@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=kirankumark@marvell.com \
--cc=olivier.matz@6wind.com \
--cc=rasland@mellanox.com \
--cc=viacheslavo@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).