Re: [dpdk-dev] [PATCH] sched: fix build on Atom without SSE4 support

[Thomas Monjalon <thomas.monjalon@6wind.com>]

2015-12-05 17:27, Mike Sowka:
> Thanks for the pointers Thomas. Here is a signed-off patch
> re-submission with some explanation, to the best of my experience.

Thanks, it is really well detailed.
It would have been perfect with -v2 --in-reply-to :)

> Irrelevant of the target, the preprocessor #ifdef SSE2 for the
> grinder_pipe_exists function is inadequate since the __mm_testz_si128
> function requires SSE4.1, PTEST instruction described in
> https://en.wikipedia.org/wiki/SSE4#SSE4.1 (I do no have better spec
> reference). I have bumped the preprocessor #ifdef to require SSE4.
> 
> The Atom N2600 does not have SSE4, http://ark.intel.com/products/58916,
> and so I had trouble building rte_sched with optimized version of
> grinder_pipe_exists, with following:
> error: inlining failed in call to always_inline _mm_testz_si128’:
>        target specific option mismatch
> 
> GCC 4.9 correctly identifies my target as not having SSE4, and with
> provided patch builds the non-optimized version of grinder_pipe_exists.
> 
> 
> Signed-off-by: Mike Sowka <msowka@gmail.com>

Applied, thanks