From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45])
 by dpdk.org (Postfix) with ESMTP id 831909215
 for <dev@dpdk.org>; Sun,  6 Dec 2015 00:48:19 +0100 (CET)
Received: by wmec201 with SMTP id c201so108251452wme.1
 for <dev@dpdk.org>; Sat, 05 Dec 2015 15:48:19 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=6wind-com.20150623.gappssmtp.com; s=20150623;
 h=from:to:cc:subject:date:message-id:organization:user-agent
 :in-reply-to:references:mime-version:content-transfer-encoding
 :content-type; bh=8qIiJLAn8tg2aTqXZzmPrUNrZcjkAX7ZkQguTaFq+qA=;
 b=aYWhuSXcd3Gc6ppLQgFjXzZHkuafUq45i8rDJ5XSPez3acwwUB4/lseTIm6+ltiaTj
 +5LBwZm82aP2ek5zs1mpK0DCuVRF+0PmDua2xOuTXm+sU5cBJ59tbLW6HCqqadcEFpH3
 T9WlW2ZGQcuuSnFjeL78uNciuV94DTyrxL9B4a8IDZMLi41DQ2J8phWzyJdZ5EDtradB
 ARk24DwdMbPTQxXH8tK249/FBoF2AVPcqm+FuJeNn2NVMOS5hnnXRQtu74y/+n9avCv4
 PlMdy45MhCQHJj6bNkgpestF8d3iSiSJf2QotIkpH53cO/ZEmvpS3FSeoFIpQAHmMyxW
 2QzQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=8qIiJLAn8tg2aTqXZzmPrUNrZcjkAX7ZkQguTaFq+qA=;
 b=dS3GcrbNxaJBXNeratZgX2fWVqyNidJ0TNWm7kmxcwoHHWkP3hcSQR9RGtLO2H5q0c
 amXH9EmdDg+QWGtm9VF/yJNcpCaMs0MHWVL5P1ZDVz5w3h85aGWvPuP/ToFhYYFXUfOo
 4jEVXLDoyuXeJrQx+Sx/jl+UVZdgkiT/3/QiULh0s5wbr54x+uw9sD01/xPF5ESJMfai
 DZ3s0aAvVjJOLTWhSyqs5OFZ+86J/b2iRY25KARb1PzRlRdXQ/MmSolbdcs0DEECOxHH
 IyCZeb46ECvILziGKtG1zHG83Ii+LYfrbVkMYMXTAyHA/2mybHvs5tJ0L3jeoohBAPoR
 FMZA==
X-Gm-Message-State: ALoCoQnI5Vm/GU8Z3BvGg8fDQ1J2JWioDi7SR4qPDHWrATFScuWQF3vgHLYkhQFMbaow2DBzAq02
X-Received: by 10.194.109.234 with SMTP id hv10mr20242128wjb.10.1449359299384; 
 Sat, 05 Dec 2015 15:48:19 -0800 (PST)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by smtp.gmail.com with ESMTPSA id t2sm12707638wmt.1.2015.12.05.15.48.18
 (version=TLSv1/SSLv3 cipher=OTHER);
 Sat, 05 Dec 2015 15:48:18 -0800 (PST)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Mike Sowka <msowka@gmail.com>
Date: Sun, 06 Dec 2015 00:47:07 +0100
Message-ID: <2253941.LkXn5DGchi@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; )
In-Reply-To: <1449354476-8275-1-git-send-email-msowka@gmail.com>
References: <1449354476-8275-1-git-send-email-msowka@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] sched: fix build on Atom without SSE4 support
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sat, 05 Dec 2015 23:48:19 -0000

2015-12-05 17:27, Mike Sowka:
> Thanks for the pointers Thomas. Here is a signed-off patch
> re-submission with some explanation, to the best of my experience.

Thanks, it is really well detailed.
It would have been perfect with -v2 --in-reply-to :)

> Irrelevant of the target, the preprocessor #ifdef SSE2 for the
> grinder_pipe_exists function is inadequate since the __mm_testz_si128=

> function requires SSE4.1, PTEST instruction described in
> https://en.wikipedia.org/wiki/SSE4#SSE4.1 (I do no have better spec
> reference). I have bumped the preprocessor #ifdef to require SSE4.
>=20
> The Atom N2600 does not have SSE4, http://ark.intel.com/products/5891=
6,
> and so I had trouble building rte_sched with optimized version of
> grinder_pipe_exists, with following:
> error: inlining failed in call to always_inline _mm_testz_si128=E2=80=
=99:
>        target specific option mismatch
>=20
> GCC 4.9 correctly identifies my target as not having SSE4, and with
> provided patch builds the non-optimized version of grinder_pipe_exist=
s.
>=20
>=20
> Signed-off-by: Mike Sowka <msowka@gmail.com>

Applied, thanks