From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46]) by dpdk.org (Postfix) with ESMTP id 3871C8D96 for ; Tue, 10 Nov 2015 12:05:06 +0100 (CET) Received: by wmdw130 with SMTP id w130so65660039wmd.0 for ; Tue, 10 Nov 2015 03:05:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind_com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=2HIA2eFfJKo5rING+XayozacD75uzNkN2Nf7obBLUIE=; b=NSdkvfLLiG62Vo3zOXKaa0c9iW6/Hd3yesWMHygzahgl70cgH6ZT85+iqhYD2A/aV7 zw3S0fOerHKGcFPMCKR5s71KURg7b/h1tMXQrXZ4R3tMYq4TEEANesgXWi1qOI0U0UZS 1dssqC9qU5Fz1qRZWz3DL7Oi/5Vzynbvvb3yLOcYrbux22WW203IIxEIL7lRI8LvEU8d UzvH941lrSjefymen1myLRBw8VSLi1Gaa/PP8gMR2X4SR8KuMLOudGs1UIKEnrrPevFC bM/goTqpNwBOft7uiyFQrmGGvSaNCM3sF6kpakt4sf1Gq2WMDP4XNhK78RoZyQQaAKuz O2ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=2HIA2eFfJKo5rING+XayozacD75uzNkN2Nf7obBLUIE=; b=MCGZDuXYolGFJNe1V+1EgwLrjQlUESvIFBcEaNqd678BdCo/7sfEhQBLsrbXOPJuGI fD2eneVuH+jggJ9HWPgNF2jvy/b8t068Ur/xRg9bWUNRHAgxg4Y+jFb/R0fk3NQ2OwNa yPD7MWNFXfmeaNVRH6Rpb1Ba2aKigJHPBDhgDL507ku5n/to0TF8MHoYmHi5qJiv5yGs yfl38M4usUlGi5rL5JLCWrueIlgSx14kcuvqNp5uOQSwbGbNpjUiBPYhDcGVdQfOIo33 De3hZLNqc+tyTkUmC3uXKLidpJhNMBM1fQZJID+GQf3a9nzRpxw4TS36/TExzyulchDI KUtg== X-Gm-Message-State: ALoCoQmcjMGNFU3ZxgMkHS2aZmg8IrDc67ADdxFxS1yVcAOQr5PbfacrJj3OkKmifpkMH2tKpwow X-Received: by 10.28.73.11 with SMTP id w11mr6749991wma.44.1447153505988; Tue, 10 Nov 2015 03:05:05 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id an7sm2853102wjc.44.2015.11.10.03.05.04 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 10 Nov 2015 03:05:05 -0800 (PST) From: Thomas Monjalon To: Daniel Mrzyglod Date: Tue, 10 Nov 2015 12:03:54 +0100 Message-ID: <2257223.vnG0RKMETz@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1446732366-10044-2-git-send-email-danielx.t.mrzyglod@intel.com> References: <1443799208-9408-1-git-send-email-danielx.t.mrzyglod@intel.com> <1446732366-10044-1-git-send-email-danielx.t.mrzyglod@intel.com> <1446732366-10044-2-git-send-email-danielx.t.mrzyglod@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v5 1/7] ethdev: add additional ieee1588 support functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Nov 2015 11:05:06 -0000 Hi, Sorry for not having followed closer this series. It was submitted at the last minute and got too few comments. I'll try to fix it now to be sure it will be one of the first series ready for the 2.3 cycle. 2015-11-05 15:06, Daniel Mrzyglod: > --- a/doc/guides/rel_notes/release_2_2.rst > +++ b/doc/guides/rel_notes/release_2_2.rst > @@ -222,6 +222,9 @@ API Changes > > * The devargs union field virtual is renamed to virt for C++ compatibility. > > +* Add new functions in ethdev to support IEEE1588: rte_eth_timesync_time_adjust() > + rte_eth_timesync_time_get(), rte_eth_timesync_time_set() No need to add an entry in API changes for new functions. > +/** > + * Read the time from the timesync clock on an Ethernet device. > + * > + * @param port_id > + * The port identifier of the Ethernet device. > + * @param time > + * Pointer to the timespec struct. > + * > + * @return > + * - 0: Success. > + */ > +extern int rte_eth_timesync_time_get(uint8_t port_id, > + struct timespec *time); How is it different from rte_eth_timesync_read_rx_timestamp() and rte_eth_timesync_read_tx_timestamp()? Why repeating the word time? Why not rte_eth_timesync_get()? Not related to this patch, but in rte_eth_timesync_read_rx_timestamp(), the flags parameter breaks the API layer separation with drivers: * @param flags * Device specific flags. Used to pass the RX timesync register index to * i40e. Unused in igb/ixgbe, pass 0 instead.