From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id D8C57493D for ; Tue, 22 May 2018 16:38:08 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 1D90021A47; Tue, 22 May 2018 10:38:08 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 22 May 2018 10:38:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=iOAiLOkNJDEjPE/rkbViyP/Nft +EiOoaOn2KvBwJfTI=; b=fAzZaEin8NH3uR69Ecg1yRM5t+XwaQZ33+rdA1QOMm O4pCUpb7aXVYpqdUnZJD/pmXD+gUVW9MXMiWMzplBaUUCua9eSOirvcDVRTBcEsS pMoGjMj1nxGydN9PoLmYWsmqGVSrj2nC3FmS57Huio0PYwD+cFK/4Kf2aUksaJVj w= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=iOAiLO kNJDEjPE/rkbViyP/Nft+EiOoaOn2KvBwJfTI=; b=W7qFaJkWj0D9xBJhwq6IZy 1fWWKYQs7PA5YJCt07BNKUVvvTGjGKBGFsl+bCB07EVpZu2T/m7TDx50nEdS1yvv 4m0KlICQv4TAGlTOP9P64g+ANKGmlxBEHzwqWubHMHWIn5oG21H+7egQXSHYn3v8 hQ/JWvo3EfaGEqzeUX6k9ZKDcx9mlAsZGyJ+1R775I3a6tb6/pcMxGvF/wXhzqkH 2EINuZH7YgbhBKCYKj3Um/no9JOE7c3xjWq0m/PqOyGjtWWo1/1UvtFMoaUxavX0 rMduHT3jZ4Cs78c/4F6hLh/dLDTyifxnJmNF45binZzEsjDX1jWLYkqqAhxJw1JQ == X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 58A62E465C; Tue, 22 May 2018 10:38:07 -0400 (EDT) From: Thomas Monjalon To: dev@dpdk.org Cc: "Burakov, Anatoly" , matan@mellanox.com, ferruh.yigit@intel.com, gaetan.rivet@6wind.com Date: Tue, 22 May 2018 16:38:06 +0200 Message-ID: <2257563.PQC7AstAyf@xps> In-Reply-To: <8ac95032-f1e3-d762-2cf5-803ad78bb2bb@intel.com> References: <2833093.uzJjkH71XI@xps> <20180522113727.3116-1-thomas@monjalon.net> <8ac95032-f1e3-d762-2cf5-803ad78bb2bb@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3] bus/vdev: replace device list lock by a recursive one X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 May 2018 14:38:09 -0000 22/05/2018 15:34, Burakov, Anatoly: > On 22-May-18 12:37 PM, Thomas Monjalon wrote: > > A device like failsafe can manage sub-devices. > > When removing such device, it removes its sub-devices > > and try to take the same vdev_device_list_lock. > > It was causing a deadlock because the lock was not recursive. > > > > Fixes: 35f462839b69 ("bus/vdev: add lock on device list") > > > > Suggested-by: Anatoly Burakov > > Signed-off-by: Thomas Monjalon > > --- > > v3: try recursive lock > > WARNING: not yet tested! > > --- > > LGTM > > Acked-by: Anatoly Burakov Tested-by: Matan Azrad Applied