From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id A62CD1C00 for ; Fri, 12 May 2017 15:48:10 +0200 (CEST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 May 2017 06:48:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,330,1491289200"; d="scan'208";a="86783755" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.81]) ([10.237.220.81]) by orsmga004.jf.intel.com with ESMTP; 12 May 2017 06:48:08 -0700 To: Hemant Agrawal Cc: dev@dpdk.org, shreyansh.jain@nxp.com References: <1492607395-5922-1-git-send-email-hemant.agrawal@nxp.com> <1492607395-5922-4-git-send-email-hemant.agrawal@nxp.com> From: Ferruh Yigit Message-ID: <225e85a7-0caf-890b-210f-5ce8868f3a81@intel.com> Date: Fri, 12 May 2017 14:48:07 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: <1492607395-5922-4-git-send-email-hemant.agrawal@nxp.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 4/4] net/dpaa2: support parallel recv mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 May 2017 13:48:11 -0000 On 4/19/2017 2:09 PM, Hemant Agrawal wrote: > Typically when the PMD issues a RX command to DPAA2 hardware, > the hw writes the available descriptors into the given memory. > The RX function then processes the frames and prepare them as > mbufs. > > This patch adds support to issue another pull request to hardware > in another memory location, before we start processing the output > of the first request. This help in controlling the cpu cycles > wasted during the wait for the hardware to write the descriptors. > > During hw debugging, it may be desired to keep the original > mode, so the original mode is also preserved and can be controlled > with an env flag. > > Signed-off-by: Hemant Agrawal <...> > > + /*If no prefetch is configured. */ > + if (getenv("DPAA2_RX_NO_PREFETCH")) { Instead of getting configuration option from environment variable, can you please make it argument to the driver? This will be more consistent to the DPDK usage. > + eth_dev->rx_pkt_burst = dpaa2_dev_rx; > + PMD_INIT_LOG(INFO, "No Prefetch enabled"); > + } > + <...>