From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Rasesh Mody <rasesh.mody@cavium.com>,
Harish Patil <harish.patil@cavium.com>
Cc: Bruce Richardson <bruce.richardson@intel.com>,
Thomas Monjalon <thomas.monjalon@6wind.com>, DPDK <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v7 1/7] qede: add base driver
Date: Tue, 28 Mar 2017 12:16:14 +0100 [thread overview]
Message-ID: <225ecab3-f6af-afaa-ec13-4f53d3f3b566@intel.com> (raw)
In-Reply-To: <1461766722-7745-2-git-send-email-rasesh.mody@qlogic.com>
On 4/27/2016 3:18 PM, rasesh.mody at qlogic.com (Rasesh Mody) wrote:
> The base driver is the backend module for the QLogic FastLinQ QL4xxxx
> 25G/40G CNA family of adapters as well as their virtual functions (VF)
> in SR-IOV context.
>
> The purpose of the base module is to:
> - provide all the common code that will be shared between the various
> drivers that would be used with said line of products. Flows such as
> chip initialization and de-initialization fall under this category.
> - abstract the protocol-specific HW & FW components, allowing the
> protocol drivers to have clean APIs, which are detached in its
> slowpath configuration from the actual Hardware Software Interface(HSI).
>
> This patch adds a base module without any protocol-specific bits.
> I.e., this adds a basic implementation that almost entirely falls under
> the first category.
>
> Signed-off-by: Harish Patil <harish.patil at qlogic.com>
> Signed-off-by: Rasesh Mody <rasesh.mody at qlogic.com>
> Signed-off-by: Sony Chacko <sony.chacko at qlogic.com>
<...>
> diff --git a/drivers/net/qede/Makefile b/drivers/net/qede/Makefile
> new file mode 100644
> index 0000000..febd41d
> --- /dev/null
> +++ b/drivers/net/qede/Makefile
> @@ -0,0 +1,81 @@
<...>
> +
> +#
> +# Add extra flags for base ecore driver files
> +# to disable warnings in them
> +#
> +#
> +BASE_DRIVER_OBJS=$(patsubst %.c,%.o,$(notdir $(wildcard $(SRCDIR)/base/*.c)))
> +$(foreach obj, $(BASE_DRIVER_OBJS), $(eval CFLAGS+=$(CFLAGS_BASE_DRIVER)))
My eyes just caught this one, above line adds $(CFLAGS_BASE_DRIVER) many
times to $(CFLAGS), but real intentions is add to obj specific CFLAGS
and only being limited to base files.
Like:
$(foreach obj, $(BASE_DRIVER_OBJS), $(eval
CFLAGS_$(obj)+=$(CFLAGS_BASE_DRIVER)))
Can you please fix this?
Fixing this may give some build errors on non-base driver files,
although not sure.
Thanks,
ferruh
> +
> +#
> +# all source are stored in SRCS-y
> +#
> +SRCS-$(CONFIG_RTE_LIBRTE_QEDE_PMD) += base/ecore_dev.c
> +SRCS-$(CONFIG_RTE_LIBRTE_QEDE_PMD) += base/ecore_hw.c
> +SRCS-$(CONFIG_RTE_LIBRTE_QEDE_PMD) += base/ecore_cxt.c
> +SRCS-$(CONFIG_RTE_LIBRTE_QEDE_PMD) += base/ecore_sp_commands.c
> +SRCS-$(CONFIG_RTE_LIBRTE_QEDE_PMD) += base/ecore_init_fw_funcs.c
> +SRCS-$(CONFIG_RTE_LIBRTE_QEDE_PMD) += base/ecore_spq.c
> +SRCS-$(CONFIG_RTE_LIBRTE_QEDE_PMD) += base/ecore_init_ops.c
> +SRCS-$(CONFIG_RTE_LIBRTE_QEDE_PMD) += base/ecore_mcp.c
> +SRCS-$(CONFIG_RTE_LIBRTE_QEDE_PMD) += base/ecore_int.c
> +SRCS-$(CONFIG_RTE_LIBRTE_QEDE_PMD) += base/bcm_osal.c
> +
> +# dependent libs:
> +DEPDIRS-$(CONFIG_RTE_LIBRTE_QEDE_PMD) += lib/librte_eal lib/librte_ether
> +DEPDIRS-$(CONFIG_RTE_LIBRTE_QEDE_PMD) += lib/librte_mempool lib/librte_mbuf
> +DEPDIRS-$(CONFIG_RTE_LIBRTE_QEDE_PMD) += lib/librte_net lib/librte_malloc
> +
> +include $(RTE_SDK)/mk/rte.lib.mk
<...>
next prev parent reply other threads:[~2017-03-28 11:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-27 14:18 [dpdk-dev] [PATCH v7 0/7] qede: add qede PMD Rasesh Mody
2016-04-27 14:18 ` [dpdk-dev] [PATCH v7 1/7] qede: add base driver Rasesh Mody
2017-03-28 11:16 ` Ferruh Yigit [this message]
2017-03-28 21:04 ` Mody, Rasesh
2017-04-19 15:19 ` Ferruh Yigit
2017-04-19 15:44 ` Patil, Harish
2016-04-27 14:18 ` [dpdk-dev] [PATCH v7 2/7] qede: add core driver Rasesh Mody
2016-04-27 14:18 ` [dpdk-dev] [PATCH v7 3/7] qede: enable PMD build Rasesh Mody
2016-04-27 14:18 ` [dpdk-dev] [PATCH v7 4/7] qede: add L2 support Rasesh Mody
2016-04-27 14:18 ` [dpdk-dev] [PATCH v7 5/7] qede: add SRIOV support Rasesh Mody
2016-04-27 14:18 ` [dpdk-dev] [PATCH v7 6/7] qede: add interrupt handling support Rasesh Mody
2016-04-27 14:18 ` [dpdk-dev] [PATCH v7 7/7] qede: add DCBX support Rasesh Mody
2016-04-27 16:05 ` [dpdk-dev] [PATCH v7 0/7] qede: add qede PMD Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=225ecab3-f6af-afaa-ec13-4f53d3f3b566@intel.com \
--to=ferruh.yigit@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=harish.patil@cavium.com \
--cc=rasesh.mody@cavium.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).