From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id BE4E6101B for ; Tue, 28 Mar 2017 13:16:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1490699777; x=1522235777; h=subject:references:to:cc:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=HzxDDpc/Mm7JO6l85bdElRmDsxKRSakCz+HO4/SjdJQ=; b=HN4nN+UfyW+Tu2eyc9Nt8GfqDc8SXkmyMnR3sKxhhyTLMRRC/F+AT68O Ig5OG7ywsh/hn8FBpStgbL7r7Z0TKQ==; Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Mar 2017 04:16:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,236,1486454400"; d="scan'208";a="839256058" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.122]) ([10.237.220.122]) by FMSMGA003.fm.intel.com with ESMTP; 28 Mar 2017 04:16:15 -0700 References: <1461766722-7745-1-git-send-email-rasesh.mody@qlogic.com> <1461766722-7745-2-git-send-email-rasesh.mody@qlogic.com> To: Rasesh Mody , Harish Patil Cc: Bruce Richardson , Thomas Monjalon , DPDK From: Ferruh Yigit Message-ID: <225ecab3-f6af-afaa-ec13-4f53d3f3b566@intel.com> Date: Tue, 28 Mar 2017 12:16:14 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <1461766722-7745-2-git-send-email-rasesh.mody@qlogic.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v7 1/7] qede: add base driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Mar 2017 11:16:18 -0000 On 4/27/2016 3:18 PM, rasesh.mody at qlogic.com (Rasesh Mody) wrote: > The base driver is the backend module for the QLogic FastLinQ QL4xxxx > 25G/40G CNA family of adapters as well as their virtual functions (VF) > in SR-IOV context. > > The purpose of the base module is to: > - provide all the common code that will be shared between the various > drivers that would be used with said line of products. Flows such as > chip initialization and de-initialization fall under this category. > - abstract the protocol-specific HW & FW components, allowing the > protocol drivers to have clean APIs, which are detached in its > slowpath configuration from the actual Hardware Software Interface(HSI). > > This patch adds a base module without any protocol-specific bits. > I.e., this adds a basic implementation that almost entirely falls under > the first category. > > Signed-off-by: Harish Patil > Signed-off-by: Rasesh Mody > Signed-off-by: Sony Chacko <...> > diff --git a/drivers/net/qede/Makefile b/drivers/net/qede/Makefile > new file mode 100644 > index 0000000..febd41d > --- /dev/null > +++ b/drivers/net/qede/Makefile > @@ -0,0 +1,81 @@ <...> > + > +# > +# Add extra flags for base ecore driver files > +# to disable warnings in them > +# > +# > +BASE_DRIVER_OBJS=$(patsubst %.c,%.o,$(notdir $(wildcard $(SRCDIR)/base/*.c))) > +$(foreach obj, $(BASE_DRIVER_OBJS), $(eval CFLAGS+=$(CFLAGS_BASE_DRIVER))) My eyes just caught this one, above line adds $(CFLAGS_BASE_DRIVER) many times to $(CFLAGS), but real intentions is add to obj specific CFLAGS and only being limited to base files. Like: $(foreach obj, $(BASE_DRIVER_OBJS), $(eval CFLAGS_$(obj)+=$(CFLAGS_BASE_DRIVER))) Can you please fix this? Fixing this may give some build errors on non-base driver files, although not sure. Thanks, ferruh > + > +# > +# all source are stored in SRCS-y > +# > +SRCS-$(CONFIG_RTE_LIBRTE_QEDE_PMD) += base/ecore_dev.c > +SRCS-$(CONFIG_RTE_LIBRTE_QEDE_PMD) += base/ecore_hw.c > +SRCS-$(CONFIG_RTE_LIBRTE_QEDE_PMD) += base/ecore_cxt.c > +SRCS-$(CONFIG_RTE_LIBRTE_QEDE_PMD) += base/ecore_sp_commands.c > +SRCS-$(CONFIG_RTE_LIBRTE_QEDE_PMD) += base/ecore_init_fw_funcs.c > +SRCS-$(CONFIG_RTE_LIBRTE_QEDE_PMD) += base/ecore_spq.c > +SRCS-$(CONFIG_RTE_LIBRTE_QEDE_PMD) += base/ecore_init_ops.c > +SRCS-$(CONFIG_RTE_LIBRTE_QEDE_PMD) += base/ecore_mcp.c > +SRCS-$(CONFIG_RTE_LIBRTE_QEDE_PMD) += base/ecore_int.c > +SRCS-$(CONFIG_RTE_LIBRTE_QEDE_PMD) += base/bcm_osal.c > + > +# dependent libs: > +DEPDIRS-$(CONFIG_RTE_LIBRTE_QEDE_PMD) += lib/librte_eal lib/librte_ether > +DEPDIRS-$(CONFIG_RTE_LIBRTE_QEDE_PMD) += lib/librte_mempool lib/librte_mbuf > +DEPDIRS-$(CONFIG_RTE_LIBRTE_QEDE_PMD) += lib/librte_net lib/librte_malloc > + > +include $(RTE_SDK)/mk/rte.lib.mk <...>