From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0054.outbound.protection.outlook.com [104.47.0.54]) by dpdk.org (Postfix) with ESMTP id 2A59B1B2D9 for ; Tue, 3 Oct 2017 08:53:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=dzgLVY5R+Vhov0hr5yvY/g/YX6/rKD++peJAQmUKunc=; b=a+Aa9Bi73xk9/xbHaBu0gRuLyiy8OU72+x8Chi0sW5yqclBN631fLhN1jJipOyjCwQi8dZnJt8MCVGahV7CiHAUzOUozyy0bC+jX3Nj665Yr5du4TpZefnXTss2Tez7SFM9BMEPZcrUFlqshXf+DxlZRZOg+UI9WkvZMJESDfbc= Received: from VI1PR0501MB2045.eurprd05.prod.outlook.com (10.167.195.147) by VI1PR05MB3149.eurprd05.prod.outlook.com (10.170.237.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Tue, 3 Oct 2017 06:53:33 +0000 Received: from VI1PR0501MB2045.eurprd05.prod.outlook.com ([fe80::84ed:9505:3e7f:9722]) by VI1PR0501MB2045.eurprd05.prod.outlook.com ([fe80::84ed:9505:3e7f:9722%13]) with mapi id 15.20.0077.018; Tue, 3 Oct 2017 06:53:32 +0000 From: Yongseok Koh To: Andrew Rybchenko CC: Raslan Darawsheh , "dev@dpdk.org" , Shahaf Shuler , "ferruh.yigit@intel.com" Thread-Topic: [dpdk-dev] [PATCH v5 1/3] ethdev: add Rx HW timestamp capability Thread-Index: AQHTPBGcI3LQ2VKl5UKDcH+d14nPyKLRrOCAgAADooA= Date: Tue, 3 Oct 2017 06:53:32 +0000 Message-ID: <2260C792-E8AD-4CDE-81E5-7B607ECA9FE5@mellanox.com> References: <1506617303-32509-1-git-send-email-rasland@mellanox.com> <1507012430-8421-1-git-send-email-rasland@mellanox.com> <18261cc6-ada3-59de-c200-91ea80dcf7fd@solarflare.com> In-Reply-To: <18261cc6-ada3-59de-c200-91ea80dcf7fd@solarflare.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; x-originating-ip: [73.222.116.174] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR05MB3149; 6:WED5YwVHKE/6R7WOyN6NgvKtQ4UpMAfUeNaCb7xlRzFd6l6QhdM/1NIa2tIbgXJBDTTK4UmarCtXGd9NoUu98rFqZxhziif/lsfIoCRzzOz1e4gq9Lnfi+xEGCTdiKPLR/c088iDRX+CTnW9M3T4Tl1126cnbXSt0chYUtWjvzzoIFWI92K/eWy4NOpdgWexeCLizZvbo9EhmCnOk3lvp3auv494ui+QbOvmFNbB3gqmDoEgjK1ja3D19OJtV3dHfqKPc3VLF35JOMxRAR3fQGcpmAsjXhL2VTgxEZV31ulclzycIUfStygL6PIKZV3jPh+SKk+6z7H2c7sa8FajIQ==; 5:UtV6H/yd8nhh+sVK6TDcV694dKdTi7YZPy+IFnEij9zYDy7LkdSdeVVjEN9EHYetx7SIMnJh/EqcReUfH37YKqbtcmKouBrH0ZOT8ASwxyYmToOZ7Umgsa78v7t56Mik0WzuYCexlUqQklHz2hnIag==; 24:JKVR8yFgfyHUhK3pwMlhkpIT4d/4+F0An3enEs++OeXo0rpU87+o7UDON2AflKzVDtFNVuiQpaQq9vvnRoJGsmPX5O2yiofUyge7ljsqGLY=; 7:W5jJdwip+S57pEEbjdFEfmCTz88xyZrxsxhraH7NfSHXd9BkSYzznaCmzQA0/mhHsxp+j3Z6ueKkqb+PuQgSg3c9hD/o+Fn5sQjSVDk6lEHeLWqqFA1cznYgvAqm5Rgqpu65RbyRfh3zYwK+JqvGuBcqOM+t3HJFMUxTX2Nx0ek8Hdx25/CVpWbV1sbialu3D1FGwWeZ9HdD8GrIEnLQI5atu6ayz36e/N2l/wwOefw= x-ms-exchange-antispam-srfa-diagnostics: SSOS;SSOR; x-ms-office365-filtering-correlation-id: 001058d0-5ca6-4838-fd26-08d50a2b7669 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254152)(48565401081)(2017052603199)(201703131423075)(201703031133081)(201702281549075); SRVR:VI1PR05MB3149; x-ms-traffictypediagnostic: VI1PR05MB3149: x-exchange-antispam-report-test: UriScan:; x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(93006095)(93001095)(100000703101)(100105400095)(10201501046)(3002001)(6055026)(6041248)(20161123558100)(20161123560025)(20161123564025)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:VI1PR05MB3149; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:VI1PR05MB3149; x-forefront-prvs: 044968D9E1 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(376002)(346002)(39860400002)(189002)(24454002)(377454003)(199003)(106356001)(99286003)(189998001)(316002)(14454004)(33656002)(305945005)(53546010)(8676002)(66066001)(25786009)(6246003)(81166006)(53936002)(4326008)(105586002)(8936002)(54906003)(81156014)(53376002)(7736002)(6306002)(86362001)(6512007)(102836003)(3280700002)(3660700001)(82746002)(6916009)(2950100002)(966005)(83716003)(2900100001)(3846002)(97736004)(6116002)(36756003)(5250100002)(5660300001)(68736007)(6436002)(6486002)(229853002)(6506006)(101416001)(76176999)(54356999)(50986999)(2906002)(478600001); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR05MB3149; H:VI1PR0501MB2045.eurprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Oct 2017 06:53:32.7915 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB3149 Subject: Re: [dpdk-dev] [PATCH v5 1/3] ethdev: add Rx HW timestamp capability X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Oct 2017 06:53:35 -0000 > On Oct 2, 2017, at 11:40 PM, Andrew Rybchenko = wrote: >=20 > On 10/03/2017 09:33 AM, Raslan Darawsheh wrote: >> Add a new offload capability flag for Rx HW >> timestamp and enabling/disabling this via rte_eth_rxmode. >>=20 >> Signed-off-by: Raslan Darawsheh=20 >> >>=20 >> --- >> This patch should be applied after after this series: >>=20 >> http://dpdk.org/dev/patchwork/patch/29368/ >>=20 >> --- >> doc/guides/nics/features.rst | 11 +++++++++++ >> lib/librte_ether/rte_ethdev.c | 6 ++++++ >> lib/librte_ether/rte_ethdev.h | 5 ++++- >> 3 files changed, 21 insertions(+), 1 deletion(-) >>=20 >=20 > <...> >=20 >> diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev= .h >> index ffd2ee5..bd63730 100644 >> --- a/lib/librte_ether/rte_ethdev.h >> +++ b/lib/librte_ether/rte_ethdev.h >> @@ -368,7 +368,8 @@ struct rte_eth_rxmode { >> jumbo_frame : 1, /**< Jumbo Frame Receipt enable. */ >> hw_strip_crc : 1, /**< Enable CRC stripping by hardware. */ >> enable_scatter : 1, /**< Enable scatter packets rx handler */ >> - enable_lro : 1; /**< Enable LRO */ >> + enable_lro : 1, /**< Enable LRO */ >> + hw_timestamp : 1; /**< Enable HW timestamp */ >>=20 >=20 > The code is definitely not rebased on top of a new Rx offload API patch w= hich adds > ignore_offload_bitfield : 1; > exactly in this place. Hi Andrew, Did you check Shahaf's email regarding this? Looks like Shahaf suggests kee= ping it as is for now. > On Sep 30, 2017, at 11:44 PM, Shahaf Shuler wrote: > >[1] http://dpdk.org/ml/archives/dev/2017-September/076872.html > =20 > I agree it should be on top of [1]. > Unfortunately since the PMDs will move to the new API only on 18.02, and = in the current state Rx offloads are disabled by default, there will be no = way to enable this feature without a dedicated bit. > =20 > So my suggestion is to keep the timestamp bit on rxmode, and to update th= e convert function introduced on [1]. This bit will be removed along with t= he entire bit-field array once the old offloads API will be deprecated. Thanks, Yongseok