From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id D9952FFA for ; Sun, 8 Oct 2017 18:43:48 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 692632083A; Sun, 8 Oct 2017 12:43:48 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Sun, 08 Oct 2017 12:43:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=to0K3XBFbA5BnGs LYfvBh7gJXwUFsIDtIKqV74sRR1o=; b=HQnktMRNAOfZGjyrb7XxySR6UKRAbOt IevdRypFP7YRfw/FS4/pEzmQqJPnMbuyigWvS0o5TR4H1cKQdqNcQlKpoRFl3WWZ R8U8ZfhgwRnl4eONFeOjtun97Zi7aho7mSMVa4QYTw6LfZUbSszeeu13sG9/w9Rw dchJ5ydSZLuY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=to0K3XBFbA5BnGsLYfvBh7gJXwUFsIDtIKqV74sRR1o=; b=BB+cTYhG dpfU7J0bi1DrAVJAFLQo163XXaaWyHRYsNvAwQ6iFkh9RweZW/opqDRhn6iE1Qmm kxe8xrZiO7Iv4d9FoOsZobxSl6bMeQ0ZZnURXGyMzxbzWeFPMyL/cQ+JsNX3vsxk la7b6O9abpNm/bVRuxM6orRIGSzCvhVetG7CAWt6pxwpaD0AoDSdweEVWxYYfoqA z3Abye1nsTeMBbjnX6XAtnKWW5gpsGy0u67mPhw5alCshnCYiucQ3tVwnLJvnwZc NvSS0fPDjTIIgYvCyd8sJBzIZSo+Y1ulHJEd56qfKVC7GZ91JagRBHilyKMuH9rV Gc2368jUqdMl6A== X-ME-Sender: X-Sasl-enc: kYHBr8LRX47HplVxurblou1L1wf/P6XbaFpYD0xTdkrO 1507481028 Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 1891A7E3E1; Sun, 8 Oct 2017 12:43:48 -0400 (EDT) From: Thomas Monjalon To: Santosh Shukla Cc: dev@dpdk.org, olivier.matz@6wind.com, jerin.jacob@caviumnetworks.com, hemant.agrawal@nxp.com, John McNamara , ferruh.yigit@intel.com Date: Sun, 08 Oct 2017 18:43:47 +0200 Message-ID: <2261239.kuHBKoApgZ@xps> In-Reply-To: <20171008124011.1577-11-santosh.shukla@caviumnetworks.com> References: <20170831063719.19273-1-santosh.shukla@caviumnetworks.com> <20171008124011.1577-1-santosh.shukla@caviumnetworks.com> <20171008124011.1577-11-santosh.shukla@caviumnetworks.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 10/10] doc: add mempool and octeontx mempool device X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Oct 2017 16:43:49 -0000 08/10/2017 14:40, Santosh Shukla: > This commit adds a section to the docs listing the mempool > device PMDs available. It is confusing to add a mempool guide, given that we already have a mempool section in the programmer's guide: http://dpdk.org/doc/guides/prog_guide/mempool_lib.html And we will probably need also some doc for bus drivers. I think it would be more interesting to create a platform guide where you can describe the bus and the mempool. OK for doc/guides/platform/octeontx.rst ? I choose to integrate this series without this last patch. I mark this patch as rejected. Please submit a new one separately. > It then adds the octeontx fpavf mempool PMD to the listed mempool > devices. > > Cc: John McNamara > > Signed-off-by: Santosh Shukla > Signed-off-by: Jerin Jacob > Reviewed-by: John McNamara > --- [...] > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -340,6 +340,13 @@ F: drivers/net/liquidio/ > F: doc/guides/nics/liquidio.rst > F: doc/guides/nics/features/liquidio.ini > > +Cavium Octeontx Mempool > +M: Santosh Shukla > +M: Jerin Jacob > +F: drivers/mempool/octeontx A slash is missing at the end of the directory. Until now, the mempool and bus drivers are listed with net drivers. We could move them in a platform section later. For now, let's put it as "Cavium OcteonTX" in net drivers. I fixed and merged it with the first patch. > +F: doc/guides/mempool/index.rst The index must not be part of Octeontx section. > +F: doc/guides/mempool/octeontx.rst