From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C7FEE42DE7; Thu, 6 Jul 2023 12:45:36 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9D699410FA; Thu, 6 Jul 2023 12:45:36 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id 95BD940A79 for <dev@dpdk.org>; Thu, 6 Jul 2023 12:45:34 +0200 (CEST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 3CAC45C0156; Thu, 6 Jul 2023 06:45:33 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Thu, 06 Jul 2023 06:45:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1688640333; x=1688726733; bh=lc18h2bCBRBokDIfgupErAa5HeOORk5N5oV pGTd+i3Y=; b=gEkpelOdGf6cJwk3/1mZVrOu6scN/ctkVLFp0U35EC5CZY4iW4j FLBzL0k6bMjaA6NaCkdndATPg0ASsWZIvw1DYLTiK1YIj3NVKtvO/J1c2upHncsw KOwrM32pWDBmUVOIK2ccoclo9j/MjzwMnHxY3TtoEb5Nv7ADU72k7cithOiHsT/8 9lQ5vVZjIM/4uMsxIyiITymiWAL8FXgRDmI6EgB3Aph97Fd7oEsWDUjYaEYhhXmv bel1VWJXYwLIL40aqpRCyF7cp6Qex/IUabDo+tYIJ7pWRefHNvbkcXo5klkNLdWR w6AldtDKapRGDO8qxX32Qxmjbcc2B6bH1Lg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1688640333; x=1688726733; bh=lc18h2bCBRBokDIfgupErAa5HeOORk5N5oV pGTd+i3Y=; b=JH6T8Xa3QDqEK0UkfRCR23OyARHadLfMbqrUDbH/YzZuLKc8Sel QgZ/ILG3nl/45nJjdxwaSlLtrzhOV8LTkyhE2//iDAQpSunLJmRdZTNqmVexWbeO dI7kVfp9ykSPL5Ixm9hYsC20m2r8YVNC/0AM8i69zgGk9ZbvzwAi7JYNe909ZbVh SO4PfOHyB3KxE78E2JshDFzhdtg0DogdvJATvg7phvjYgYggNQCyaSfhQfKr7Owl laox35LM1jRsvB+PE3SNoZ9iERMAeeKLoHyFcf/h/LpSkX3w0h9VjuZ3yj/A8//u 2ZPYPO6QZCds8odnFy89L4blbSRzszT+wjg== X-ME-Sender: <xms:TJumZFQcdOAdhNSi9jNRh4oqgWBsV-eV6KUHV-ez2V7tBhOSbX4OzQ> <xme:TJumZOyjSSAc5IUmP8kxX04AQ8X_hhqYAylCOvNBr-HjiNyhksWhR61oTZroNYbyq wk9Bn6l3MVrlsC5QQ> X-ME-Received: <xmr:TJumZK0rkaV1y0WESAzKT7ue4K3FeoBNassvfjB8xzMLUUhdhTgmVq7lxuBG2axCNVmDVQpQPmZsF1URvFIWDstJRA> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrudelgdefudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddtieek gfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: <xmx:TJumZNBybHoX0ZZu9yjauvpCZOLViNtv4VfudxH9iB7NMseSIPn-XA> <xmx:TJumZOiGVwOBOcg5oB25Ben07B_Vw0y7i1J3nHKCDs0BpH69uUgtVA> <xmx:TJumZBp9Px6O4ibg79K6CRB8bONFBR3wjv5sUCGPNEivskj1Vg7Nnw> <xmx:TZumZPurTHW7r7lfXyJNkFKN6Fh2eSSBmYkT18LNv8rprbhPZetctw> Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 6 Jul 2023 06:45:31 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: Stephen Hemminger <stephen@networkplumber.org>, usman.tanveer@emumba.com Cc: reshma.pattan@intel.com, dev@dpdk.org, fengchengwen <fengchengwen@huawei.com> Subject: Re: [PATCH v2] app/pdump: exit if no device specified Date: Thu, 06 Jul 2023 12:45:29 +0200 Message-ID: <22624366.EfDdHjke4D@thomas> In-Reply-To: <d096a9f6-03bc-1139-5564-69e12ce8ce3b@huawei.com> References: <20220302092614.5164-1-usman.tanveer@emumba.com> <20230701021611.8269-1-stephen@networkplumber.org> <d096a9f6-03bc-1139-5564-69e12ce8ce3b@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org 03/07/2023 08:29, fengchengwen: > Acked-by: Chengwen Feng <fengchengwen@huawei.com> > > On 2023/7/1 10:16, Stephen Hemminger wrote: > > Simpler version of earlier patch which had a good idea, was just > > implemented with more code than necessary. > > If no device is specified don't start the capture loop. > > > > Reported-by: usman.tanveer <usman.tanveer@emumba.com> > > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org> Applied, thanks.