DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Konstantin Ananyev <konstantin.ananyev@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 1/4] acl: Add ACL library (librte_acl) into DPDK.
Date: Wed, 28 May 2014 00:21:33 +0200	[thread overview]
Message-ID: <2262681.BL9UtmWIVt@xps13> (raw)
In-Reply-To: <1400791734-24479-2-git-send-email-konstantin.ananyev@intel.com>

Hi Konstantin,

Glad to see this new library coming in.

2014-05-22 21:48, Konstantin Ananyev:
> The ACL library is used to perform an N-tuple search over a set of rules
> with multiple categories and find the best match for each category.
> 
> Signed-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> ---
>  config/common_linuxapp               |    6 +
>  lib/librte_acl/Makefile              |   60 +
>  lib/librte_acl/acl.h                 |  182 +++
>  lib/librte_acl/acl_bld.c             | 2002 ++++++++++++++++++++++++++++++++++
>  lib/librte_acl/acl_gen.c             |  473 ++++++++
>  lib/librte_acl/acl_run.c             |  927 ++++++++++++++++
>  lib/librte_acl/acl_vect.h            |  129 +++
>  lib/librte_acl/rte_acl.c             |  413 +++++++
>  lib/librte_acl/rte_acl.h             |  453 ++++++++
>  lib/librte_acl/rte_acl_osdep.h       |   92 ++
>  lib/librte_acl/rte_acl_osdep_alone.h |  277 +++++
>  lib/librte_acl/tb_mem.c              |  102 ++
>  lib/librte_acl/tb_mem.h              |   73 ++
>  13 files changed, 5189 insertions(+), 0 deletions(-)

As you are introducing a new library, you need to update
doxygen configuration and start page:
	doc/doxy-api.conf
	doc/doxy-api-index.md

I've run checkpatch.pl from kernel.org on these ACL patches
and it reports a lot of code style issues.
Could you have a look at it please?

Thanks
-- 
Thomas

  reply	other threads:[~2014-05-27 22:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-22 20:48 [dpdk-dev] [PATCH 0/4] ACL library Konstantin Ananyev
2014-05-22 20:48 ` [dpdk-dev] [PATCH 1/4] acl: Add ACL library (librte_acl) into DPDK Konstantin Ananyev
2014-05-27 22:21   ` Thomas Monjalon [this message]
2014-05-22 20:48 ` [dpdk-dev] [PATCH 2/4] acl: update UT to reflect latest changes in the librte_acl Konstantin Ananyev
2014-05-22 20:48 ` [dpdk-dev] [PATCH 3/4] acl: New test-acl application Konstantin Ananyev
2014-05-22 20:48 ` [dpdk-dev] [PATCH 4/4] acl: New sample l3fwd-acl Konstantin Ananyev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2262681.BL9UtmWIVt@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=dev@dpdk.org \
    --cc=konstantin.ananyev@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).