From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f176.google.com (mail-wi0-f176.google.com [209.85.212.176]) by dpdk.org (Postfix) with ESMTP id 389605932 for ; Wed, 28 May 2014 00:21:27 +0200 (CEST) Received: by mail-wi0-f176.google.com with SMTP id n15so2669949wiw.3 for ; Tue, 27 May 2014 15:21:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=fbHCqow5Ii9lNGIDz3omKzdSw/fYruBKxjJFsMn6WP4=; b=Ay6GQ2RLCh70ph4qElUFEtm6Wku/8MPKJHtwshjVvsqKbvEzTNg7MN6fDNeNL2w4fD 0l36VmAkqrIKefnqohc1kktNnU6Aq3p1HOo4U2wXWp4N8WFEP8/TDFIZ8FdVyFII9hqk PAm1iYvJMjO8fgN86pS8BBWvTxNNKWsQ9i6TVO1iNB1KdOSlcS0cu7fECYx3kbIDAYdh S/N+/V95Fw9a+Bj9bTfxVRQ24reJ6Ks0rT0B3wW4Qep4NuuJB95TzsMB/Xtj/fOr34qE R1GubTMEIxx7e6nIa2X8Ty9b2R+MSF8ZuYDO8o7tQxhS6dZxD+RORE/jEuicdfgT30bM Zvpg== X-Gm-Message-State: ALoCoQn0sGvk+YfxnrnN6E56qXNnLq51svRED3XlrXbCYHAAh2bL0zK7JALvnLRuskFxSfn3l+HA X-Received: by 10.180.11.9 with SMTP id m9mr42470783wib.51.1401229298086; Tue, 27 May 2014 15:21:38 -0700 (PDT) Received: from xps13.localnet (ip-96.net-80-236-123.rev.numericable.fr. [80.236.123.96]) by mx.google.com with ESMTPSA id p15sm8165155wiv.8.2014.05.27.15.21.36 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 27 May 2014 15:21:37 -0700 (PDT) From: Thomas Monjalon To: Konstantin Ananyev Date: Wed, 28 May 2014 00:21:33 +0200 Message-ID: <2262681.BL9UtmWIVt@xps13> Organization: 6WIND User-Agent: KMail/4.13 (Linux/3.14.4-1-ARCH; KDE/4.13.0; x86_64; ; ) In-Reply-To: <1400791734-24479-2-git-send-email-konstantin.ananyev@intel.com> References: <1400791734-24479-1-git-send-email-konstantin.ananyev@intel.com> <1400791734-24479-2-git-send-email-konstantin.ananyev@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 1/4] acl: Add ACL library (librte_acl) into DPDK. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 May 2014 22:21:27 -0000 Hi Konstantin, Glad to see this new library coming in. 2014-05-22 21:48, Konstantin Ananyev: > The ACL library is used to perform an N-tuple search over a set of rules > with multiple categories and find the best match for each category. > > Signed-off-by: Konstantin Ananyev > --- > config/common_linuxapp | 6 + > lib/librte_acl/Makefile | 60 + > lib/librte_acl/acl.h | 182 +++ > lib/librte_acl/acl_bld.c | 2002 ++++++++++++++++++++++++++++++++++ > lib/librte_acl/acl_gen.c | 473 ++++++++ > lib/librte_acl/acl_run.c | 927 ++++++++++++++++ > lib/librte_acl/acl_vect.h | 129 +++ > lib/librte_acl/rte_acl.c | 413 +++++++ > lib/librte_acl/rte_acl.h | 453 ++++++++ > lib/librte_acl/rte_acl_osdep.h | 92 ++ > lib/librte_acl/rte_acl_osdep_alone.h | 277 +++++ > lib/librte_acl/tb_mem.c | 102 ++ > lib/librte_acl/tb_mem.h | 73 ++ > 13 files changed, 5189 insertions(+), 0 deletions(-) As you are introducing a new library, you need to update doxygen configuration and start page: doc/doxy-api.conf doc/doxy-api-index.md I've run checkpatch.pl from kernel.org on these ACL patches and it reports a lot of code style issues. Could you have a look at it please? Thanks -- Thomas