From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f182.google.com (mail-wi0-f182.google.com [209.85.212.182]) by dpdk.org (Postfix) with ESMTP id 47F6B7DFC for ; Tue, 28 Oct 2014 14:36:05 +0100 (CET) Received: by mail-wi0-f182.google.com with SMTP id d1so1633123wiv.9 for ; Tue, 28 Oct 2014 06:44:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=4ZLxje8l4a+uye6pK6uCABCck4/5ybhDZHfWLfL8u6Y=; b=QQrIHJ/gM2f4vfeY55Pkq1X7kSEmXt//gKMjzfEHTZAeSDtJ4I0A7KzLq0bn9l8NQ5 lZy1d2WaO3lHuxwptCCvGiI+pFaIUDSFPFZiP/dSqBMlXTg65FXGFtoTA9SGddItjI7V sGGgcnHiXoUbnwyxVArIz9DZfDtUwcMqcoS2K5/6sR1UZaiJoUM55v1rSasuB0Jh38dq WisQmjpgahC63UHo47iyjDujvsJN4eEetchmIancSPUbUUhNJwByPKkiH6FsnDLa4yVA 89FSeqZ8ZNnSzayqVxbnZn/wNyjbL5kyLKZJUVPSyBGRloDXE1XA9L6C2xplY7j3KgZZ MLvQ== X-Gm-Message-State: ALoCoQnU4xeXldaA37fBybiN00KFDOHriODbD1tVR3SRCaczForQ/ojvcDwBLAxv7zKW8HGBYyoL X-Received: by 10.180.38.34 with SMTP id d2mr4834563wik.55.1414503892488; Tue, 28 Oct 2014 06:44:52 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id l10sm15455895wif.20.2014.10.28.06.44.51 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 28 Oct 2014 06:44:51 -0700 (PDT) From: Thomas Monjalon To: Jingjing Wu Date: Tue, 28 Oct 2014 14:44:34 +0100 Message-ID: <2263852.MKHN7tgybq@xps13> Organization: 6WIND User-Agent: KMail/4.14.2 (Linux/3.17.1-1-ARCH; KDE/4.14.2; x86_64; ; ) In-Reply-To: <1413939687-11177-12-git-send-email-jingjing.wu@intel.com> References: <1411711418-12881-1-git-send-email-jingjing.wu@intel.com> <1413939687-11177-1-git-send-email-jingjing.wu@intel.com> <1413939687-11177-12-git-send-email-jingjing.wu@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v4 11/21] ethdev: define structures for getting flow director information X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Oct 2014 13:36:05 -0000 2014-10-22 09:01, Jingjing Wu: > +/** > + * A structure used to report the status of the flow director filters in use. > + */ > +struct rte_eth_fdir { > + /** Number of filters with collision indication. */ > + uint16_t collision; > + /** Number of free (non programmed) filters. */ > + uint16_t free; > + /** The Lookup hash value of the added filter that updated the value > + of the MAXLEN field */ > + uint16_t maxhash; > + /** Longest linked list of filters in the table. */ > + uint8_t maxlen; > + /** Number of added filters. */ > + uint64_t add; > + /** Number of removed filters. */ > + uint64_t remove; > + /** Number of failed added filters (no more space in device). */ > + uint64_t f_add; > + /** Number of failed removed filters. */ > + uint64_t f_remove; > +}; rte_eth_fdir is a name which doesn't say what it really is. This structure looks like a collection of statistics. Why not rte_eth_fdir_stats? > +struct rte_eth_fdir_ext { > + uint16_t guarant_spc; /**< guaranteed spaces.*/ > + uint16_t guarant_cnt; /**< Number of filters in guaranteed spaces. */ > + uint16_t best_spc; /**< best effort spaces.*/ > + uint16_t best_cnt; /**< Number of filters in best effort spaces. */ > +}; I don't understand why this "extended" structure is not merged in the first one. Adding new fields don't break old API. > +/** > + * A structure used to get the status information of flow director filter. > + * to support RTE_ETH_FILTER_FDIR with RTE_ETH_FILTER_INFO operation. > + */ OK content of this comment is good. But the second sentence has no start. Please try to have an uppercase letter at the beginning of your sentences, and a subject followed by a verb. (side note: this is also true for commit logs) > +struct rte_eth_fdir_info { > + int mode; /**< if 0 disbale, if 1 enable*/ Typo: disbale -- Thomas