[PATCH] tests: assume c source files are utf-8 encoded

[PATCH] tests: assume c source files are utf-8 encoded

[Robin Jarry]

Instead of relying on the default locale from the environment (LC_ALL),
explicitly read the files as utf-8 encoded.

Fixes: 0aeaf75df879 ("test: define unit tests suites based on test types")

Signed-off-by: Robin Jarry <rjarry@redhat.com>
---
 buildtools/get-test-suites.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/buildtools/get-test-suites.py b/buildtools/get-test-suites.py
index 574c233aa873..c61f6a273fad 100644
--- a/buildtools/get-test-suites.py
+++ b/buildtools/get-test-suites.py
@@ -19,7 +19,7 @@ def get_fast_test_params(test_name, ln):
     return f":{nohuge.strip().lower()}:{asan.strip().lower()}"
 
 for fname in input_list:
-    with open(fname) as f:
+    with open(fname, "r", encoding="utf-8") as f:
         contents = [ln.strip() for ln in f.readlines()]
         test_lines = [ln for ln in contents if test_def_regex.match(ln)]
         non_suite_tests.extend([non_suite_regex.match(ln).group(1)
-- 
2.44.0

Re: [PATCH] tests: assume c source files are utf-8 encoded

[Bruce Richardson]

On Tue, Mar 05, 2024 at 02:46:15PM +0100, Robin Jarry wrote:
> Instead of relying on the default locale from the environment (LC_ALL),
> explicitly read the files as utf-8 encoded.
> 
> Fixes: 0aeaf75df879 ("test: define unit tests suites based on test types")
> 
> Signed-off-by: Robin Jarry <rjarry@redhat.com>
> ---
Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Thanks for the update/fix.

RE: [PATCH] tests: assume c source files are utf-8 encoded

[Morten Brørup]

> From: Robin Jarry [mailto:rjarry@redhat.com]
> Sent: Tuesday, 5 March 2024 14.46
> 
> Instead of relying on the default locale from the environment (LC_ALL),
> explicitly read the files as utf-8 encoded.
> 
> Fixes: 0aeaf75df879 ("test: define unit tests suites based on test types")
> 
> Signed-off-by: Robin Jarry <rjarry@redhat.com>
> ---

I strongly agree on UTF-8 encoding everywhere in the DPDK project, so...

Acked-by: Morten Brørup <mb@smartsharesystems.com>

Re: [PATCH] tests: assume c source files are utf-8 encoded

[Tyler Retzlaff]

On Tue, Mar 05, 2024 at 02:46:15PM +0100, Robin Jarry wrote:
> Instead of relying on the default locale from the environment (LC_ALL),
> explicitly read the files as utf-8 encoded.
> 
> Fixes: 0aeaf75df879 ("test: define unit tests suites based on test types")
> 
> Signed-off-by: Robin Jarry <rjarry@redhat.com>
> ---

Acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>

Re: [PATCH] tests: assume c source files are utf-8 encoded

[Thomas Monjalon]

05/03/2024 14:49, Bruce Richardson:
> On Tue, Mar 05, 2024 at 02:46:15PM +0100, Robin Jarry wrote:
> > Instead of relying on the default locale from the environment (LC_ALL),
> > explicitly read the files as utf-8 encoded.
> > 
> > Fixes: 0aeaf75df879 ("test: define unit tests suites based on test types")
> > 
> > Signed-off-by: Robin Jarry <rjarry@redhat.com>
> > ---
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> 
> Thanks for the update/fix.

Applied, thanks.