DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] mk: Remove '-fdirectives-only' flag from mk/rte.sdkconfig.mk
@ 2015-03-05  7:31 Tetsuya Mukawa
  2015-03-05 10:10 ` Bruce Richardson
  0 siblings, 1 reply; 3+ messages in thread
From: Tetsuya Mukawa @ 2015-03-05  7:31 UTC (permalink / raw)
  To: dev

The '-fdirectives-only' flag doesn't exist in cpp of FreeBSD.
To remove expanding macros when parsing the config files won't
add any issue.

Signed-off-by: Tetsuya Mukawa <mukawa@igel.co.jp>
---
 mk/rte.sdkconfig.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mk/rte.sdkconfig.mk b/mk/rte.sdkconfig.mk
index d43c430..f8d95b1 100644
--- a/mk/rte.sdkconfig.mk
+++ b/mk/rte.sdkconfig.mk
@@ -75,7 +75,7 @@ else
 $(RTE_OUTPUT)/.config: $(RTE_CONFIG_TEMPLATE) FORCE | $(RTE_OUTPUT)
 	$(Q)if [ "$(RTE_CONFIG_TEMPLATE)" != "" -a -f "$(RTE_CONFIG_TEMPLATE)" ]; then \
 		$(CPP) -undef -P -x assembler-with-cpp \
-		-fdirectives-only -ffreestanding \
+		-ffreestanding \
 		-o $(RTE_OUTPUT)/.config_tmp $(RTE_CONFIG_TEMPLATE) ; \
 		if ! cmp -s $(RTE_OUTPUT)/.config_tmp $(RTE_OUTPUT)/.config; then \
 			cp $(RTE_OUTPUT)/.config_tmp $(RTE_OUTPUT)/.config ; \
-- 
1.9.1

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] mk: Remove '-fdirectives-only' flag from mk/rte.sdkconfig.mk
  2015-03-05  7:31 [dpdk-dev] [PATCH] mk: Remove '-fdirectives-only' flag from mk/rte.sdkconfig.mk Tetsuya Mukawa
@ 2015-03-05 10:10 ` Bruce Richardson
  2015-03-05 18:50   ` Thomas Monjalon
  0 siblings, 1 reply; 3+ messages in thread
From: Bruce Richardson @ 2015-03-05 10:10 UTC (permalink / raw)
  To: Tetsuya Mukawa; +Cc: dev

On Thu, Mar 05, 2015 at 04:31:01PM +0900, Tetsuya Mukawa wrote:
> The '-fdirectives-only' flag doesn't exist in cpp of FreeBSD.
> To remove expanding macros when parsing the config files won't
> add any issue.
> 
> Signed-off-by: Tetsuya Mukawa <mukawa@igel.co.jp>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>

> ---
>  mk/rte.sdkconfig.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mk/rte.sdkconfig.mk b/mk/rte.sdkconfig.mk
> index d43c430..f8d95b1 100644
> --- a/mk/rte.sdkconfig.mk
> +++ b/mk/rte.sdkconfig.mk
> @@ -75,7 +75,7 @@ else
>  $(RTE_OUTPUT)/.config: $(RTE_CONFIG_TEMPLATE) FORCE | $(RTE_OUTPUT)
>  	$(Q)if [ "$(RTE_CONFIG_TEMPLATE)" != "" -a -f "$(RTE_CONFIG_TEMPLATE)" ]; then \
>  		$(CPP) -undef -P -x assembler-with-cpp \
> -		-fdirectives-only -ffreestanding \
> +		-ffreestanding \
>  		-o $(RTE_OUTPUT)/.config_tmp $(RTE_CONFIG_TEMPLATE) ; \
>  		if ! cmp -s $(RTE_OUTPUT)/.config_tmp $(RTE_OUTPUT)/.config; then \
>  			cp $(RTE_OUTPUT)/.config_tmp $(RTE_OUTPUT)/.config ; \
> -- 
> 1.9.1
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] mk: Remove '-fdirectives-only' flag from mk/rte.sdkconfig.mk
  2015-03-05 10:10 ` Bruce Richardson
@ 2015-03-05 18:50   ` Thomas Monjalon
  0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2015-03-05 18:50 UTC (permalink / raw)
  To: Tetsuya Mukawa; +Cc: dev

> > The '-fdirectives-only' flag doesn't exist in cpp of FreeBSD.
> > To remove expanding macros when parsing the config files won't
> > add any issue.
> > 
> > Signed-off-by: Tetsuya Mukawa <mukawa@igel.co.jp>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Applied, thanks

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-03-05 18:50 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-05  7:31 [dpdk-dev] [PATCH] mk: Remove '-fdirectives-only' flag from mk/rte.sdkconfig.mk Tetsuya Mukawa
2015-03-05 10:10 ` Bruce Richardson
2015-03-05 18:50   ` Thomas Monjalon

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git