From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7748341DBC; Fri, 3 Mar 2023 02:38:19 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1135440EE3; Fri, 3 Mar 2023 02:38:19 +0100 (CET) Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by mails.dpdk.org (Postfix) with ESMTP id BBE6840687 for ; Fri, 3 Mar 2023 02:38:17 +0100 (CET) Received: from dggpeml500024.china.huawei.com (unknown [172.30.72.53]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4PSVsf3r6Gz16P6f; Fri, 3 Mar 2023 09:35:34 +0800 (CST) Received: from [10.67.100.224] (10.67.100.224) by dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Fri, 3 Mar 2023 09:38:15 +0800 Subject: Re: [PATCH 4/5] net/bnxt: use fp ops setup function To: Konstantin Ananyev , "thomas@monjalon.net" , "ferruh.yigit@amd.com" , Ajit Khaparde , Somnath Kotur CC: "dev@dpdk.org" References: <20230301030610.49468-1-fengchengwen@huawei.com> <20230301030610.49468-5-fengchengwen@huawei.com> From: fengchengwen Message-ID: <22657fed-e920-5df9-8b9b-5bd1f986ff57@huawei.com> Date: Fri, 3 Mar 2023 09:38:15 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.100.224] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpeml500024.china.huawei.com (7.185.36.10) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2023/3/2 20:30, Konstantin Ananyev wrote: > >> Use rte_eth_fp_ops_setup() instead of directly manipulating >> rte_eth_fp_ops variable. >> >> Cc: stable@dpdk.org >> >> Signed-off-by: Chengwen Feng >> --- >> drivers/net/bnxt/bnxt_cpr.c | 5 +---- >> drivers/net/bnxt/bnxt_ethdev.c | 5 +---- >> 2 files changed, 2 insertions(+), 8 deletions(-) >> >> diff --git a/drivers/net/bnxt/bnxt_cpr.c b/drivers/net/bnxt/bnxt_cpr.c >> index 3950840600..a3f33c24c3 100644 >> --- a/drivers/net/bnxt/bnxt_cpr.c >> +++ b/drivers/net/bnxt/bnxt_cpr.c >> @@ -416,10 +416,7 @@ void bnxt_stop_rxtx(struct rte_eth_dev *eth_dev) >> eth_dev->rx_pkt_burst = rte_eth_pkt_burst_dummy; >> eth_dev->tx_pkt_burst = rte_eth_pkt_burst_dummy; > > I am not that familiar with bnxt driver, but shouldn't we set here > other optional fp_ops (descripto_status, etc.) to some dummy values OR to null values? I checked the bnxt PMD code, the other fp_ops (rx_queue_count/rx_descriptor_status/tx_descriptor_status) both add following logic at the beginning of function: rc = is_bnxt_in_error(bp); if (rc) return rc; So I think it okey to keep it. > >> >> - rte_eth_fp_ops[eth_dev->data->port_id].rx_pkt_burst = >> - eth_dev->rx_pkt_burst; >> - rte_eth_fp_ops[eth_dev->data->port_id].tx_pkt_burst = >> - eth_dev->tx_pkt_burst; >> + rte_eth_fp_ops_setup(eth_dev); >> rte_mb(); >> >> /* Allow time for threads to exit the real burst functions. */ >> diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c >> index 4083a69d02..d6064ceea4 100644 >> --- a/drivers/net/bnxt/bnxt_ethdev.c >> +++ b/drivers/net/bnxt/bnxt_ethdev.c >> @@ -4374,10 +4374,7 @@ static void bnxt_dev_recover(void *arg) >> if (rc) >> goto err_start; >> >> - rte_eth_fp_ops[bp->eth_dev->data->port_id].rx_pkt_burst = >> - bp->eth_dev->rx_pkt_burst; >> - rte_eth_fp_ops[bp->eth_dev->data->port_id].tx_pkt_burst = >> - bp->eth_dev->tx_pkt_burst; >> + rte_eth_fp_ops_setup(bp->eth_dev); >> rte_mb(); >> >> PMD_DRV_LOG(INFO, "Port: %u Recovered from FW reset\n", >> -- >> 2.17.1 > > . >