[PATCH] doc: announce dmadev new capability addition

[PATCH] doc: announce dmadev new capability addition

[Vamsi Attunuru]

Announce addition of new capability flag and fields in
rte_dma_info and rte_dma_conf structures.

Signed-off-by: Vamsi Attunuru <vattunuru@marvell.com>
---
RFC:
https://patchwork.dpdk.org/project/dpdk/patch/20240729115558.263574-1-vattunuru@marvell.com/

 doc/guides/rel_notes/deprecation.rst | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index 6948641ff6..05d28473c0 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -147,3 +147,8 @@ Deprecation Notices
   will be deprecated and subsequently removed in DPDK 24.11 release.
   Before this, the new port library API (functions rte_swx_port_*)
   will gradually transition from experimental to stable status.
+
+* dmadev: A new flag ``RTE_DMA_CAPA_QOS`` will be introduced to advertise
+  dma device's QoS capability. Also new fields will be added in ``rte_dma_info``
+  and ``rte_dma_conf`` structures to get device supported priority levels
+  and to configure the required priority level.
-- 
2.25.1

Re: [PATCH] doc: announce dmadev new capability addition

[Jerin Jacob]

On Mon, Jul 29, 2024 at 6:19 PM Vamsi Attunuru <vattunuru@marvell.com> wrote:
>
> Announce addition of new capability flag and fields in

The new capability flag won't break ABI. We can mention only fields
update rte_dma_info and rte_dma_conf structures.

Another option is new set APIs for priority enablement.  The downside
is more code. All, opinions?


> rte_dma_info and rte_dma_conf structures.
>
> Signed-off-by: Vamsi Attunuru <vattunuru@marvell.com>
> ---
> RFC:
> https://patchwork.dpdk.org/project/dpdk/patch/20240729115558.263574-1-vattunuru@marvell.com/
>
>  doc/guides/rel_notes/deprecation.rst | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index 6948641ff6..05d28473c0 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -147,3 +147,8 @@ Deprecation Notices
>    will be deprecated and subsequently removed in DPDK 24.11 release.
>    Before this, the new port library API (functions rte_swx_port_*)
>    will gradually transition from experimental to stable status.
> +
> +* dmadev: A new flag ``RTE_DMA_CAPA_QOS`` will be introduced to advertise
> +  dma device's QoS capability. Also new fields will be added in ``rte_dma_info``
> +  and ``rte_dma_conf`` structures to get device supported priority levels
> +  and to configure the required priority level.
> --
> 2.25.1
>

RE: [PATCH] doc: announce dmadev new capability addition

[Morten Brørup]

> From: Jerin Jacob [mailto:jerinjacobk@gmail.com]
> Sent: Monday, 29 July 2024 17.20
> 
> On Mon, Jul 29, 2024 at 6:19 PM Vamsi Attunuru <vattunuru@marvell.com>
> wrote:
> >
> > Announce addition of new capability flag and fields in
> > rte_dma_info and rte_dma_conf structures.
> 
> The new capability flag won't break ABI. We can mention only fields
> update rte_dma_info and rte_dma_conf structures.
> 
> Another option is new set APIs for priority enablement.  The downside
> is more code. All, opinions?

I think that this feature should be simple enough to expand the rte_dma_info and rte_dma_conf structures with a few new fields, rather than adding a new set of APIs for it.

It seems to become 1-level weighted priority scheduling of a few QoS classes, not hierarchical or anything complex enough to justify a new set of APIs. Just a simple array of per-class properties.

The max possible number of QoS classes (i.e. the array size) should be build time configurable. Considering Marvell hardware, it seems 4 would be a good default.

Re: [PATCH] doc: announce dmadev new capability addition

[Thomas Monjalon]

29/07/2024 17:20, Jerin Jacob:
> On Mon, Jul 29, 2024 at 6:19 PM Vamsi Attunuru <vattunuru@marvell.com> wrote:
> >
> > Announce addition of new capability flag and fields in
> 
> The new capability flag won't break ABI. We can mention only fields
> update rte_dma_info and rte_dma_conf structures.
> 
> Another option is new set APIs for priority enablement.  The downside
> is more code. All, opinions?
> 
> > rte_dma_info and rte_dma_conf structures.

I'm fine with just updating these structs.

> > Signed-off-by: Vamsi Attunuru <vattunuru@marvell.com>

Acked-by: Thomas Monjalon <thomas@monjalon.net>

Any other opinions?

[PATCH v2] doc: announce changes to dma device structures

[Amit Prakash Shukla]

A new flag ``RTE_DMA_CAPA_QOS`` will be introduced to advertise dma device's QoS
capability. In order to support the parameters for this flag, new fields will be
added in ``rte_dma_info`` and ``rte_dma_conf`` structures to get device supported
priority levels and to configure the required priority level.

Signed-off-by: Vamsi Attunuru <vattunuru@marvell.com>
Signed-off-by: Amit Prakash Shukla <amitprakashs@marvell.com>
---
v2 changes:
- Add more description to commit log.
- Add more description to deprecation.rst.

 doc/guides/rel_notes/deprecation.rst | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index 6948641ff6..87f2dfc648 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -147,3 +147,8 @@ Deprecation Notices
   will be deprecated and subsequently removed in DPDK 24.11 release.
   Before this, the new port library API (functions rte_swx_port_*)
   will gradually transition from experimental to stable status.
+
+* dmadev: A new flag ``RTE_DMA_CAPA_QOS`` will be introduced to advertise
+  dma device's QoS capability. In order to support the parameters for this flag,
+  new fields will be added in ``rte_dma_info`` and ``rte_dma_conf`` structures
+  to get device supported priority levels and to configure the required priority level.
-- 
2.34.1

[PATCH v3] doc: announce changes to dma device structures

[Amit Prakash Shukla]

A new flag ``RTE_DMA_CAPA_QOS`` will be introduced to advertise dma device's QoS
capability. In order to support the parameters for this flag, new fields will be
added in ``rte_dma_info`` and ``rte_dma_conf`` structures to get device supported
priority levels and to configure the required priority level.

Signed-off-by: Vamsi Attunuru <vattunuru@marvell.com>
Signed-off-by: Amit Prakash Shukla <amitprakashs@marvell.com>
---
v3 changes:
- Add maintainers in email list.

v2 changes:
- Add more description to commit log.
- Add more description to deprecation.rst.

 doc/guides/rel_notes/deprecation.rst | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index 6948641ff6..87f2dfc648 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -147,3 +147,8 @@ Deprecation Notices
   will be deprecated and subsequently removed in DPDK 24.11 release.
   Before this, the new port library API (functions rte_swx_port_*)
   will gradually transition from experimental to stable status.
+
+* dmadev: A new flag ``RTE_DMA_CAPA_QOS`` will be introduced to advertise
+  dma device's QoS capability. In order to support the parameters for this flag,
+  new fields will be added in ``rte_dma_info`` and ``rte_dma_conf`` structures
+  to get device supported priority levels and to configure the required priority level.
-- 
2.34.1

[PATCH v4] doc: announce changes to dma device structures

[Amit Prakash Shukla]

A new flag RTE_DMA_CAPA_QOS will be introduced to advertise dma
device's QoS capability. In order to support the parameters for this
flag, new fields will be added in rte_dma_info and rte_dma_conf
structures to get device supported priority levels and to configure the
required priority level.

Signed-off-by: Vamsi Attunuru <vattunuru@marvell.com>
Signed-off-by: Amit Prakash Shukla <amitprakashs@marvell.com>
---
v4 changes:
- Fix checkpatch warning.

v3 changes:
- Add maintainers in email list.

v2 changes:
- Add more description to commit log.
- Add more description to deprecation.rst.

 doc/guides/rel_notes/deprecation.rst | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index 6948641ff6..87f2dfc648 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -147,3 +147,8 @@ Deprecation Notices
   will be deprecated and subsequently removed in DPDK 24.11 release.
   Before this, the new port library API (functions rte_swx_port_*)
   will gradually transition from experimental to stable status.
+
+* dmadev: A new flag ``RTE_DMA_CAPA_QOS`` will be introduced to advertise
+  dma device's QoS capability. In order to support the parameters for this flag,
+  new fields will be added in ``rte_dma_info`` and ``rte_dma_conf`` structures
+  to get device supported priority levels and to configure the required priority level.
-- 
2.34.1

Re: [PATCH v4] doc: announce changes to dma device structures

[Jerin Jacob]

On Tue, Jul 30, 2024 at 8:25 PM Amit Prakash Shukla
<amitprakashs@marvell.com> wrote:
>
> A new flag RTE_DMA_CAPA_QOS will be introduced to advertise dma
> device's QoS capability. In order to support the parameters for this
> flag, new fields will be added in rte_dma_info and rte_dma_conf
> structures to get device supported priority levels and to configure the
> required priority level.
>
> Signed-off-by: Vamsi Attunuru <vattunuru@marvell.com>
> Signed-off-by: Amit Prakash Shukla <amitprakashs@marvell.com>


Acked-by: Jerin Jacob <jerinj@marvell.com>


> ---
> v4 changes:
> - Fix checkpatch warning.
>
> v3 changes:
> - Add maintainers in email list.
>
> v2 changes:
> - Add more description to commit log.
> - Add more description to deprecation.rst.
>
>  doc/guides/rel_notes/deprecation.rst | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index 6948641ff6..87f2dfc648 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -147,3 +147,8 @@ Deprecation Notices
>    will be deprecated and subsequently removed in DPDK 24.11 release.
>    Before this, the new port library API (functions rte_swx_port_*)
>    will gradually transition from experimental to stable status.
> +
> +* dmadev: A new flag ``RTE_DMA_CAPA_QOS`` will be introduced to advertise
> +  dma device's QoS capability. In order to support the parameters for this flag,
> +  new fields will be added in ``rte_dma_info`` and ``rte_dma_conf`` structures
> +  to get device supported priority levels and to configure the required priority level.
> --
> 2.34.1
>

Re: [PATCH v4] doc: announce changes to dma device structures

[Thomas Monjalon]

30/07/2024 19:27, Jerin Jacob:
> On Tue, Jul 30, 2024 at 8:25 PM Amit Prakash Shukla
> <amitprakashs@marvell.com> wrote:
> >
> > A new flag RTE_DMA_CAPA_QOS will be introduced to advertise dma
> > device's QoS capability. In order to support the parameters for this
> > flag, new fields will be added in rte_dma_info and rte_dma_conf
> > structures to get device supported priority levels and to configure the
> > required priority level.
> >
> > Signed-off-by: Vamsi Attunuru <vattunuru@marvell.com>
> > Signed-off-by: Amit Prakash Shukla <amitprakashs@marvell.com>
> 
> 
> Acked-by: Jerin Jacob <jerinj@marvell.com>

Acked-by: Thomas Monjalon <thomas@monjalon.net>

Re: [PATCH v4] doc: announce changes to dma device structures

[Thomas Monjalon]

31/07/2024 13:01, Thomas Monjalon:
> 30/07/2024 19:27, Jerin Jacob:
> > On Tue, Jul 30, 2024 at 8:25 PM Amit Prakash Shukla
> > <amitprakashs@marvell.com> wrote:
> > >
> > > A new flag RTE_DMA_CAPA_QOS will be introduced to advertise dma
> > > device's QoS capability. In order to support the parameters for this
> > > flag, new fields will be added in rte_dma_info and rte_dma_conf
> > > structures to get device supported priority levels and to configure the
> > > required priority level.
> > >
> > > Signed-off-by: Vamsi Attunuru <vattunuru@marvell.com>
> > > Signed-off-by: Amit Prakash Shukla <amitprakashs@marvell.com>
> > 
> > 
> > Acked-by: Jerin Jacob <jerinj@marvell.com>
> 
> Acked-by: Thomas Monjalon <thomas@monjalon.net>

The RFC and the deprecation notices are sent a bit late.
We cannot conclude there is consensus.

I propose to raise it to the techboard if an ABI breakage is still required for 24.11.
As dmadev is quite new, I don't think it is big issue.

Re: [PATCH v4] doc: announce changes to dma device structures

[Bruce Richardson]

On Wed, Jul 31, 2024 at 06:06:33PM +0200, Thomas Monjalon wrote:
> 31/07/2024 13:01, Thomas Monjalon:
> > 30/07/2024 19:27, Jerin Jacob:
> > > On Tue, Jul 30, 2024 at 8:25 PM Amit Prakash Shukla
> > > <amitprakashs@marvell.com> wrote:
> > > >
> > > > A new flag RTE_DMA_CAPA_QOS will be introduced to advertise dma
> > > > device's QoS capability. In order to support the parameters for this
> > > > flag, new fields will be added in rte_dma_info and rte_dma_conf
> > > > structures to get device supported priority levels and to configure the
> > > > required priority level.
> > > >
> > > > Signed-off-by: Vamsi Attunuru <vattunuru@marvell.com>
> > > > Signed-off-by: Amit Prakash Shukla <amitprakashs@marvell.com>
> > > 
> > > 
> > > Acked-by: Jerin Jacob <jerinj@marvell.com>
> > 
> > Acked-by: Thomas Monjalon <thomas@monjalon.net>
> 
> The RFC and the deprecation notices are sent a bit late.
> We cannot conclude there is consensus.
> 
> I propose to raise it to the techboard if an ABI breakage is still required for 24.11.
> As dmadev is quite new, I don't think it is big issue.
> 
No objection to changing the structures. However, for the actual
implementation we'll have to review the changes to ensure they are clear
enough to allow potential alternative implementations. For example, I
worry about just having one "QoS" flag defined - how would we manage if
different QoS schemes are implemented by various hw vendors in different
ways?

For the notice about structure changes though:
Acked-by: Bruce Richardson <bruce.richardson@intel.com>