From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 44113A00C2; Fri, 11 Feb 2022 19:09:58 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C017840683; Fri, 11 Feb 2022 19:09:57 +0100 (CET) Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by mails.dpdk.org (Postfix) with ESMTP id 365E240140 for <dev@dpdk.org>; Fri, 11 Feb 2022 19:09:56 +0100 (CET) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id EA20E3201FB7; Fri, 11 Feb 2022 13:09:54 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Fri, 11 Feb 2022 13:09:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; bh=+oH3nUOrKCTjkr Azf9wEtwB9AbMrBjZeg07AChwuWkE=; b=Frdt/W5ObH3ZRip6LycJJWFhCyPfE0 W1Q/jbzCCWCETnXftGQdwOFE3awBHeVHNiJajwNfn7K6EoLk8ciJYuw67zK/AeOw fuIz5xEEGnci/IGj68fUgbyNHD8X5XdIzgKSIrvvpNA2ZCVyEnXfNDyNh5CF61ux LehX7Qxbc0KDHatlWFExlzEb5+L1E9s+RtPTydmKCQINbsbeh7ikilrRrVi39IyL h+ObhbFUYlIE3T2rW7+ZjWChkkPYJxwkLrPK4ezll/WxqrL4nt0bsrOaovjbrbVO LDoe9DYSdAYHtEW8/3j0aP3oJTw2ogt24/eEAJJgtcbEGKFNb/h6gr8A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=+oH3nUOrKCTjkrAzf9wEtwB9AbMrBjZeg07AChwuW kE=; b=BSO2larmcfqw6iP6aXQDeV4DeIzny3OQ5xy64P0qxvb42PRp+HVuZfIWb d4/O/4D08CNfHghKOuyyA8ELjX3LW0Covqv3xALlyOt7U3l4ufSi6b/xSQL+earM EcB4kaL6T9/h3cnniPklx5KafQLR9TjWKb9dgY41Hpr+Tq/oml0Mh0PVz/lIHK2v HSfu5eZwo6twjK0WYEGYWsU2mNIrXyQSVB47kWze97Ha4Fmc2uBeEohBv4S1LprI eBCl3M2zIf9sJLg01VA0Ps3RTSaxYbVh6uGpg78Pfk+oggJZQBbBSca4zgjwV/KT wdYMP+CXjPNpr7bT845ePUkzjJfsA== X-ME-Sender: <xms:cqYGYtVAmhtiHTW7qhMV0tFBsmSTxJRpzMjVdGiml3b_27vABbdUhw> <xme:cqYGYtkUPxmFpOO1Z4g_AxzTpbmkZ0kFNZIZHw30golrYF4rAVyrqyYtMJ7RAe7EK XAEhZI1ES3Pms146Q> X-ME-Received: <xmr:cqYGYpYuA8r4ybxhLjxah0SYKQFf62rY5yDRg_lkQoRXh7tBSCbQPEmxp34TcYJoyhR4ENprmGkF74GYNrcG> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrieefgddutdekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: <xmx:cqYGYgUGYSph-_Ep57FucLZxLOFWY8vejiu1UGMExIJ4Lg3qXVzz-A> <xmx:cqYGYnnSl1Vg96sV6AP1wd6x3OWd7c_qq30l2OYJ1Nj3lw6rbpFbIw> <xmx:cqYGYtfvL08OcS-b1ZuSTfsmWo0il68Ew2c6zW1fq60Urpr62qXU7g> <xmx:cqYGYsxVk6OxhKiZ5JROR2GGT6WlSZx-G1nrvt2FTqUbysSAZNYL4w> Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 11 Feb 2022 13:09:53 -0500 (EST) From: Thomas Monjalon <thomas@monjalon.net> To: Ferruh Yigit <ferruh.yigit@intel.com> Cc: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>, Anatoly Burakov <anatoly.burakov@intel.com>, dev@dpdk.org Subject: Re: [PATCH v3 2/2] ethdev: move driver interface functions to its own file Date: Fri, 11 Feb 2022 19:09:52 +0100 Message-ID: <2267345.BjyWNHgNrj@thomas> In-Reply-To: <20220211171441.2717010-2-ferruh.yigit@intel.com> References: <20220208194437.426143-1-ferruh.yigit@intel.com> <20220211171441.2717010-1-ferruh.yigit@intel.com> <20220211171441.2717010-2-ferruh.yigit@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org 11/02/2022 18:14, Ferruh Yigit: > Relevant functions moved to ethdev_driver.c. > No functional change. > > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com> > --- > lib/ethdev/ethdev_driver.c | 758 ++++++++++++++++++++++++++++++ > lib/ethdev/ethdev_private.c | 131 ++++++ > lib/ethdev/ethdev_private.h | 36 ++ > lib/ethdev/rte_ethdev.c | 901 ------------------------------------ > 4 files changed, 925 insertions(+), 901 deletions(-) Please could you add more details in the commit log while merging? We need to know that they are internal functions used only by drivers. Also it would be interesting to explain the difference between ethdev_driver.c and ethdev_private.h. With this info, Acked-by: Thomas Monjalon <thomas@monjalon.net>