From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 6CCD1A057B;
Thu, 2 Apr 2020 13:20:26 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 47DE32C15;
Thu, 2 Apr 2020 13:20:26 +0200 (CEST)
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
[66.111.4.28]) by dpdk.org (Postfix) with ESMTP id E3B82FFA
for <dev@dpdk.org>; Thu, 2 Apr 2020 13:20:24 +0200 (CEST)
Received: from compute7.internal (compute7.nyi.internal [10.202.2.47])
by mailout.nyi.internal (Postfix) with ESMTP id 7F6495C02A3;
Thu, 2 Apr 2020 07:20:24 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
by compute7.internal (MEProxy); Thu, 02 Apr 2020 07:20:24 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
from:to:cc:subject:date:message-id:in-reply-to:references
:mime-version:content-transfer-encoding:content-type; s=mesmtp;
bh=TR3trd67bh1ZPojm6QTHJZK77tWzPf0VrrAbaH/tOwU=; b=s6p9SqVrvu2D
QJIUfz+XEaleVIwthIAHkf8wOqizab7wfaohOyNEBnPagMpnBSc5IWo2/QtUv20k
+Ewtbq8zVC6X54YJdfiaUvjkTOQerBPH7iBfI2uSNEYYWwqo1VJ8xIfN05r1pwLW
QXc7NRcoMkhzgu7BCiWezP5plPgolMk=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:content-type
:date:from:in-reply-to:message-id:mime-version:references
:subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
:x-sasl-enc; s=fm2; bh=TR3trd67bh1ZPojm6QTHJZK77tWzPf0VrrAbaH/tO
wU=; b=oFC5K/N76FRdAbxv8zwtXj9shSMRFiReXtCntii5X4SeR1g3sbcdJBHLd
uMYD+gfflbQS4arc+rOo4Yc8/rXmcAxwRqgDmAcASG4wO9/4wI/998Ks4G5+QcMX
fytz7l6k1fbbxIryU7GoyBHxZ/4Khi+FXhaM9mvGaiAFfKz8z+njDqiU1PxPIWQr
xo+G0bvNSH10/CBNerb9satFug+wwVAEEk92fzjaRYa+c+X33Xku55PYyHhv63eP
UC71l/FpEMzfu0xnOSx0KtnnrC7JsN78R6KFrNRbeGcgtViObp2IBW7SP8K5pSEK
nE6pfAe92iH7miu6u2VMc98kkuvYw==
X-ME-Sender: <xms:eMqFXkQ_nhXQxkME8Bgt_8J_cra2nFC_dZQ95KGWM3qpkfeD5BMP-g>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrtdeggdeffecutefuodetggdotefrodftvf
curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu
uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc
fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs
ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph
epjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghr
rghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth
X-ME-Proxy: <xmx:eMqFXsoRuxkmBe2KQqtjPsL0mIFV8g1GRMQbU8Ev_9bAqVjWrmWZbQ>
<xmx:eMqFXprPCPz6Pwmo8vZq9s2nBgQWKXXl2RAXW51DlYuNfcehcIkllg>
<xmx:eMqFXmPOJpYtu5uycH_bpWjllrCloy6Pqw1TDT_vqVAEIuDr1BmtcQ>
<xmx:eMqFXlpd1peO5TdBJgvsporAazmZ43TMNK--f-OTZF-pxBHiBZwyHg>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
by mail.messagingengine.com (Postfix) with ESMTPA id 98519328005A;
Thu, 2 Apr 2020 07:20:22 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
Cc: dev@dpdk.org, ferruh.yigit@intel.com, bernard.iremonger@intel.com
Date: Thu, 02 Apr 2020 13:20:21 +0200
Message-ID: <2267488.53lzm7zTb9@xps>
In-Reply-To: <1584625851-10291-3-git-send-email-viacheslavo@mellanox.com>
References: <1561553317-16777-1-git-send-email-viacheslavo@mellanox.com>
<1584625851-10291-1-git-send-email-viacheslavo@mellanox.com>
<1584625851-10291-3-git-send-email-viacheslavo@mellanox.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v2 2/3] app/testpmd: gather Rx and Tx
routines profiling
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
19/03/2020 14:50, Viacheslav Ovsiienko:
> + if (fwdprof_flags & RECORD_CORE_CYCLES_RX && total_recv > 0)
> + printf("\n rx CPU cycles/packet=%u (total cycles="
> + "%"PRIu64" / total RX packets=%"PRIu64")\n",
> + (unsigned int)(rx_cycles / total_recv),
> + rx_cycles, total_recv);
> + if (fwdprof_flags & RECORD_CORE_CYCLES_TX && total_xmit > 0)
> + printf("\n tx CPU cycles/packet=%u (total cycles="
> + "%"PRIu64" / total TX packets=%"PRIu64")\n",
> + (unsigned int)(tx_cycles / total_xmit),
> + tx_cycles, total_xmit);
This is the "UI", so I think it deserves a cautious review.
Instead of "=" without space, I think ": " is easier to read.
Please use "Rx" and "Tx" instead of lowercase ones.
"CPU cycles/packet" is hard to read. I would prefer either
"cycles/packet" without CPU
or
"cycles per packet"
I will continue some UI comments in next patch.