From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 321361B8E4; Wed, 11 Apr 2018 10:46:49 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id D544D218FE; Wed, 11 Apr 2018 04:46:48 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 11 Apr 2018 04:46:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=CxYUyepSwnPd5Q4oWjbfnjDdQe 26FaPZUWYxIhlal4M=; b=DAgiS1N+vjgWeyO/w+Gby1ZOIVg6FDQWXjB/pfG5xh LSjq8Y2SnPnfvrs6RPRhCX9RhfnEoBjnGNL1RbNIenqE9SSs/zq7T39pLEmJbW6F DlnF3LLtQ5Mbj1MpXybJ/JOpDNcxSZ3rH1jf90gIxUeUoctJxJpxY/MNTNHOnfGQ A= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=CxYUye pSwnPd5Q4oWjbfnjDdQe26FaPZUWYxIhlal4M=; b=ZvtzlbTVy681KrT1/Tju7E SsgLVpbu/Sd+OTNRlpyvy0BCZzYGL5LNQYvGCyxk3TpYYGMc6Eiu8CNxWQEYqpOQ YsCcjIlS9eYzLFZteIJixlrNb2eWeYGCu5Ok/CYO/UQg9qDscwiVX2OYBGMlwVuL Tq49+QHMfjP/Kynw1oL8aEkFQcHaCUffC9VA8nO7m+x41J0B+kfvFPH7U0R43syB r5G/23iyypY8l6qXY9OP3b2hxtYv3dy/+U+vqiHS7x3XlJrz0jkp/VNnv5BR6Snp cD2qzpGUvWVIIF54A6bbf0R1x07cs6KBXKgYHPk9boYoUx8OiRAYtG7oCaze+67g == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 4BC38E4441; Wed, 11 Apr 2018 04:46:48 -0400 (EDT) From: Thomas Monjalon To: Pavan Nikhilesh Cc: techboard@dpdk.org, dev@dpdk.org Date: Wed, 11 Apr 2018 10:46:47 +0200 Message-ID: <2267766.OAdEpiXt1a@xps> In-Reply-To: <20180411083819.GA27100@ltp-pvn> References: <20180406110103.29163-1-pbhagavatula@caviumnetworks.com> <3084545.g1xfDtWPys@xps> <20180411083819.GA27100@ltp-pvn> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] eal: fix clang compilation error on ARM64 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Apr 2018 08:46:49 -0000 11/04/2018 10:38, Pavan Nikhilesh: > On Tue, Apr 10, 2018 at 11:35:15PM +0200, Thomas Monjalon wrote: > > Hi, big issue here. > > This patch does not compile on Linux with ICC or GCC < 4.9 > > because of a missing C11 header: > > #include > > > > GCC 4.9 is recommended in doc/guides/linux_gsg/sys_reqs.rst. > > But GCC 4.8 is used by SLES 12, RHEL 7, etc... > > > > Note: Intel compilation tests are running with a backlog of one week, > > so cannot catch such fail. > > > > Exceptionnaly, I have decided to remove this patch pushed few hours ago > > (not reverting), in order to avoid a serious "git bisect" breakage > > in the middle of the git history. > > > > We'll need to find a better way of fixing the compilation error > > seen on ARM with clang. > > To make it clear: I believe it is more important to preserve GCC 4.8 > > than clang compilation. > > By the way, what is the version of clang which was causing the error? > > I have tried with clang 4/5/6 and all have the same issue. Do you know why the issue is not seen on x86? > > The error was: > > include/generic/rte_atomic.h:215:9: error: > > implicit declaration of function '__atomic_exchange_2' > > is invalid in C99 > > include/generic/rte_atomic.h:494:9: error: > > implicit declaration of function '__atomic_exchange_4' > > is invalid in C99 > > include/generic/rte_atomic.h:772:9: error: > > implicit declaration of function '__atomic_exchange_8' > > is invalid in C99 > > > > The proposed solution was: > > Use __atomic_exchange_n instead of __atomic_exchange_(2/4/8), > > and include stdatomic.h. > > > > > > > > 10/04/2018 17:07, Thomas Monjalon: > > > 06/04/2018 20:25, Pavan Nikhilesh: > > > > On Fri, Apr 06, 2018 at 06:24:34PM +0200, Thomas Monjalon wrote: > > > > > 06/04/2018 13:01, Pavan Nikhilesh: > > > > > > Use __atomic_exchange_n instead of __atomic_exchange_(2/4/8). > > > > > > > > > > > > Fixes: ff2863570fcc ("eal: introduce atomic exchange operation") > > [...] > > > Applied (with error log), thanks