From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45]) by dpdk.org (Postfix) with ESMTP id 19A599AC4 for ; Wed, 2 Mar 2016 14:48:47 +0100 (CET) Received: by mail-wm0-f45.google.com with SMTP id l68so81043393wml.0 for ; Wed, 02 Mar 2016 05:48:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=AxCenmRQTLv9cPhzwAzjs4jrokfHR9odRqtXv32ZEUo=; b=E64pR7rfkCoXRkhJ0vKyaIiZ9zQF6SoJ9gGlC2HjlQqjNx9XZBRNcUadr0YDLwWiTj YkAiPZs9nSycT1TqmwAtiDV7DxAuVoHD1aWhFlv45QIKe9kr9cgJNZEhAmVdW2yxXCtv tt4/r5EU9NYDOdmDm1WJl0NKCQNbjLL6J2vsAhIgcsLhX+vnuVnv1Pk6/vBRCBzLrPDV 6Xc52p6IflD79gHSFLubgpuOThiTTy9kXtrV+HzdqVMK+F0G+mDyqX8rMqtl67hMD+v2 C2Crl0I/YdtdqFTGmsEQBIQrDHADTBUuR0AxTnfVgnb4DoASPQxQYNG+4sRUrESUgVIa FsfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding; bh=AxCenmRQTLv9cPhzwAzjs4jrokfHR9odRqtXv32ZEUo=; b=ZlYQ7wHhVhNcHv89QKH2mgCeYSKbnUZCuXdm2KZvnS0MRRNmyNeN22Q3mpY0xnnnVo aC1DJ4T1rRYj9pCaQqHvWaorr6UyjRP07HWKTC9DW9bOLT56TF2UTTJ5UHsnRcQv039X ka9ny94ugK7CxVM5cNIDYzKd3iqg+QJLdxkFvPbKA80Vy/zkhmazSEQUWt+D9wGeyiCD 6YeWbUgmmfsj4NoCV/34zOIXm1gGIA7sCMikO56/JmFWnWT/CYsnVcOPmxge6vQTJbDJ Gje01sxcxxRGLxfmHj78O5PA5Li/Ypdssdj4IpNYzn8imEmNeFlzKwhbXpn9CzNZO/P8 f9mA== X-Gm-Message-State: AD7BkJIIaB04nsSSgR5BGLRdMzPL5xAQVki3CsuVAPU9SxBr4egaA4Yean7eDJceCrghHqBK X-Received: by 10.194.48.111 with SMTP id k15mr29583856wjn.103.1456926526879; Wed, 02 Mar 2016 05:48:46 -0800 (PST) Received: from xps13.localnet (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by smtp.gmail.com with ESMTPSA id 73sm4258677wmy.22.2016.03.02.05.48.45 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 02 Mar 2016 05:48:46 -0800 (PST) From: Thomas Monjalon To: Stephen Hemminger Date: Wed, 02 Mar 2016 14:47:11 +0100 Message-ID: <2271991.zTyknjfr7H@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20160301143751.710ef28e@xeon-e3> References: <1454557129-12825-2-git-send-email-xiao.w.wang@intel.com> <1456810601-7419-2-git-send-email-xiao.w.wang@intel.com> <20160301143751.710ef28e@xeon-e3> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v4 1/3] fm10k: enable FTAG based forwarding X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Mar 2016 13:48:47 -0000 2016-03-01 14:37, Stephen Hemminger: > On Tue, 1 Mar 2016 13:36:39 +0800 > Wang Xiao W wrote: > > +static int > > +fm10k_check_ftag(struct rte_devargs *devargs) > > +{ > > + if (devargs == NULL) > > + return 0; > > + > > + if (strstr(devargs->args, "enable_ftag=1") == NULL) > > + return 0; > > + > > + return 1; > > +} > > It is good to see the DPDK keeping up with the leading edge of hardware > support. > > My issue is that devargs are the Linux module parameters method of > configuration in the DPDK world. They are an API only a developer > would love.. > > 1. It has to be done at boot For vdev it can be done later. The devargs can be generalized in the driver model to provide a configuration interface per device. > 2. Applications have to rewrite (or expect customer) to pass args Like said above, if the devargs are correctly implemented, there will be some API to pass them. > 3. Can't be changed at runtime Same point as 1. > 4. Can't be selected on per device basis. No. The devargs are args per device. For PCI, they are currently passed in the whitelist. > Please find a better way. Another way would be to extend the configuration structures. I think it's better to re-think the device configuration and the command line using some devargs and more functions, ops and structs to configure the really generic stuff. This devargs goes in the direction of a flexible configuration, so I'd vote +1.