From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f49.google.com (mail-wg0-f49.google.com [74.125.82.49]) by dpdk.org (Postfix) with ESMTP id BCBEB1F7 for ; Mon, 29 Sep 2014 21:44:49 +0200 (CEST) Received: by mail-wg0-f49.google.com with SMTP id x12so1126877wgg.20 for ; Mon, 29 Sep 2014 12:51:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=r7nr2csGf+DfC6RCi/4iOiAfjg0vENAIpkfBEddkpqU=; b=CIwILg8PLSCbc3N993bmguhjchr4b9dPaiVwa9WfmT9qM7bZ/hSDpQaXsQETC9Y2sK ZjCDC20FO4EUBxOzbasXu2jCYNh0kUmuMNoylPof9ww91wKZJMkDui9nYbWboOjGGbnU PslWIJsJo/KZPy/HiUx6ycQrEF9LbKmjQMhq6mGf1m3an31LejmUfIWas0DaqBm4Fnus 7Q2P703Yreae/BCOEq5hEr8Os8Q+ccTua7hzXxfWM+a+ekPPGB3O2q5h5+8Ne/UNOEVy tuYYK0CU8jzaBu8uzor0iAyFmZb0ZksdalqIN31ezAJkgodVHfGIvVbQYf8xbBs6wCaA EnSw== X-Gm-Message-State: ALoCoQkuod/86S3YLjauwD3TIhbQXf1d2OQvyOiTS0bNniZVQbC2ovqWQLLcarFPPCNqQDCrQLml X-Received: by 10.180.75.229 with SMTP id f5mr54838wiw.81.1412020287044; Mon, 29 Sep 2014 12:51:27 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id q2sm12718917wiy.23.2014.09.29.12.51.25 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 29 Sep 2014 12:51:26 -0700 (PDT) From: Thomas Monjalon To: Huawei Xie Date: Mon, 29 Sep 2014 21:51:14 +0200 Message-ID: <2272982.l4SiTbeYM2@xps13> Organization: 6WIND User-Agent: KMail/4.13.3 (Linux/3.15.8-1-ARCH; KDE/4.13.3; x86_64; ; ) In-Reply-To: <1411724758-27488-4-git-send-email-huawei.xie@intel.com> References: <1411724758-27488-1-git-send-email-huawei.xie@intel.com> <1411724758-27488-4-git-send-email-huawei.xie@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v5 03/11] lib/librte_vhost: vhost lib transform X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Sep 2014 19:44:49 -0000 2014-09-26 17:45, Huawei Xie: > This vhost lib consists of five APIs plus several other helper routines > for feature disable/enable. > 1) rte_vhost_driver_register initialises vhost driver. > 2) rte_vhost_driver_callback_register registers the callbacks. > Callbacks are called from vhost driver when virtio device is ready > for polling or is de-activated by guest. > 3) rte_vhost_driver_session_start, a blocking API to start vhost > message handler session. > 4) rte_vhost_enqueue_burst and rte_vhost_dequeue_burst for > enqueue/dequeue to/from virtio ring. There are probably many things here to split in different patches. It's not mandatory but would be very nice. Example: a patch to remove hpa_memory_regions would explain why it is removed. > Modifications include: > 1) in vhost_rxtx.c > virtio_dev_rx -> rte_vhost_enqueue_burst > virtio_dev_tx -> rte_vhost_dequeue_burst > 2) VMDQ, MAC learning and other switch related logics are removed. > 3) zero copy feature isn't generic at this stage, and is removed. > 4) retry logic is removed from vhost rx functions. > The above three logics will be implemented in example as reference. > 5) Add several TODO/FIXME: > -allow application to disable cmpset reserve in rte_vhost_enqueue_burst > in case there is no contention. > -fix memcpy from mbuf to vring desc when mbuf is chained and the > desc couldn't hold all the data > -fix vhost_set_mem_table possible race condition: two vqs concurrently > calls set_mem_table which cause saved mem_temp to be overide. > 6) merge-able feature is removed, which will be merged in subsequent patch. Please do not remove a feature which is re-added later. It's really difficult to follow such history. -- Thomas